search for: conne

Dear all, I have made patch for samba-2.0.7/source/smbd/conn.c This will, instead of using by-directional link, use array for managing connections. # The patch does seems to work on my RHL6.1Ja(fixed) version of # Linux machine. I don't know about other OS/Architecture. This should work better then original because: 1) The original code used bitmap.c for looking empty area. But using bitmap.c is still nothing more then liniar s...

Since commit 86fdb48c6a5362d66865493d9d2172166f99722e we have stored the connection object in thread-local storage. In this very large, but mostly mechanical change we stop passing the connection pointer around everywhere, and instead use the value stored in thread-local storage. This assumes a 1-1 mapping between the connection and the current thread which is true in *most...

...{ - struct backend_filter *f = container_of (b, struct backend_filter, backend); - - return f->backend.next->magic_config_key (f->backend.next); + return b->next->magic_config_key (b->next); } static int @@ -236,7 +230,7 @@ static int filter_open (struct backend *b, struct connection *conn, int readonly) { struct backend_filter *f = container_of (b, struct backend_filter, backend); - struct b_conn nxdata = { .b = f->backend.next, .conn = conn }; + struct b_conn nxdata = { .b = b->next, .conn = conn }; void *handle; debug ("%s: open readonly=%d"...

The third patch is a large but mechanical change which gets rid of passing around struct connection * entirely within the server, preferring instead to reference the connection through thread-local storage. I hope this is a gateway to simplifying other parts of the code. Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2020-February/msg00081.html v2 replaces struct connection *conn = GET_CONN; with GET_CONN; which sets conn implicitly and asserts that it is non-NULL. If we actually want to test if conn is non-NULL or behave differently, then you must use threadlocal_get_conn() instead, and some existing uses do that. Rich.

This time around, the numbers are indeed looking better than in v1; and I like the interface better. Eric Blake (2): server: Prefer send() over write() server: Group related transmission send()s server/internal.h | 7 +++- server/connections.c | 51 +++++++++++++++++++++++++--- server/crypto.c | 11 ++++-- server/protocol-handshake-newstyle.c | 22 ++++++------ server/protocol-handshake-oldstyle.c | 2 +- server/protocol.c | 22 ++++++------ 6 files changed, 85 insertions(+...

Previously only one handle could be stored, but we will need to store multiple handles when we have filters. The plugin handle is defined as index 0. Filters will use indices > 0. --- src/connections.c | 37 ++++++++++++++++++++++++++++++------- src/internal.h | 4 ++-- src/plugins.c | 53 +++++++++++++++++++++++++++-------------------------- 3 files changed, 59 insertions(+), 35 deletions(-) diff --git a/src/connections.c b/src/connections.c index e1ac543..51a9772 100644 --- a/s...

...ds beyond EOF in both the xz and retry filter. Refactoring backend.c will make .finalize work easier. Eric Blake (5): xz: Avoid reading beyond EOF retry: Check size before transactions tests: Test retry when get_size values change server: Fix backend range check server: Refactor to drop connection_get_handle() server/internal.h | 66 +++++++------ server/backend.c | 53 ++++++---- server/connections.c | 2 +- server/filters.c | 70 +++++-------- server/plugins.c | 142 ++++++++++--------...

...ore often than not I was able to crash or hand on the test-socket-activation test; I've posted another series for the crashes, as well as analysis of the hang. Until the hang is solved, I'm leaving this series as RFC, but review is welcome to see if my approach is sound. Eric Blake (6): connections: Simplify handle_request() connections: Avoid plugin when shutdown is imminent connections: Add read/write lock over client I/O connections: Add thread-safe status indicator connections: Set up thread pool for handling client requests Add --threads option for supporting true paralle...

...red, but we will need to store multiple handles when we have filters. The plugin handle is defined as index 0. Filters will use indices > 0. Message-Id: <20180117205356.8699-6-rjones@redhat.com> [eblake: rework for FUA support] Signed-off-by: Eric Blake <eblake@redhat.com> --- src/connections.c | 37 ++++++++++++++++++++++++++++++------- src/internal.h | 4 ++-- src/plugins.c | 53 +++++++++++++++++++++++++++-------------------------- 3 files changed, 59 insertions(+), 35 deletions(-) diff --git a/src/connections.c b/src/connections.c index 7a4c7bb..e225b5c 100644 --- a/s...

This isn't quite finished because not all of the tests or examples have been updated, but it demonstrates an idea: Should we forget about the concept of having multiple connections managed under a single handle? In this patch there is a single ‘struct nbd_handle *’ which manages a single state machine and connection (and therefore no nbd_connection). To connect to a multi-conn server you must do something like: - Connect once, check if the server supports multi-conn....

No need to duplicate maintenance of export flag computation between old and new style handshakes. Signed-off-by: Eric Blake <eblake@redhat.com> --- src/connections.c | 120 +++++++++++++++++++++--------------------------------- 1 file changed, 47 insertions(+), 73 deletions(-) diff --git a/src/connections.c b/src/connections.c index 8dc1925..f9edea7 100644 --- a/src/connections.c +++ b/src/connections.c @@ -237,13 +237,57 @@ free_connection (struct con...

These are a couple of patches in preparation for the Block Status implementation. While the patches (especially the second one) are very large they are really just elementary code motion. Rich.

The code handling the NBD protocol was located in the same file as the code handling connections, for not really any reason except historical. This is quite a large code movement which splits out the protocol code into four new files: server/protocol-handshake.c initial handshake server/protocol-handshake-newstyle.c " " (newstyle) server/protocol-hand...

...more than necessary in implementing .can_fast_zero). Eric Blake (9): server: Fewer dereferences in filter server: Consolidate common backend tasks into new backend.c server: Create new backend_* functions for central handling server: Rework storage of per-backend handle server: Cache per-connection size server: Cache per-connection can_FOO flags filters: Change semantics of .can_zero server: Move fallbacks from protocol.c to backend.c server: Move command validation from protocol.c to backend.c docs/nbdkit-filter.pod | 62 +++- docs/nbdkit-plugin.pod...

Future patches want to allow a filter to pass a single opaque parameter into another framework (such as ext2fs_open) or even spawn a helper thread, which requires that nxdata be stable for the entire life of the connection between .open and .close. Our current approach of creating a stack-allocated nxdata for every call does not play nicely with that scheme, so rework things into using a malloc'd pointer. In fact, if we use struct b_conn as our filter handle, and merely add an additional field to track the...

# HG changeset patch # User Rusty Russell <rusty@rustcorp.com.au> # Node ID b0de1894df67ac7c7d905bf61cdf0210b42752cc # Parent ba5d5bd28edf8bce89bdf9fc64047ee4f1dceded Xenstore watch rework Change watches to all fire simultaneously, removing priority argument. Watches no longer fired back to connection/domain which caused event. Fix up testsuite to match Use state enum, rather than return value inside daemon to determine blockage Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> diff -r ba5d5bd28edf -r b0de1894df67 linux-2.6.11-xen-sparse/drivers/xen/xenbus/xenbus_probe.c --- a/li...

...scope=0 deref=0 filter="(objectClass=*)" conn=327 op=9 SRCH attr=supportedExtension conn=327 op=9 SEARCH RESULT tag=101 err=0 nentries=1 text= conn=327 op=10 PASSMOD id="cn=John Doe,ou=People,o=example,c=xx" new conn=327 op=10 RESULT oid= err=0 text= conn=327 fd=26 closed (connection lost) conn=328 fd=27 closed (connection lost) Case2: I login to Machine2 and invoke smbpasswd. However I get "Password changed for user jdoe", but quite havy problems emerge. From now on I can't login to Machine1 and Machine2 neither with smbclient nor with ssh (which uses PO...

...because a client hanging up after an option response that it didn't like (rather than sending NBD_OPT_ABORT to inform the server that it won't be negotiating further) is a surprisingly common behavior among some existing clients. Signed-off-by: Eric Blake <eblake@redhat.com> --- src/connections.c | 60 ++++++++++++++++++++++++++++++----------------- 1 file changed, 39 insertions(+), 21 deletions(-) diff --git a/src/connections.c b/src/connections.c index 58ed6b0..577f466 100644 --- a/src/connections.c +++ b/src/connections.c @@ -600,6 +600,31 @@ send_newstyle_option_reply_info_expo...

...ain: 656400.1 685795.0 4.48% tcp tls: 114552.1 120197.3 4.93% which looks like an overall improvement, even though it is still close to the margins for being in the noise. Signed-off-by: Eric Blake <eblake@redhat.com> --- server/internal.h | 4 ++++ server/connections.c | 10 ++++++++-- server/crypto.c | 7 +++++++ server/protocol-handshake-newstyle.c | 10 +++++----- server/protocol.c | 16 +++++++++------- 5 files changed, 33 insertions(+), 14 deletions(-) diff --git a/server/internal.h b/server/i...