search for: config_help

I like this change. I think we were overloading the config_complete method before to do two different things (complete configuration; do any allocation/housekeeping necessary before we can start serving). The only questions in my mind are whether we want this before 1.18, and whether the name ("get_ready") is a good one. Rich.

.../ static struct nbdkit_filter filter = { - .name = "ext2", - .longname = "nbdkit ext2 filter", - .load = ext2_load, - .unload = ext2_unload, - .config = ext2_config, - .config_complete = ext2_config_complete, - .config_help = ext2_config_help, - .thread_model = ext2_thread_model, - .open = ext2_open, - .prepare = ext2_prepare, - .close = ext2_close, - .can_fua = ext2_can_fua, - .can_cache = ext2_can_cache, - .get_size = ext2_get_size, - ....

...void *nxdata, static struct nbdkit_filter filter = { .name = "blocksize", .longname = "nbdkit blocksize filter", - .version = PACKAGE_VERSION, .config = blocksize_config, .config_complete = blocksize_config_complete, .config_help = blocksize_config_help, diff --git a/filters/cache/cache.c b/filters/cache/cache.c index b5dbccd2..fb852df9 100644 --- a/filters/cache/cache.c +++ b/filters/cache/cache.c @@ -615,7 +615,6 @@ cache_cache (struct nbdkit_next_ops *next_ops, void *nxdata, static struct nbdkit_filter filter = {...

...ter = { > - .name = "ext2", > - .longname = "nbdkit ext2 filter", > - .load = ext2_load, > - .unload = ext2_unload, > - .config = ext2_config, > - .config_complete = ext2_config_complete, > - .config_help = ext2_config_help, > - .thread_model = ext2_thread_model, > - .open = ext2_open, > - .prepare = ext2_prepare, > - .close = ext2_close, > - .can_fua = ext2_can_fua, > - .can_cache = ext2_can_cache, > - .get_...

Applies on top of my pending series for the exportname filter, addressing one of the todo's in that cover letter. Eric Blake (2): filters: Add .export_description wrappers ext2: Supply .list_exports and .default_export filters/ext2/nbdkit-ext2-filter.pod | 3 +- tests/Makefile.am | 16 +++- filters/ext2/ext2.c | 125 +++++++++++++++++++---------

v2 turned out to be much more involved, as I ended up fixing several things along the way that I noticed while debugging a feature addition. Eric Blake (5): maint: Improve ./nbdkit option parsing main: Saner newline printing during --help utils: Add nbdkit_parse_bool main: Use new bool parser for --tls log: Allow user option of appending to log docs/nbdkit-plugin.pod | 11

...(void *nxdata); +typedef int nbdkit_next_ready_to_serve (void *nxdata); typedef int nbdkit_next_open (void *nxdata, int readonly); @@ -129,6 +130,7 @@ struct nbdkit_filter { int (*config_complete) (nbdkit_next_config_complete *next, void *nxdata); const char *config_help; int (*thread_model) (void); + int (*ready_to_serve) (nbdkit_next_ready_to_serve *next, void *nxdata); void * (*open) (nbdkit_next_open *next, void *nxdata, int readonly); diff --git a/include/nbdkit-plugin.h b/include/nbdkit-plugin.h index 45ae705..746d9a1 100644 --- a/...

...pod +++ b/plugins/python/nbdkit-python-plugin.pod @@ -304,8 +304,25 @@ S<C<nbdkit.set_error (errno.EOPNOTSUPP)>>. These are not needed because you can just use ordinary Python constructs. -=item Missing: C<name>, C<version>, C<longname>, C<description>, -C<config_help>, C<can_fua>, C<can_cache>, C<cache> +=item Missing: C<thread_model> + +Probably not implementable while Python has a global interpreter lock. + +=item Missing: +C<name>, +C<version>, +C<longname>, +C<description>, +C<config_help>, +C<magi...

...} +/* Serves the same data over multiple connections. */ +static int +pattern_can_multi_conn (void *handle) +{ + return 1; +} + /* Read data. */ static int pattern_pread (void *handle, void *buf, uint32_t count, uint64_t offset, @@ -118,6 +125,7 @@ static struct nbdkit_plugin plugin = { .config_help = pattern_config_help, .open = pattern_open, .get_size = pattern_get_size, + .can_multi_conn = pattern_can_multi_conn, .pread = pattern_pread, /* In this plugin, errno is preserved properly along error return * paths from failed system cal...

...t;eval", + .version = PACKAGE_VERSION, + .load = eval_load, + .unload = eval_unload, - .dump_plugin = sh_dump_plugin, + .dump_plugin = sh_dump_plugin, - .config = eval_config, - .config_complete = eval_config_complete, - .config_help = eval_config_help, - .thread_model = sh_thread_model, - .get_ready = sh_get_ready, - .after_fork = sh_after_fork, + .config = eval_config, + .config_complete = eval_config_complete, + .config_help = eval_config_help, + .thread_model = sh...

...s>. + =item B<libdir=>PATHNAME This sets the path of the VMware VDDK distribution. diff --git a/plugins/vddk/vddk.c b/plugins/vddk/vddk.c index 6deb0a0b..344b4e6b 100644 --- a/plugins/vddk/vddk.c +++ b/plugins/vddk/vddk.c @@ -416,7 +416,7 @@ vddk_config_complete (void) } #define vddk_config_help \ - "file=<FILENAME> (required) The filename (eg. VMDK file) to serve.\n" \ + "[file=]<FILENAME> (required) The filename (eg. VMDK file) to serve.\n" \ "Many optional parameters are supported, see nbdkit-vddk-plugin(3)." static void @@ -901,6 +...

Eric: Did you want to take this one any further? It might be one that we save for > 1.18: https://www.redhat.com/archives/libguestfs/2020-February/thread.html#00206 Another thing I've been thinking about for some time is splitting .config_complete into .config_complete + .get_ready (new name TBD). At the moment .config_complete is both the place where we finish processing config, and

...@@ -64,16 +64,9 @@ offset_config (nbdkit_next_config *next, void *nxdata, return next (nxdata, key, value); } -/* Check the user did pass both parameters. */ -static int -offset_config_complete (nbdkit_next_config_complete *next, void *nxdata) -{ - return next (nxdata); -} - #define offset_config_help \ - "offset=<OFFSET> (required) The start offset to serve.\n" \ - "range=<LENGTH> The total size to serve." + "offset=<OFFSET> The start offset to serve (default 0).\n" \ + "range=<LENGTH> The...

..._next_get_ready (nbdkit_backend *nxdata); typedef int nbdkit_next_preconnect (nbdkit_backend *nxdata, int readonly); typedef int nbdkit_next_open (nbdkit_backend *nxdata, int readonly); @@ -143,6 +144,7 @@ struct nbdkit_filter { nbdkit_backend *nxdata); const char *config_help; int (*thread_model) (void); + int (*get_ready) (nbdkit_next_get_ready *next, nbdkit_backend *nxdata); int (*preconnect) (nbdkit_next_preconnect *next, nbdkit_backend *nxdata, int readonly); diff --git a/include/nbdkit-plugin.h b/include/nbdkit-plugin.h index b4ecf658...

...C<errno_is_reliable> - -This is not needed because the process of gluing Perl code into C cannot -reliably use C<errno>. Instead, call C<Nbdkit::set_error> when reporting -a failure. - =item Missing: C<name>, C<version>, C<longname>, C<description>, C<config_help> These are not yet supported. diff --git a/plugins/perl/perl.c b/plugins/perl/perl.c index 317a775..d9ad842 100644 --- a/plugins/perl/perl.c +++ b/plugins/perl/perl.c @@ -647,16 +647,6 @@ perl_trim (void *handle, uint32_t count, uint64_t offset) return 0; } -/* We can't guarantee th...

On Wed, Aug 26, 2020 at 09:16:48PM -0500, Eric Blake wrote: > Implementing .default_export with its 'const char *' return is tricky > in the sh plugin: we must return dynamic memory, but must avoid a > use-after-free. And we don't want to change the return type of > .default_export to 'char *', because that would make our choice of > malloc()/free() part of the

And fill out most of the missing bits of the API. Rich.

...ar Perl C<BEGIN> and C<END> constructs. +=item Missing: C<errno_is_reliable> + +This is not needed because the process of gluing Perl code into C cannot +reliably use C<errno>. + =item Missing: C<name>, C<version>, C<longname>, C<description>, C<config_help> These are not yet supported. diff --git a/plugins/perl/perl.c b/plugins/perl/perl.c index 935e1ba..ec82ecb 100644 --- a/plugins/perl/perl.c +++ b/plugins/perl/perl.c @@ -584,6 +584,16 @@ perl_trim (void *handle, uint32_t count, uint64_t offset) return 0; } +/* We can't guarantee that...

See patch 1 for rationale.

...const char *version; const char *description; void (*load) (void); void (*unload) (void); int (*config) (nbdkit_next_config *next, void *nxdata, const char *key, const char *value); int (*config_complete) (nbdkit_next_config_complete *next, void *nxdata); const char *config_help; void * (*open) (int readonly); void (*close) (void *handle); int64_t (*get_size) (struct nbdkit_next *next, void *nxdata, void *handle); int (*can_write) (struct nbdkit_next *next, void *nxdata, void *handle); int (*can_flush) (struct nbdkit_...