search for: config_drm_fbdev_emul

Ilia Mirkin wrote: > I suspect the fb0 issue is because you disabled > CONFIG_DRM_FBDEV_EMULATION? Does the freeze also happen with 4.3? Any > chance you could bisect? I saw this config option, but I didn't realize that. The issue also occurs with 4.3. I even tried 4.3-rc1 with the same results. Would the DRM_FBDEV_EMULATION effect 3D? > On Mon, Jan 11, 2016 at 7:23 PM, Wakko...

Please keep me in the CC. I am not subscribed to this list. When booting 4.4.0 on one of my systems, when nouveau loads, the screen goes into powersave. It doesn't appear to register the fb0 device. When X starts up, the screen comes back and I'm able to login. When launching anything that accesses 3D, the screen freezes. Nothing is logged in either X or dmesg. This same system works

On Fri, Jan 15, 2016 at 5:04 PM, Wakko Warner <wakko at animx.eu.org> wrote: > Ilia Mirkin wrote: >> I suspect the fb0 issue is because you disabled >> CONFIG_DRM_FBDEV_EMULATION? Does the freeze also happen with 4.3? Any >> chance you could bisect? > > I saw this config option, but I didn't realize that. > The issue also occurs with 4.3. I even tried 4.3-rc1 with the same results. > > Would the DRM_FBDEV_EMULATION effect 3D? Shouldn't, b...

...b_helper_fbdev_teardown also requires "info->fbdefio" to > be dynamically allocated. Replace the existing defio config by > drm_fb_helper_defio_init to accomodate this. > > Testing results: startx with fbdev, modesetting and qxl all seems to > work. Tested also with CONFIG_DRM_FBDEV_EMULATION=n, fbdev obviously > fails but others are fine. QEMU -spice and QEMU -spice with vdagent and > multiple (resized) displays (via remote-viewer) also works. > unbind vtconsole and rmmod has *not* regressed (i.e. it still trips on a > use-after-free in qxl_check_idle via qxl_ttm_fini)...

I suspect the fb0 issue is because you disabled CONFIG_DRM_FBDEV_EMULATION? Does the freeze also happen with 4.3? Any chance you could bisect? On Mon, Jan 11, 2016 at 7:23 PM, Wakko Warner <wakko at animx.eu.org> wrote: > Please keep me in the CC. I am not subscribed to this list. > > When booting 4.4.0 on one of my systems, when nouveau loads, the s...

...@@ #include <linux/i2c.h> #include <linux/i2c-algo-bit.h> +struct drm_fb_helper; +struct drm_fb_helper_surface_size; + struct edid; struct radeon_bo; struct radeon_device; @@ -935,12 +938,15 @@ void dce8_program_fmt(struct drm_encoder *encoder); /* fbdev layer */ #if defined(CONFIG_DRM_FBDEV_EMULATION) -void radeon_fbdev_setup(struct radeon_device *rdev); +int radeon_fbdev_driver_fbdev_probe(struct drm_fb_helper *fb_helper, + struct drm_fb_helper_surface_size *sizes); +#define RADEON_FBDEV_DRIVER_OPS \ + .fbdev_probe = radeon_fbdev_driver_fbdev_probe void radeon_fbdev_set_suspend(st...

...{ - struct drm_info_node *node = (struct drm_info_node *) m->private; + struct drm_info_node *node = m->private; struct drm_device *dev = node->minor->dev; struct drm_printer p = drm_seq_file_printer(m); @@ -45,7 +45,7 @@ static int mm_show(struct seq_file *m, void *arg) #ifdef CONFIG_DRM_FBDEV_EMULATION static int fb_show(struct seq_file *m, void *arg) { - struct drm_info_node *node = (struct drm_info_node *) m->private; + struct drm_info_node *node = m->private; struct drm_device *dev = node->minor->dev; struct drm_fb_helper *helper = dev->fb_helper; struct drm_framebu...

...{ - struct drm_info_node *node = (struct drm_info_node *) m->private; + struct drm_info_node *node = m->private; struct drm_device *dev = node->minor->dev; struct drm_printer p = drm_seq_file_printer(m); @@ -45,7 +45,7 @@ static int mm_show(struct seq_file *m, void *arg) #ifdef CONFIG_DRM_FBDEV_EMULATION static int fb_show(struct seq_file *m, void *arg) { - struct drm_info_node *node = (struct drm_info_node *) m->private; + struct drm_info_node *node = m->private; struct drm_device *dev = node->minor->dev; struct drm_fb_helper *helper = dev->fb_helper; struct drm_framebu...

...tion where a driver would actually want to use this without > checking the return value, so enforce that > - Rewrite and clarify the documentation for both helpers. > - Make sure to return true in the drm_fb_helper_suspend_hotplug() stub > that's provided in drm_fb_helper.h when CONFIG_DRM_FBDEV_EMULATION > isn't enabled > - Actually grab the toplevel fb_helper lock in > drm_fb_helper_resume_hotplug(), since it's possible other activity > (such as a hotplug) could be going on at the same time the driver > calls drm_fb_helper_resume_hotplug(). We need this to check...

...(struct drm_info_node *) m->private; > + struct drm_info_node *node = m->private; > struct drm_device *dev = node->minor->dev; > struct drm_printer p = drm_seq_file_printer(m); > > @@ -45,7 +45,7 @@ static int mm_show(struct seq_file *m, void *arg) > #ifdef CONFIG_DRM_FBDEV_EMULATION > static int fb_show(struct seq_file *m, void *arg) > { > - struct drm_info_node *node = (struct drm_info_node *) m->private; > + struct drm_info_node *node = m->private; > struct drm_device *dev = node->minor->dev; > struct drm_fb_helper *helper = dev-&...

...(struct drm_info_node *) m->private; > + struct drm_info_node *node = m->private; > struct drm_device *dev = node->minor->dev; > struct drm_printer p = drm_seq_file_printer(m); > > @@ -45,7 +45,7 @@ static int mm_show(struct seq_file *m, void *arg) > #ifdef CONFIG_DRM_FBDEV_EMULATION > static int fb_show(struct seq_file *m, void *arg) > { > - struct drm_info_node *node = (struct drm_info_node *) m->private; > + struct drm_info_node *node = m->private; > struct drm_device *dev = node->minor->dev; > struct drm_fb_helper *helper = dev-&...

...ere's no situation where a driver would actually want to use this without checking the return value, so enforce that - Rewrite and clarify the documentation for both helpers. - Make sure to return true in the drm_fb_helper_suspend_hotplug() stub that's provided in drm_fb_helper.h when CONFIG_DRM_FBDEV_EMULATION isn't enabled - Actually grab the toplevel fb_helper lock in drm_fb_helper_resume_hotplug(), since it's possible other activity (such as a hotplug) could be going on at the same time the driver calls drm_fb_helper_resume_hotplug(). We need this to check whether or not drm_fb_...

...ere's no situation where a driver would actually want to use this without checking the return value, so enforce that - Rewrite and clarify the documentation for both helpers. - Make sure to return true in the drm_fb_helper_suspend_hotplug() stub that's provided in drm_fb_helper.h when CONFIG_DRM_FBDEV_EMULATION isn't enabled - Actually grab the toplevel fb_helper lock in drm_fb_helper_resume_hotplug(), since it's possible other activity (such as a hotplug) could be going on at the same time the driver calls drm_fb_helper_resume_hotplug(). We need this to check whether or not drm_fb_...

Latest version of https://patchwork.freedesktop.org/series/46815/ , with one small change re: ilia Lyude Paul (5): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend() drm/nouveau: Fix deadlock with fb_helper with async RPM requests drm/nouveau: Use pm_runtime_get_noresume() in connector_detect()

Next version of https://patchwork.freedesktop.org/series/46815/ Same as previous version, but some small changes made to commit messages and acks/rbs have been added Lyude Paul (5): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend() drm/nouveau: Fix deadlock with fb_helper with async RPM requests

Latest version of https://patchwork.freedesktop.org/series/46815/ with some significant improvements: - I finally figured out a clean way to do this entirely with runtime PM helpers, no avoiding grabbing refs required! - Since this new method removes the need for a lot of the other changes I made (although we probably still want those changes, but not for fixing these deadlocks)

This is the latest version of https://patchwork.freedesktop.org/series/46815/ With a bunch of fixes to the new fb_helper to prevent it from breaking module loading/unloading with nouveau. Also; lots of documentation fixes and one fix in response to a kbuild bot. Lyude Paul (8): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Enable polling even if we have runtime

This is the latest version of https://patchwork.freedesktop.org/series/46815/ I moved everything out of fb_helper and back into nouveau, because it seems that other drivers actually do have this handled already as far as I can tell. Lyude Paul (13): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend()

...ivers/gpu/drm/tegra/drm.h index 6d6da01282f3..f5078e06ad40 100644 --- a/drivers/gpu/drm/tegra/drm.h +++ b/drivers/gpu/drm/tegra/drm.h @@ -26,16 +26,10 @@ struct reset_control; -struct tegra_fb { - struct drm_framebuffer base; - struct tegra_bo **planes; - unsigned int num_planes; -}; - #ifdef CONFIG_DRM_FBDEV_EMULATION struct tegra_fbdev { struct drm_fb_helper base; - struct tegra_fb *fb; + struct drm_framebuffer *fb; }; #endif diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 25acb73ee728..81e82ddbe748 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @...

...ivers/gpu/drm/tegra/drm.h index 6d6da01282f3..f5078e06ad40 100644 --- a/drivers/gpu/drm/tegra/drm.h +++ b/drivers/gpu/drm/tegra/drm.h @@ -26,16 +26,10 @@ struct reset_control; -struct tegra_fb { - struct drm_framebuffer base; - struct tegra_bo **planes; - unsigned int num_planes; -}; - #ifdef CONFIG_DRM_FBDEV_EMULATION struct tegra_fbdev { struct drm_fb_helper base; - struct tegra_fb *fb; + struct drm_framebuffer *fb; }; #endif diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 25acb73ee728..81e82ddbe748 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @...