search for: computesizeandoffset

...tch adds the functionality but does not use it, the 2nd > patch uses ref_addr. > If you think I should merge the two and commit as a single patch, let me > know. > > >> I may need to refer to the second patch in reviewing this first one. >> DwarfDebug.cpp: >> computeSizeAndOffsets: >> I believe this produces the wrong offset for the 3rd CU and >> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >> relative to the Offset passed in, so it should be assigned to SecOffset, >> not added to it. (eg: if you have CUs at 0, 42,...

Might be easier if these were on Phabricator, but here are some thoughts: 0001: This patch generally, while separated for legibility, is untested & difficult to discuss in isolation. I may need to refer to the second patch in reviewing this first one. DwarfDebug.cpp: computeSizeAndOffsets: I believe this produces the wrong offset for the 3rd CU and onwards. computeSizeAndOffset returns the EndOffset which is absolute, not relative to the Offset passed in, so it should be assigned to SecOffset, not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass through Sec...

...> patch uses ref_addr. >>> If you think I should merge the two and commit as a single patch, let me >>> know. >>> >>> >>>> I may need to refer to the second patch in reviewing this first one. >>>> DwarfDebug.cpp: >>>> computeSizeAndOffsets: >>>> I believe this produces the wrong offset for the 3rd CU and >>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>> not added to it...

...in isolation. > I agree, this patch adds the functionality but does not use it, the 2nd patch uses ref_addr. If you think I should merge the two and commit as a single patch, let me know. > I may need to refer to the second patch in reviewing this first one. > DwarfDebug.cpp: > computeSizeAndOffsets: > I believe this produces the wrong offset for the 3rd CU and onwards. > computeSizeAndOffset returns the EndOffset which is absolute, not relative > to the Offset passed in, so it should be assigned to SecOffset, not added > to it. (eg: if you have CUs at 0, 42, and 57 - the fi...

...oes not use it, the 2nd >> patch uses ref_addr. >> If you think I should merge the two and commit as a single patch, let me >> know. >> >> >>> I may need to refer to the second patch in reviewing this first one. >>> DwarfDebug.cpp: >>> computeSizeAndOffsets: >>> I believe this produces the wrong offset for the 3rd CU and >>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>> relative to the Offset passed in, so it should be assigned to SecOffset, >>> not added to it. (eg: if you ha...

...ink I should merge the two and commit as a single patch, let >>>>> me know. >>>>> >>>>> >>>>>> I may need to refer to the second patch in reviewing this first one. >>>>>> DwarfDebug.cpp: >>>>>> computeSizeAndOffsets: >>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>...

...t;>>> If you think I should merge the two and commit as a single patch, let >>>> me know. >>>> >>>> >>>>> I may need to refer to the second patch in reviewing this first one. >>>>> DwarfDebug.cpp: >>>>> computeSizeAndOffsets: >>>>> I believe this produces the wrong offset for the 3rd CU and >>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>...

...> patch uses ref_addr. >>> If you think I should merge the two and commit as a single patch, let me >>> know. >>> >>> >>>> I may need to refer to the second patch in reviewing this first one. >>>> DwarfDebug.cpp: >>>> computeSizeAndOffsets: >>>> I believe this produces the wrong offset for the 3rd CU and >>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>> not added to it...

...oes not use it, the 2nd >> patch uses ref_addr. >> If you think I should merge the two and commit as a single patch, let me >> know. >> >> >>> I may need to refer to the second patch in reviewing this first one. >>> DwarfDebug.cpp: >>> computeSizeAndOffsets: >>> I believe this produces the wrong offset for the 3rd CU and >>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>> relative to the Offset passed in, so it should be assigned to SecOffset, >>> not added to it. (eg: if you ha...

...wo and commit as a single patch, let >>>>>> me know. >>>>>> >>>>>> >>>>>>> I may need to refer to the second patch in reviewing this first one. >>>>>>> DwarfDebug.cpp: >>>>>>> computeSizeAndOffsets: >>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>> relative to the Offset passed in, so it should be assigned to SecOffs...

...atch, let >>>>>>> me know. >>>>>>> >>>>>>>> >>>>>>>> I may need to refer to the second patch in reviewing this first one. >>>>>>>> DwarfDebug.cpp: >>>>>>>> computeSizeAndOffsets: >>>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>> relative to the Offset passed in, so it should be assigne...

...wo and commit as a single patch, let >>>>>> me know. >>>>>> >>>>>> >>>>>>> I may need to refer to the second patch in reviewing this first one. >>>>>>> DwarfDebug.cpp: >>>>>>> computeSizeAndOffsets: >>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>> relative to the Offset passed in, so it should be assigned to SecOffs...

...> let me know. >>>>>>> >>>>>>> >>>>>>>> I may need to refer to the second patch in reviewing this first >>>>>>>> one. >>>>>>>> DwarfDebug.cpp: >>>>>>>> computeSizeAndOffsets: >>>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>> relative to the Offset passed in, so it should be assigne...

...t;>>>>>> >>>>>>>> >>>>>>>>> I may need to refer to the second patch in reviewing this first >>>>>>>>> one. >>>>>>>>> DwarfDebug.cpp: >>>>>>>>> computeSizeAndOffsets: >>>>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>>> relative to the Offset passed in, so it shoul...

...t;> >>>>>>>>> >>>>>>>>>> I may need to refer to the second patch in reviewing this first >>>>>>>>>> one. >>>>>>>>>> DwarfDebug.cpp: >>>>>>>>>> computeSizeAndOffsets: >>>>>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>>>> relative to the Offset passed in,...

...gt;>>>>>> >>>>>>>>>>> I may need to refer to the second patch in reviewing this first >>>>>>>>>>> one. >>>>>>>>>>> DwarfDebug.cpp: >>>>>>>>>>> computeSizeAndOffsets: >>>>>>>>>>> I believe this produces the wrong offset for the 3rd CU >>>>>>>>>>> and onwards. computeSizeAndOffset returns the EndOffset which is absolute, >>>>>>>>>>> not relative to the Offse...

...gt;>>>>>> >>>>>>>>>>> I may need to refer to the second patch in reviewing this first >>>>>>>>>>> one. >>>>>>>>>>> DwarfDebug.cpp: >>>>>>>>>>> computeSizeAndOffsets: >>>>>>>>>>> I believe this produces the wrong offset for the 3rd CU >>>>>>>>>>> and onwards. computeSizeAndOffset returns the EndOffset which is absolute, >>>>>>>>>>> not relative to the Offse...

Ping -Manman On Fri, Oct 4, 2013 at 7:00 PM, Manman Ren <manman.ren at gmail.com> wrote: > > Hi All, > > The first patch adds support for ref_addr. > Most of it is from r176882, but instead of always using an integer for > ref_addr, we use label + offset for relocation on non-darwin platforms. > > The second patch is a modified version of r191792. > The main

...gt;>> >>>>>>>>>>>> I may need to refer to the second patch in reviewing this >>>>>>>>>>>> first one. >>>>>>>>>>>> DwarfDebug.cpp: >>>>>>>>>>>> computeSizeAndOffsets: >>>>>>>>>>>> I believe this produces the wrong offset for the 3rd CU >>>>>>>>>>>> and onwards. computeSizeAndOffset returns the EndOffset which is absolute, >>>>>>>>>>>> not relative...

Hi All, The first patch adds support for ref_addr. Most of it is from r176882, but instead of always using an integer for ref_addr, we use label + offset for relocation on non-darwin platforms. The second patch is a modified version of r191792. The main change is to use a single map instead of 3 maps in DwarfDebug and instead of calling DwarfDebug::getDIE|insertDIE directly, we delegate the