search for: compiler_rt_uses_libcxx

...ibc++ is set? >>> >> Hi Erik, IIRC, using -stdlib=libc++ on Mac should also require presence of flag -mmacosx-version-min? If that's the case, then probably we can put the logic of determining the set of flags required for libc++ into CMake build rules and use CMake variable like COMPILER_RT_USES_LIBCXX. Does the attached patch solve a problem for you? If you're building LLVM/Clang tree, however, we may want to hoist this to smth. like LLVM_USES_LIBCXX. > >> I don't know the specific needs of either libc++ or the sanitizer on mac; >> instead this should be answered by one...

...t;>> > Hi Erik, > IIRC, using -stdlib=libc++ on Mac should also require presence of flag > -mmacosx-version-min? If that's the case, then probably we can put the logic > of determining the set of flags required for libc++ into CMake build rules > and use CMake variable like COMPILER_RT_USES_LIBCXX. Does the attached > patch solve a problem for you? If you're building LLVM/Clang tree, > however, we may want to hoist this to smth. like LLVM_USES_LIBCXX. > > > Yes, that works, when I (manually) set the COMPILER_RT_USES_LIBCXX flag. I > was wondering if that flag could actu...

...libc++ is set? > > Hi Erik, > IIRC, using -stdlib=libc++ on Mac should also require presence of flag -mmacosx-version-min? If that's the case, then probably we can put the logic > of determining the set of flags required for libc++ into CMake build rules and use CMake variable like COMPILER_RT_USES_LIBCXX. Does the attached > patch solve a problem for you? If you're building LLVM/Clang tree, however, we may want to hoist this to smth. like LLVM_USES_LIBCXX. Yes, that works, when I (manually) set the COMPILER_RT_USES_LIBCXX flag. I was wondering if that flag could actually be set when detecti...

+samsonov, glider On Tue, Feb 5, 2013 at 12:16 PM, Chandler Carruth <chandlerc at google.com>wrote: > On Mon, Feb 4, 2013 at 6:21 AM, Erik Verbruggen <erik.verbruggen at me.com>wrote: > >> Hi Chandler, >> >> If I remember correctly, you are the de-facto maintainer for the >> CMake-built-mainainer, so..: >> > > Sure, but I'm often busy.

...ce I can't say if removing them this way is the correct solution, or if maybe the CMakeLists.txt files just needs to properly quote these strings. Here's my shortened version of that whole `if(APPLE)` block: > if(APPLE) > set(SANITIZER_COMMON_SUPPORTED_DARWIN_OS osx) > > if(COMPILER_RT_USES_LIBCXX) > set(SANITIZER_MIN_OSX_VERSION 10.7) > else() > set(SANITIZER_MIN_OSX_VERSION 10.6) > endif() > set(DARWIN_osx_CFLAGS -mmacosx-version-min=${SANITIZER_MIN_OSX_VERSION}) > set(DARWIN_osx_LINKFLAGS) > endif() So, can anyone who's familiar with CMakeLists.txt com...

On Mon, Feb 4, 2013 at 6:21 AM, Erik Verbruggen <erik.verbruggen at me.com>wrote: > Hi Chandler, > > If I remember correctly, you are the de-facto maintainer for the > CMake-built-mainainer, so..: > Sure, but I'm often busy. You're better off using the development mailing list for questions such as this, and I've moved the conversation there. > I have a