search for: commentp

...diff --git a/authfile.c b/authfile.c index 35ccf576c2b5..6c79369ebfc1 100644 --- a/authfile.c +++ b/authfile.c @@ -116,7 +116,7 @@ sshkey_perm_ok(int fd, const char *filename) ? ?int ?sshkey_load_private_type(int type, const char *filename, const char *passphrase, -??? struct sshkey **keyp, char **commentp) +??? struct sshkey **keyp, char **commentp, struct sshkey_vault **vault_infop) ?{ ??? ?int fd, r; ? @@ -124,6 +124,8 @@ sshkey_load_private_type(int type, const char *filename, const char *passphrase, ??? ??? ?*keyp = NULL; ??? ?if (commentp != NULL) ??? ??? ?*commentp = NULL; +?? ?if (vault_infop...

...ssh/identity" also fails to format the prompt properly ("Enter passphrase for :"). The issue is as follows: Starting at ssh-add.c:158 in add_file(ac, filename = "~/.ssh/identity"), we call key_load_private(filename = "~/.ssh/identity", passphrase = "", commentp = &comment) key_parse_private_type(blob = <contents of ~/.ssh/identity>, KEY_RSA1, passphrase = "", commentp = &comment) key_parse_private_rsa1(blob, passphrase = "", commentp = &comment). In key_parse_private_rsa1, at authfile.c:423-424, we execute if (comm...

....c +++ b/authfile.c @@ -215,44 +215,6 @@ sshkey_load_private_type_fd(int fd, int type, const char *passphrase, return r; } -/* XXX this is almost identical to sshkey_load_private_type() */ -int -sshkey_load_private(const char *filename, const char *passphrase, - struct sshkey **keyp, char **commentp) -{ - struct sshbuf *buffer = NULL; - int r, fd; - - if (keyp != NULL) - *keyp = NULL; - if (commentp != NULL) - *commentp = NULL; - - if ((fd = open(filename, O_RDONLY)) == -1) - return SSH_ERR_SYSTEM_ERROR; - if (sshkey_perm_ok(fd, filename) != 0) { - r = SSH_ERR_KEY_BAD_PERMISSIONS; - goto...

https://bugzilla.mindrot.org/show_bug.cgi?id=3068 Bug ID: 3068 Summary: Duplicate code in sshkey_load_private() function Product: Portable OpenSSH Version: 8.0p1 Hardware: Other OS: Windows 10 Status: NEW Severity: enhancement Priority: P5 Component: ssh-keygen Assignee:

...------------ diff -u openssh-6.1p1/authfile.c openssh-6.1p1-lano/authfile.c --- openssh-6.1p1/authfile.c 2012-02-10 22:19:02.000000000 +0100 +++ openssh-6.1p1-lano/authfile.c 2012-09-08 11:59:08.000000000 +0200 @@ -792,6 +792,58 @@ return 0; } +Key * +key_load_public_pem(char *filename, char **commentp) +{ + FILE *fp = NULL; + EVP_PKEY *pk = NULL; + X509 *x = NULL; + Key *pub = NULL; + char *name = "<no key>"; + + fp = fopen(filename, "r"); + if (fp == NULL) { + error("fopen of %s failed: %s", filename, strerror(errno)); + return NULL; + } + x = PEM_read_X509...

...uthfile.c?? | 5 +++++ ?ssh-keygen.c | 6 +----- ?2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/authfile.c b/authfile.c index 50fa48e4a3b6..9e6e2a00a896 100644 --- a/authfile.c +++ b/authfile.c @@ -304,6 +304,11 @@ sshkey_load_public(const char *filename, struct sshkey **keyp, char **commentp) ???? if ((r = sshkey_try_load_public(keyp, pubfile, commentp)) == 0) ???? ??? goto out; ? +??? /* If the comment is wanted, try loading the private key with no passphrase, +??? ??? since it contains the comment while the public key in the private file doesn't */ +??? if (commentp != NULL &amp...

...========================================= key_load_engine_private() added to authfile.c: --------------------------------------------- 48a49,50 > #include <openssl/conf.h> > #include <openssl/engine.h> 611a614,679 > return prv; > } > > /* Arguments passphrase and commentp are not used */ > Key * > key_load_engine_private(char *engkey, const char *conffile, > const char* stanza, const char *passphrase, char **commentp) > { > ENGINE *eng = NULL; > EVP_PKEY *pk = NULL; > Key *prv = NULL; > char *name = "&...

...@@@"); error("@ WARNING: UNPROTECTED PRIVATE KEY FILE! @"); error("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@"); @@ -525,14 +528,14 @@ Key * key_load_private_type(int type, const char *filename, const char *passphrase, - char **commentp) + char **commentp, int group_private_key) { int fd; fd = open(filename, O_RDONLY); if (fd < 0) return NULL; - if (!key_perm_ok(fd, filename)) { + if (!key_perm_ok(fd, filename, group_private_key)) { error("bad permissions: ignore key: %s", filename); close(fd);...

...04/18 23:44:51 1.32 +++ authfile.c 2001/05/16 20:51:57 1.33 @@ -555,7 +555,8 @@ lseek(fd, (off_t) 0, SEEK_SET); /* rewind */ if (pub == NULL) { /* closes fd */ - return key_load_private_pem(fd, KEY_UNSPEC, passphrase, NULL); + return key_load_private_pem(fd, KEY_UNSPEC, passphrase, + commentp); } else { /* it's a SSH v1 key if the public key part is readable */ key_free(pub);

On Wed, 17 Feb 2016, Hisashi T Fujinaka wrote: > > I need to make these error messages more user-friendly :( > > > > -24 is SSH_ERR_SYSTEM_ERROR, so it's likely failing to find/load the > > key for some reason. I'll make a patch to improve the error message, > > but in the meantime you could probably figure out the exact failure > > using

https://bugzilla.mindrot.org/show_bug.cgi?id=3190 Bug ID: 3190 Summary: Inconsistent handling of private keys without accompanying public keys Product: Portable OpenSSH Version: 8.3p1 Hardware: Other OS: Linux Status: NEW Severity: enhancement Priority: P5 Component:

On Wed, Feb 17, 2016 at 3:51 AM, Hisashi T Fujinaka <htodd at twofifty.com> wrote: > Sorry, I haven't been paying too much attention here, but I'm having > repeated failures when I tried this morning. > > NetBSD-current: > test_sshkey: ..................................[1] Segmentation fault > (core dumped) ${V} /home/htodd... > *** Error code 139 did it

http://bugzilla.mindrot.org/show_bug.cgi?id=439 ------- Additional Comments From djm at mindrot.org 2003-05-14 22:35 ------- This won't work through protocol 2 agent connections IIRC ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

...to start ssh from a scheduled task in Windows 2000. I got the message "Enter passphrase for key '.ssh/identity':" Well the passphrase I set was empty, so that should not have happen. I traced this problem to the method key_load_public_type(int type, const char *filename, char **commentp) in authfile.c If the file cannot be opened (in my case the "System" user was not authorized to do so) this method returns NULL without an appropriate message. The calling method load_identity_file(char *filename) in sshconnect2.c doesn not handle any error cases. So, if the key_load_p...

Hello openssh-unix-dev list members, This is related to my previous post, but I need to ask specific questions. I'm building openssh with iPhone Toolchain (http://wikee.iphwn.org/howto:toolchain_on_leopard_aspen) for iPhone 2.1 firmware. This is not an iPhone mailing list, but probably anyone with deep knowledge of openssh could give a hint. So this is what I do: 1. I patch the files using

Hi, OpenSSH 5.3 is almost ready for release, so we would appreciate testing on as many platforms and systems as possible. This release contains some substantial new features and a number of bugfixes. Snapshot releases for portable OpenSSH are available from http://www.mindrot.org/openssh_snap/ The OpenBSD version is available in CVS HEAD: http://www.openbsd.org/anoncvs.html Portable OpenSSH is

Tried the user discussion list to no avail, can't get 3.6.p2 portable running due to buffer_get errors. Does the latest portable SNAP incorporate the latest patches? Running Red Hat 8.0 AS SHIPPED /usr/sbin/sshd ... cool, listens on 22 with 3.4p1 WITH 3.6.1p2 ./configure make make install ... /usr/local/sbin/sshd -t -f /usr/local/etc/sshd_config buffer_get: trying to get more bytes 1 than

...est you incorporate this patch into both the OpenBSD and portable OpenSSH. --- authfile.c.orig 2004-12-11 03:39:50.000000000 +0100 +++ authfile.c 2005-05-19 22:16:51.000000000 +0200 @@ -598,7 +598,7 @@ return prv; } -static int +int key_try_load_public(Key *k, const char *filename, char **commentp) { FILE *f; --- authfile.h.orig 2002-06-06 21:57:34.000000000 +0200 +++ authfile.h 2005-05-19 23:03:35.000000000 +0200 @@ -18,6 +18,7 @@ int key_save_private(Key *, const char *, const char *, const char *); Key *key_load_public(const char *, char **); Key *key_load_public_type(int, con...

...} + } + _remove_applications($g, @remove); + + # Installing these guest utilities automatically unconfigures ttys in + # /etc/inittab if the system uses it. We need to put them back. + if (scalar(@remove) > 0) { + eval { + my $updated = 0; + for my $commentp ($g->aug_match('/files/etc/inittab/#comment')) { + my $comment = $g->aug_get($commentp); + + # The entries in question are named 1-6, and will normally be + # active in runlevels 2-5. They will be gettys. We could be + # extr...

...} + } + _remove_applications($g, @remove); + + # Installing these guest utilities automatically unconfigures ttys in + # /etc/inittab if the system uses it. We need to put them back. + if (scalar(@remove) > 0) { + eval { + my $updated = 0; + for my $commentp ($g->aug_match('/files/etc/inittab/#comment')) { + my $comment = $g->aug_get($commentp); + + # The entries in question are named 1-6, and will normally be + # active in runlevels 2-5. They will be gettys. We could be + # extr...