search for: commandrvf

...39; + test 1 = 1 + cmd='guestfsd --verbose --network' + echo guestfsd --verbose --network guestfsd --verbose --network + guestfsd --verbose --network lvm config: lvmetad warning: lvmetad command failed trying to open virtio-serial channel '/dev/virtio-ports/org.libguestfs.channel.0' commandrvf: stdout=n stderr=y flags=0x0 commandrvf: udevadm --debug settle calling: settle libguestfs: recv_from_daemon: received GUESTFS_LAUNCH_FLAG libguestfs: appliance is up libguestfs: trace: launch = 0 libguestfs: trace: c_pointer libguestfs: trace: c_pointer = 93852701051408 libguestfs: trace: list_par...

...26 (aug_close) took 0.03 seconds >> libguestfs: trace: v2v: aug_close = 0 >> libguestfs: trace: v2v: selinux_relabel >> "/etc/selinux/targeted/contexts/files/file_contexts" "/" "force:true" >> guestfsd: main_loop: new request, len 0x6c >> commandrvf: stdout=n stderr=y flags=0x0 >> commandrvf: setfiles -F -e /sysroot/dev -e /sysroot/proc -e >> /sysroot/selinux -e /sysroot/sys -r /sysroot -q >> /sysroot/etc/selinux/targeted/contexts/files/file_contexts /sysroot/ >> Can't stat exclude path "/sysroot/selinux",...

Improve readability of commandrvf() by replacing bare int values for file descriptors with their symbolic names STD{IN,OUT,ERR}_FILENO. Also add PIPE_READ and PIPE_WRITE for referencing relevant ends of a pipe. --- daemon/guestfsd.c | 79 +++++++++++++++++++++++++++++-------------------------- 1 file changed, 42 insertions(+), 37...

...s passed to command*(), indicate that as stdout=e in debugging message. --- daemon/command.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/daemon/command.c b/daemon/command.c index 73fce56..2423a4e 100644 --- a/daemon/command.c +++ b/daemon/command.c @@ -185,6 +185,7 @@ commandrvf (char **stdoutput, char **stderror, unsigned flags, int so_fd[2], se_fd[2]; unsigned flag_copy_stdin = flags & COMMAND_FLAG_CHROOT_COPY_FILE_TO_STDIN; int flag_copy_fd = (int) (flags & COMMAND_FLAG_FD_MASK); + unsigned flag_out_on_err = flags & COMMAND_FLAG_FOLD_STDOUT_ON_STDE...

...l=[^[:space:]]+' /proc/cmdline + eval + test x '!=' x + test 1 = 1 + cmd='guestfsd --verbose' + test '' = 1 + echo guestfsd --verbose guestfsd --verbose + guestfsd --verbose lvmetad trying to open virtio-serial channel '/dev/virtio-ports/org.libguestfs.channel.0' commandrvf: stdout=n stderr=y flags=0x0 commandrvf: udevadm --debug settle calling: settle libguestfs: recv_from_daemon: received GUESTFS_LAUNCH_FLAG libguestfs: appliance is up libguestfs: trace: launch = 0 libguestfs: trace: c_pointer libguestfs: trace: c_pointer = 31447856 libguestfs: trace: list_partition...

...(char **stdoutput, char **stderror, int flags, > const char *name, ...) __attribute__((sentinel)); > diff --git a/daemon/guestfsd.c b/daemon/guestfsd.c > index 0a29aa6..47245f7 100644 > --- a/daemon/guestfsd.c > +++ b/daemon/guestfsd.c > @@ -932,21 +932,44 @@ commandrvf (char **stdoutput, char **stderror, int flags, > signal (SIGPIPE, SIG_DFL); > close (0); > if (flag_copy_stdin) { > - dup2 (flag_copy_fd, STDIN_FILENO); > + if (dup2 (flag_copy_fd, STDIN_FILENO) == -1) { > + perror ("dup2/flag_copy_fd"); &...

...> (gdb) bt > #0 ?0x00007f6dd17b4701 in _Py_INCREF (op=<optimized out>) at /usr/include/ > python3.9/object.h:408 > #1 ?guestfs_int_py_event_callback_wrapper > ? ? (g=<optimized out>, flags=<optimized out>, array_len=0, array=0x0, buf_len= > 43, buf=0xd1dc90 "commandrvf: udevadm --debug settle -E /\347\232\204\303 > available\r\ned7 > #2 ?guestfs_int_py_event_callback_wrapper > ? ? (g=<optimized out>, callback=0x7f6dd19ec040, event=16, event_handle=0, > flags=<optimized out>, buf=0xd1dc90 "commandrvf: udevadm --debug settle -E /\ >...

...Derek Atkins wrote: >> > Running `virt-v2v -v -x ...' and observing the output will give you a >> > good idea of what precisely it was doing for those hours. >> >> Well, as I said in my original email, it was hanging at running >> setfiles: >> >> commandrvf: stdout=n stderr=y flags=0x0 >> commandrvf: setfiles -F -e /sysroot/dev -e /sysroot/proc -e >> /sysroot/selinux -e /sysroot/sys -r /sysroot -q >> /sysroot/etc/selinux/targeted/contexts/files/file_contexts /sysroot/ >> Can't stat exclude path "/sysroot/selinux",...

...in some cases the other systems that completed in minutes had MORE disk usage). > Running `virt-v2v -v -x ...' and observing the output will give you a > good idea of what precisely it was doing for those hours. Well, as I said in my original email, it was hanging at running setfiles: commandrvf: stdout=n stderr=y flags=0x0 commandrvf: setfiles -F -e /sysroot/dev -e /sysroot/proc -e /sysroot/selinux -e /sysroot/sys -r /sysroot -q /sysroot/etc/selinux/targeted/contexts/files/file_contexts /sysroot/ Can't stat exclude path "/sysroot/selinux", No such file or directory - ignorin...

...xtern const char *sysroot; +extern size_t sysroot_len; + +#ifndef MAX +# define MAX(a,b) ((a)>(b)?(a):(b)) +#endif + +/* For improved readability dealing with pipe arrays */ +#define PIPE_READ 0 +#define PIPE_WRITE 1 + +/* Easy ways to run external commands. For full documentation, see + * 'commandrvf' below. + */ +int +commandf (char **stdoutput, char **stderror, unsigned flags, + const char *name, ...) +{ + va_list args; + /* NB: Mustn't free the strings which are on the stack. */ + CLEANUP_FREE const char **argv = NULL; + char *s; + size_t i; + int r; + + /* Collect th...

...making system calls. > If the backend is set to libvirt > It hangs inspecting the overlay ... > libguestfs: trace: v2v: mount_ro "/dev/sda1" "/" > guestfsd: main_loop: proc 395 (is_whole_device) took 0.09 seconds > guestfsd: main_loop: new request, len 0x40 > commandrvf: stdout=n stderr=y flags=0x0 > commandrvf: udevadm --debug settle -E /dev/sda1 > calling: settle > commandrvf: stdout=n stderr=y flags=0x0 > commandrvf: mount -o ro /dev/sda1 /sysroot/ It's pretty unlikely that there would be a difference here between direct & libvirt backends....

Use commandrvf() instead of commandvf() to execute e2fsck. A non-zero exit status does not always indicate a failure. Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- daemon/ext2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/daemon/ext2.c b/daemon/ext2.c index 65ddae6.....

...4096 extern int commandf (char **stdoutput, char **stderror, int flags, const char *name, ...) __attribute__((sentinel)); diff --git a/daemon/guestfsd.c b/daemon/guestfsd.c index 0a29aa6..47245f7 100644 --- a/daemon/guestfsd.c +++ b/daemon/guestfsd.c @@ -932,21 +932,44 @@ commandrvf (char **stdoutput, char **stderror, int flags, signal (SIGPIPE, SIG_DFL); close (0); if (flag_copy_stdin) { - dup2 (flag_copy_fd, STDIN_FILENO); + if (dup2 (flag_copy_fd, STDIN_FILENO) == -1) { + perror ("dup2/flag_copy_fd"); + _exit (EXIT_FAILURE);...

[This email is either empty or too large to be displayed at this time]

After this change the debugging output looks like this: guestfsd: enter: mount (0x1) request length 64 bytes commandrvf: stdout=n stderr=y flags=0x0 commandrvf: udevadm --debug settle -E /dev/sda1 calling: settle command: mount '/dev/sda1' '/sysroot//' [ 0.951731] EXT4-fs (sda1): mounting ext2 file system using the ext4 subsystem [ 0.954585] EXT4-fs (sda1): mounted filesystem without...

...oc/cmdline + eval + test x '!=' x + test 1 = 1 + cmd='guestfsd --verbose' + test '' = 1 + echo guestfsd --verbose guestfsd --verbose + guestfsd --verbose lvm config: lvmetad trying to open virtio-serial channel '/dev/virtio-ports/org.libguestfs.channel.0' commandrvf: stdout=n stderr=y flags=0x0 commandrvf: udevadm --debug settle calling: settle libguestfs: recv_from_daemon: received GUESTFS_LAUNCH_FLAG libguestfs: appliance is up libguestfs: trace: launch = 0 libguestfs: trace: part_disk "/dev/sda" "mbr" guestfsd: main_loop: new request,...

...0x1a) request length 40 bytes libguestfs: trace: aug_close = 0 libguestfs: trace: grep "vdagentd.\pid" "/etc/selinux/targeted/contexts/files/file_contexts" "fixed:true" guestfsd: => aug_close (0x1a) took 0.14 secs guestfsd: <= grep (0x97) request length 132 bytes commandrvf: stdout=y stderr=y flags=0x20004 commandrvf: grep -F vdagentd.\pid libguestfs: trace: grep = [] libguestfs: trace: selinux_relabel "/etc/selinux/targeted/contexts/files/file_contexts" "/" "force:true" guestfsd: => grep (0x97) took 0.12 secs guestfsd: <= selinux_r...

08.10.2017, 08:09, "Richard W.M. Jones" <rjones@redhat.com>: > However virt-v2v has its own parser for libvirt XML and only parses a > (very) small subset of these fields. Generally you only need to take > that template and change a few fields, name, memory size, number of > vCPUs, and make sure there is one <disk> section per disk and one > <interface>

.../ ; chroot / ; /bin/pwd" / ><fs> sh "/bin/pwd" (unreachable)/ ><fs> sh "cd / ; /bin/pwd" / This untested change may fix it. =================== --- libguestfs-1.20.10.orig/daemon/guestfsd.c +++ libguestfs-1.20.10/daemon/guestfsd.c @@ -879,7 +879,11 @@ commandrvf (char **stdoutput, char **std close (stdin_fd[PIPE_READ]); close (stdin_fd[PIPE_WRITE]); - if (chroot (sysroot) == -1) { + if (chdir (sysroot) == -1) { + perror ("chdir"); + _exit (EXIT_FAILURE); + } + if (chroot (".") == -1) {...

...test 1 = 1 + cmd='guestfsd --verbose' + test '' = 1 + false + test '' = 1 + echo guestfsd --verbose guestfsd --verbose + guestfsd --verbose lvm_system_dir = /tmp/lvm OCaml daemon loaded trying to open virtio-serial channel '/dev/virtio-ports/org.libguestfs.channel.0' commandrvf: stdout=n stderr=y flags=0x0 commandrvf: udevadm --debug settle calling: settle libguestfs: recv_from_daemon: received GUESTFS_LAUNCH_FLAG libguestfs: appliance is up Guest launched OK. guestfsd: <= part_disk (0xd2) request length 60 bytes commandrvf: stdout=n stderr=y flags=0x0 commandrvf: udev...