search for: coffsymbol

...> the '/test/MC/COFF' if the string references are emitted as temporaries. > > -Nathan > > The patch looks good, but please follow the LLVM coding conventions. > Also, clang emits warnings on all of the signed-unsigned comparisons, > and the order of initialization for COFFSymbol::MCData. > > The test fails, but that's only because it is looking for binary > equivalence, just llc the test and run coff-dump to re update it. I > ran the test-suite with clang -integrated-as with and without your > patch and I got identical results. > > So fix the codin...

...ay change the output of > the  '/test/MC/COFF' if the string references are emitted as temporaries. > -Nathan The patch looks good, but please follow the LLVM coding conventions. Also, clang emits warnings on all of the signed-unsigned comparisons, and the order of initialization for COFFSymbol::MCData. The test fails, but that's only because it is looking for binary equivalence, just llc the test and run coff-dump to re update it. I ran the test-suite with clang -integrated-as with and without your patch and I got identical results. So fix the coding conventions, warnings, and upda...

...if the string references are emitted as >> > temporaries. >> > -Nathan >> >> The patch looks good, but please follow the LLVM coding conventions. >> Also, clang emits warnings on all of the signed-unsigned comparisons, >> and the order of initialization for COFFSymbol::MCData. >> >> The test fails, but that's only because it is looking for binary >> equivalence, just llc the test and run coff-dump to re update it. I >> ran the test-suite with clang -integrated-as with and without your >> patch and I got identical results. >&g...

Hi guys, While trying to get dwarf debugging information to work with Win32 COFF targets, I came across a couple of issues with the current implementation of WinCOFFObjectWriter. Emitting empty section causes debug information to invalid, as the presence of certain debug section implies available information, and emission of labels as symbols confused gdb about the structure of the program. The

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. Attached is patch number 4. - Michael Spencer

Hi Michael, Looks great to me, with the caveat that I know nothing about COFF. A few comments: - The term symbol is already very overloaded, I would avoid adding a new 'class Symbol'. - I find it annoying to have more versions of write little endian 32-bit data, but I'm not sure what the right solution is. We can clean this up later, perhaps. - There are a couple of instances of: