Displaying 2 results from an estimated 2 matches for "coffobj".
2018 Jun 07
2
[lld] ObjFile::createRegular is oblivious of PendingComdat
...llowing
patch fixes the crash:
diff --git a/COFF/InputFiles.cpp b/COFF/InputFiles.cpp
index 9e2345b0a..f47d612df 100644
--- a/COFF/InputFiles.cpp
+++ b/COFF/InputFiles.cpp
@@ -229,11 +229,11 @@ Symbol *ObjFile::createRegular(COFFSymbolRef Sym) {
if (Sym.isExternal()) {
StringRef Name;
COFFObj->getSymbolName(Sym, Name);
- if (SC)
+ if (SC && SC != PendingComdat)
return Symtab->addRegular(this, Name, Sym.getGeneric(), SC);
return Symtab->addUndefined(Name, this, false);
}
- if (SC)
+ if (SC && SC != PendingComdat)
return make<Defined...
2018 Jun 07
2
[lld] ObjFile::createRegular is oblivious of PendingComdat
...p b/COFF/InputFiles.cpp
>> index 9e2345b0a..f47d612df 100644
>> --- a/COFF/InputFiles.cpp
>> +++ b/COFF/InputFiles.cpp
>> @@ -229,11 +229,11 @@ Symbol *ObjFile::createRegular(COFFSymbolRef Sym) {
>> if (Sym.isExternal()) {
>> StringRef Name;
>> COFFObj->getSymbolName(Sym, Name);
>> - if (SC)
>> + if (SC && SC != PendingComdat)
>> return Symtab->addRegular(this, Name, Sym.getGeneric(), SC);
>> return Symtab->addUndefined(Name, this, false);
>> }
>> - if (SC)
>> + if...