search for: codeview_linet

...e; but the prototype development went faster // than I expected... Can you suggest ways to split this patch so it's easier to review part-by-part before this hits trunk? Thanks! -- Timur Iskhodzhanov, Google -------------- next part -------------- A non-text attachment was scrubbed... Name: codeview_linetables.patch Type: application/octet-stream Size: 36333 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131114/0eea4311/attachment.obj>

...______ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> > > > > -- > João Matos -------------- next part -------------- A non-text attachment was scrubbed... Name: codeview_linetables.patch Type: application/octet-stream Size: 87060 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131118/671abbc1/attachment.obj>

...or things improved. I also removed the "TODO: test on X64" as I did try it on x64 and no changes were required. Looking forward to your feedback! > Thanks! > -- > Timur Iskhodzhanov, > Google -------------- next part -------------- A non-text attachment was scrubbed... Name: codeview_linetables.patch Type: application/octet-stream Size: 43569 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131115/31b4cee0/attachment.obj>

Hi Timur, There's also a pending patch adding CodeView support in Phab: http://llvm-reviews.chandlerc.com/D165 Does your patch provide just a subset of the CodeView debug info provided in the other patch? Looking at the patch, I think the approach the other patch took of abstracting the emission of debug information is a bit cleaner and it will probably make life easier when adding more

In general I do think we're going to need to abstract it out as much as possible. I'm not sure what the previous patch looks like, but abstracting the interface out would be general goodness for this. We can talk about designs for that as we move on. As far as how to migrate the decision down we can have it both as an option to code gen maybe or, for now, make it dependent upon triple. The

...______ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> > > > > -- > Jo?o Matos -------------- next part -------------- A non-text attachment was scrubbed... Name: codeview_linetables.patch Type: application/octet-stream Size: 87059 bytes Desc: not available URL: <http://lists.cs.uiuc.edu/pipermail/llvmdev/attachments/20131118/671abbc1/attachment.obj> ------------------------------ _______________________________________________ LLVMdev mailing list LLVMdev at cs.ui...

...VMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>>> >>> >>> >>> >>> -- >>> João Matos -------------- next part -------------- A non-text attachment was scrubbed... Name: codeview_linetables.patch Type: application/octet-stream Size: 60019 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131119/a0543600/attachment.obj>