search for: codestyle

On Fri, Sep 12, 2014 at 12:44:56PM +0200, Gerd Hoffmann wrote: > Hi, > > > > @@ -0,0 +1,158 @@ > > > +#ifndef VIRTGPU_HW_H > > > +#define VIRTGPU_HW_H > > > > Non-trivial file, deserves a copyright and license notice. > > Added. Pls remember to make it consistent with other virtio headers, which are 3-clause BSD, prefixed with this reminder:

On Fri, Sep 12, 2014 at 12:44:56PM +0200, Gerd Hoffmann wrote: > Hi, > > > > @@ -0,0 +1,158 @@ > > > +#ifndef VIRTGPU_HW_H > > > +#define VIRTGPU_HW_H > > > > Non-trivial file, deserves a copyright and license notice. > > Added. Pls remember to make it consistent with other virtio headers, which are 3-clause BSD, prefixed with this reminder:

On Tue, Jun 23, 2020 at 10:31:28AM +0900, David Stevens wrote: > Unless there are any remaining objections to these patches, what are > the next steps towards getting these merged? Sorry, I'm not familiar > with the workflow for contributing patches to Linux. Sorry, just have been busy and not paying as much attention to drm patches as usual. Playing catch-up now. Queued for

...> > > + VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100, > > > > > > Please consider also adding: > > VIRTIO_GPU_ everywhere to make it consistent with other > virtio headers? The names are already pretty long as-is, especially considering the 80cols rule in our codestyle. I'd prefer to keep them the way they are now. cheers, Gerd

Here''s one I learned: I originally had # Ensure /etc/hosts contains the basics host { "${fqdn}": host_aliases => $hostname, ip => $ipaddress, } And thru some trial and error, got down to this (which puppet-lint does not gripe about) # Ensure /etc/hosts contains the basics host { $fqdn: host_aliases => $hostname, ip => $ipaddress, }