search for: codegenexternaltest

....cpp 1.69 0.55 -67.3% lib/AST/StmtViz.cpp 1.02 0.44 -57.4% tools/driver/cc1_main.cpp 2.26 0.97 -57.1% unittests/CodeGen/BufferSourceTest.cpp 3.08 1.83 -40.6% lib/CodeGen/CGLoopInfo.cpp 1.91 1.34 -29.9% unittests/Tooling/RefactoringActionRulesTest.cpp 2.46 1.79 -27.0% unittests/CodeGen/CodeGenExternalTest.cpp 3.43 2.52 -26.5% tools/libclang/CXStoredDiagnostic.cpp 1.67 1.26 -24.8% tools/clang-func-mapping/ClangFnMapGen.cpp 2.48 1.89 -23.8% Full list: The corresponding patches (careful, they are big): Methodology My tool took the compile_commands.json from LLVM build and iterated over files...

...67.3% > lib/AST/StmtViz.cpp 1.02 0.44 -57.4% > tools/driver/cc1_main.cpp 2.26 0.97 -57.1% > unittests/CodeGen/BufferSourceTest.cpp 3.08 1.83 -40.6% > lib/CodeGen/CGLoopInfo.cpp 1.91 1.34 -29.9% > unittests/Tooling/RefactoringActionRulesTest.cpp 2.46 1.79 -27.0% > unittests/CodeGen/CodeGenExternalTest.cpp 3.43 2.52 -26.5% > tools/libclang/CXStoredDiagnostic.cpp 1.67 1.26 -24.8% > tools/clang-func-mapping/ClangFnMapGen.cpp 2.48 1.89 -23.8% > > Full list: > <clang.txt> > > The corresponding patches (careful, they are big): > <llvm_redundant_headers.patch> > &...

...67.3% > lib/AST/StmtViz.cpp 1.02 0.44 -57.4% > tools/driver/cc1_main.cpp 2.26 0.97 -57.1% > unittests/CodeGen/BufferSourceTest.cpp 3.08 1.83 -40.6% > lib/CodeGen/CGLoopInfo.cpp 1.91 1.34 -29.9% > unittests/Tooling/RefactoringActionRulesTest.cpp 2.46 1.79 -27.0% > unittests/CodeGen/CodeGenExternalTest.cpp 3.43 2.52 -26.5% > tools/libclang/CXStoredDiagnostic.cpp 1.67 1.26 -24.8% > tools/clang-func-mapping/ClangFnMapGen.cpp 2.48 1.89 -23.8% > > Full list: > > <clang.txt> > > > The corresponding patches (careful, they are big): > > <llvm_redundant_headers.p...

...% 87.1 34.4 -60.5% lib/AST/StmtViz.cpp 1.28 0.48 -62.5% 62.4 39.0 -37.5% tools/driver/cc1_main.cpp 3.05 1.29 -57.8% 93.7 58.6 -37.4% unittests/CodeGen/BufferSourceTest.cpp 4.12 2.62 -36.5% 145.8 103.9 -28.7% lib/CodeGen/CGLoopInfo.cpp 2.43 1.68 -30.7% 101.6 82.5 -18.8% unittests/CodeGen/CodeGenExternalTest.cpp 4.50 3.21 -28.6% 155.5 125.1 -19.5% lib/Driver/ToolChains/Contiki.cpp 0.53 0.38 -28.1% 42.4 38.0 -10.5% unittests/Tooling/RefactoringActionRulesTest.cpp 3.22 2.34 -27.5% 108.3 90.0 -16.9% lib/Serialization/GeneratePCH.cpp 2.38 1.78 -25.1% 83.8 71.1 -15.1% Full list: The updated patches...

...60.5% > lib/AST/StmtViz.cpp 1.28 0.48 -62.5% 62.4 39.0 -37.5% > tools/driver/cc1_main.cpp 3.05 1.29 -57.8% 93.7 58.6 -37.4% > unittests/CodeGen/BufferSourceTest.cpp 4.12 2.62 -36.5% 145.8 103.9 -28.7% > lib/CodeGen/CGLoopInfo.cpp 2.43 1.68 -30.7% 101.6 82.5 -18.8% > unittests/CodeGen/CodeGenExternalTest.cpp 4.50 3.21 -28.6% 155.5 125.1 > -19.5% > lib/Driver/ToolChains/Contiki.cpp 0.53 0.38 -28.1% 42.4 38.0 -10.5% > unittests/Tooling/RefactoringActionRulesTest.cpp 3.22 2.34 -27.5% 108.3 > 90.0 -16.9% > lib/Serialization/GeneratePCH.cpp 2.38 1.78 -25.1% 83.8 71.1 -15.1% > > Full...

...tmtViz.cpp 1.02 0.44 -57.4% >> tools/driver/cc1_main.cpp 2.26 0.97 -57.1% >> unittests/CodeGen/BufferSourceTest.cpp 3.08 1.83 -40.6% >> lib/CodeGen/CGLoopInfo.cpp 1.91 1.34 -29.9% >> unittests/Tooling/RefactoringActionRulesTest.cpp 2.46 1.79 -27.0% >> unittests/CodeGen/CodeGenExternalTest.cpp 3.43 2.52 -26.5% >> tools/libclang/CXStoredDiagnostic.cpp 1.67 1.26 -24.8% >> tools/clang-func-mapping/ClangFnMapGen.cpp 2.48 1.89 -23.8% >> >> Full list: >> >> <clang.txt> >> >> >> The corresponding patches (careful, they are big): &g...

...1.02 0.44 -57.4% >> tools/driver/cc1_main.cpp 2.26 0.97 -57.1% >> unittests/CodeGen/BufferSourceTest.cpp 3.08 1.83 -40.6% >> lib/CodeGen/CGLoopInfo.cpp 1.91 1.34 -29.9% >> unittests/Tooling/RefactoringActionRulesTest.cpp 2.46 1.79 -27.0% >> unittests/CodeGen/CodeGenExternalTest.cpp 3.43 2.52 -26.5% >> tools/libclang/CXStoredDiagnostic.cpp 1.67 1.26 -24.8% >> tools/clang-func-mapping/ClangFnMapGen.cpp 2.48 1.89 -23.8% >> >> Full list: >> <clang.txt> >> >> The corresponding patches (careful, they are big): >> <l...

- We do indeed have a lot of unnecessary includes around in llvm (or pretty much any other C++ project for that matter). - I want faster builds. - The only way to reliably fight this is indeed automatic tools. - Having the right amount of includes also has documentation value and ideally let's you understand the structure of your project. - However relying on transitive includes works contrary