Displaying 2 results from an estimated 2 matches for "cmpops".
Did you mean:
cmos
2014 Mar 13
2
[LLVMdev] MergeFunctions: reduce complexity to O(log(N))
...ffset(*DL, Offset1) &&
> + GEP2->accumulateConstantOffset(*DL, Offset2)))
> + return cmpAPInt(Offset1, Offset2);
>
> I think you should put this under if (DL) { /* declare Offset1, Offset2,
> etc. */ }
>
> 0008:
>
> + // TODO: Already checked in cmpOps
>
> Did you mean "cmpOperation"?
>
> - if (!enumerate(F1BB, F2BB) || !compare(F1BB, F2BB))
> + if (!enumerate(F1BB, F2BB) || compare(F1BB, F2BB) != 0)
>
> "compare" still returns "bool". I'm going to assume this was meant to go
> in 00...
2014 Feb 27
3
[LLVMdev] MergeFunctions: reduce complexity to O(log(N))
Hi Nick,
I tried to rework changes as you requested. One of patches (0004 with
extra assertions) has been removed.
> + bool isEquivalentType(Type *Ty1, Type *Ty2) const {
> + return cmpType(Ty1, Ty2) == 0;
> + }
>
> Why do we still need isEquivalentType? Can we nuke this?
Yup. After applying all the patches isEquivalentType will be totally
replaced with cmpType. All