search for: cmp_time

https://bugzilla.samba.org/show_bug.cgi?id=10643 Summary: cmp_time() returns incorrect result due to integer overflow Product: rsync Version: 3.1.1 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: core AssignedTo: wayned at...

On a PPC machine running Mac OS X, I noticed that creation time is not preserved for files that are transferred (i.e. versus files that are not transferred, or files that have only attribute changes). I discovered two things that work together to cause this: 1) cmp_time (util.c) doesn't check for negative values provided in file1 or file2. If file2 is positive, and file1 is negative, and absolute_value(file1) > file2, cmp_time returns 0, even though the times are obviously different. Of course, a file's crtime should never be negative, which l...

I wrote on Fri, 02 Jan 2015 16:02:27 +0100: > --- a/generator.c 2014-06-14 01:05:08.000000000 +0200 > +++ b/generator.c 2015-01-02 15:50:30.000000000 +0100 > @@ -588,7 +588,14 @@ > if (ignore_times) > return 0; > - return cmp_time(st->st_mtime, file->modtime) == 0; > + return cmp_time(st->st_mtime, file->modtime) == 0 > +#ifdef ST_MTIME_NSEC > + ? st->st_mtime == file->modtime > + && NSEC_BUMP(file) ? (uint32)st->ST_MTIME_NSEC == > F_MOD_NSEC(file)...

...extern int always_checksum; extern char *compare_dest; extern int link_dest; +extern int preserve_times; /* choose whether to skip a particular file */ @@ -90,7 +91,11 @@ return 0; } - return (cmp_modtime(st->st_mtime,file->modtime) == 0); + if (preserve_times && cmp_time(st->st_atime,file->atime) != 0) { + return 0; + } + + return (cmp_time(st->st_mtime,file->modtime) == 0); } @@ -466,7 +471,7 @@ return; } - if (update_only && cmp_modtime(st.st_mtime,file->modtime)>0 && fnamecmp == fname) { + if (u...

...Assignee: wayned at samba.org Reporter: bugzilla.samba.org-prf at jf-luce.name QA Contact: rsync-qa at samba.org rsync won't compile anymore after applying these 2 patches. Error: too few arguments to function call, expected 4, have 2 File : rsync.c Line : 614 : for if (cmp_time(sxp->crtime, file_crtime) != 0 -- You are receiving this mail because: You are the QA Contact for the bug.

...50,7 @@ extern int only_existing; extern int orig_umask; extern int safe_symlinks; +extern int copy_atimes; /* choose whether to skip a particular file */ @@ -97,7 +98,11 @@ return 0; } - return (cmp_modtime(st->st_mtime,file->modtime) == 0); + if (copy_atimes && cmp_time(st->st_atime,file->atime) != 0) { + return 0; + } + + return (cmp_time(st->st_mtime,file->modtime) == 0); } @@ -464,7 +469,7 @@ return; } - if (update_only && cmp_modtime(st.st_mtime,file->modtime)>0 && fnamecmp == fname) { + if (u...

On systems using nanoseconds differences should be taken into consideration. --- a/generator.c 2014-06-14 01:05:08.000000000 +0200 +++ b/generator.c 2014-12-25 11:19:54.000000000 +0100 @@ -588,7 +588,13 @@ if (ignore_times) return 0; - return cmp_time(st->st_mtime, file->modtime) == 0; + return cmp_time(st->st_mtime, file->modtime) == 0 +#ifdef ST_MTIME_NSEC + ? NSEC_BUMP(file) ? (uint32)st->ST_MTIME_NSEC == F_MOD_NSEC(file) + : 1 + : 0 +#endif + ; }

...ther or making it more robust. diff --git a/generator.c b/generator.c index 3a4504f..2f64f5d 100644 --- a/generator.c +++ b/generator.c @@ -588,7 +588,11 @@ int unchanged_file(char *fn, struct file_struct *file, STRUCT_STAT *st) if (ignore_times) return 0; - return cmp_time(st->st_mtime, file->modtime) == 0; + return cmp_time(st->st_mtime, file->modtime) == 0 +#ifdef ST_MTIME_NSEC + && st->ST_MTIME_NSEC == F_MOD_NSEC(file) +#endif + ; } -- You are receiving this mail because: You are the QA Contact for the bu...

When rsync'ing to an Ext2 file system (via SSH), then I frequently get error messages such as "failed to set times ...". AFAICS, these error messages are caused by rsync trying to change the time (and permissions, ownership) of symbolic links, which according to my knowledge is not possible on Ext2. Is there any way to get rid of these supposedly superfluous error messages? rsync

'rsync -a' updates the ctime on a directory even if no file in that directory has changed. A kind of workaround is to use '-O', but then the mtimes of directories are not preserved. (Usage example where this is important: maintain a copy of filesystem A in filesystem B, and use filesystem B as the source for incremental backups (e.g., with star). rsync is run before an

https://bugzilla.samba.org/show_bug.cgi?id=6672 Summary: mtim.tv_nsec not used when reading time of a file Product: rsync Version: 3.0.6 Platform: Other OS/Version: All Status: NEW Severity: major Priority: P3 Component: core AssignedTo: wayned at samba.org ReportedBy: antonio at

...ync.c rsync-3.0.7/rsync.c --- rsync-3.0.7_orig/rsync.c 2010-09-16 10:49:54.000000000 -0500 +++ rsync-3.0.7/rsync.c 2010-09-16 10:50:43.000000000 -0500 @@ -480,6 +480,7 @@ if (sxp->crtime == 0) sxp->crtime = get_create_time(fname); if (cmp_time(sxp->crtime, file_crtime) != 0 + && sxp->st.st_ino != 2 // Don't set the creation date on the root folder of an HFS+ volume && set_create_time(fname, file_crtime) == 0) updated = 1; } ############## -- Conf...

...ghtly more aggressive approach, and tries to compare the nanosecond part of the timestamp as well. However, since --modify-window parameter is still supported, in my understanding this happens only if the file was originally nominated for a transfer, so that the selection is still controlled by cmp_time() from util.c ; in other words, if the destination has the same value of .st_mtime field as the source, and the same contents etc -- no data transfer would be attempted. One could possibly recompile rsync, telling it to ignore all nanosecond values whatsoever, but this is not exactly what we w...

...s(fname, fileflags); +} +#endif + int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, const char *fnamecmp, int flags) { @@ -391,6 +437,9 @@ int set_file_attrs(const char *fname, st flags |= ATTRS_SKIP_MTIME; if (!(flags & ATTRS_SKIP_MTIME) && cmp_time(sxp->st.st_mtime, file->modtime) != 0) { +#ifdef SUPPORT_FLAGS + make_mutable(fname, sxp->st.st_mode, sxp->st.st_flags); +#endif int ret = set_modtime(fname, file->modtime, sxp->st.st_mode); if (ret < 0) { rsyserr(FERROR_XFER, errno, "failed to set times on %s&q...