search for: cmd_flag_fast_zero

...# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, +# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT +# OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF +# SUCH DAMAGE. + +source ./functions.sh +set -e +set -x + +requires nbdsh -c 'i = nbd.CMD_FLAG_FAST_ZERO +exit(not h.supports_uri())' + +files="retry-zero-flags-count retry-zero-flags-open-count" +rm -f $files +cleanup_fn rm -f $files + +touch retry-zero-flags-count retry-zero-flags-open-count +start_t=$SECONDS + +# Create a custom plugin which will test retrying. +nbdkit -v -U - \ +...

I'm still working on another set of patches to have reopen call .finalize/.prepare (so that another filter can safely appear between retry and the plugin), but for tonight, these are the patches I think are ready to go. Eric Blake (4): retry: Handle can_fua and can_fast_zero changes tests: Test retry with different fua/fast-zero flags server: Close backends if a filter's .open fails

...ot;zero_expect_may_trim": True}) +h.zero (512, 0, 0) # absence of nbd.CMD_FLAG_NO_HOLE + +h = test ({"size": 512, + "can_zero": True, "can_fast_zero": True, + "zero_expect_fast_zero": True}) +h.zero (512, 0, nbd.CMD_FLAG_NO_HOLE | nbd.CMD_FLAG_FAST_ZERO) + +# Test cache. +h = test ({"size": 512, "can_cache": "native"}) +h.cache (512, 0) diff --git a/tests/test.py b/tests/test.py deleted file mode 100644 index ac80d96..0000000 --- a/tests/test.py +++ /dev/null @@ -1,60 +0,0 @@ -import nbdkit - -disk = bytearray(1024*10...

...True}) > +h.zero (512, 0, 0) # absence of nbd.CMD_FLAG_NO_HOLE > + > +h = test ({"size": 512, > + "can_zero": True, "can_fast_zero": True, > + "zero_expect_fast_zero": True}) > +h.zero (512, 0, nbd.CMD_FLAG_NO_HOLE | nbd.CMD_FLAG_FAST_ZERO) > + > +# Test cache. > +h = test ({"size": 512, "can_cache": "native"}) > +h.cache (512, 0) > diff --git a/tests/test.py b/tests/test.py > deleted file mode 100644 > index ac80d96..0000000 > --- a/tests/test.py > +++ /dev/null > @@ -1,60...

v1: https://www.redhat.com/archives/libguestfs/2019-November/msg00153.html v2: - Fix implementation of can_cache. - Add implementation of can_fua. - Add a very thorough test suite which tests every command + flag combination.

v3 was here: https://www.redhat.com/archives/libguestfs/2019-November/msg00209.html In v4: - Rebase on top of current master. Includes various fixes and updates required because of Nir's patches that went into master. - Fix api_version() -> API_VERSION in patch 2 noted previously on the mailing list. Rich.

v2 was here: https://www.redhat.com/archives/libguestfs/2019-November/msg00163.html I pushed patch 1 (with spelling fix), patch 4 and patch 5 since those were previously ACKed on the list. Differences in v3: - Add error checking to PyModule_AddIntConstant. - Use API_VERSION constant instead of function. - Add max API version supported to --dump-plugin output. - Print API_VERSION selected by

This is a cover letter to a series of patches being proposed in tandem to four different projects: - nbd: Document a new NBD_CMD_FLAG_FAST_ZERO command flag - qemu: Implement the flag for both clients and server - libnbd: Implement the flag for clients - nbdkit: Implement the flag for servers, including the nbd passthrough client If you want to test the patches together, I've pushed a 'fast-zero' branch to each of: https://rep...