search for: cmd_buf

...tus: NEW Severity: normal Priority: P5 Component: core Assignee: wayned at samba.org Reporter: brant at gurganus.name QA Contact: rsync-qa at samba.org The rsync_panic_handler currently defined at line 1490 of main.c writes into a fixed size cmd_buf at line 1492 a non-controlled value returned ultimately in get_panic_action() using snprintf at line 1495. The combined values destined for cmd_buf by way of snprintf may be greater than the 300 character buffer. This is not checked. Consequently, a command may attempt to execute that was not inten...

...t;initrd = strdup(t); continue; @@ -866,7 +872,13 @@ void boot_entry(menu_t *menu_ptr, char * if(menu_ptr->localboot) { gfx_done(); syslinux_local_boot(strtol(menu_ptr->localboot, NULL, 0)); + return; + } + if(menu_ptr->com32) { + gfx_done(); + asprintf(&cmd_buf, "%s %s", menu_ptr->com32, arg); + syslinux_run_command(cmd_buf); return; }

Ok, here is the first try to turn the gfxboot wrapper into a com32 module. I had to extend the interface to the gfxboot core a bit to get it working. So it works only with latest gfxboot from git://gitorious.org/gfxboot/gfxboot.git Steffen -------------- next part -------------- A non-text attachment was scrubbed... Name: gfxboot_c32.diff.gz Type: application/x-gzip Size: 7220 bytes Desc: URL:

When attempting to build syslinux in parallel (make -j5), I encountered the following error at the end: rm -f liblpxelinux.a ar cq liblpxelinux.a rawcon.o ./fs/pxe/dhcp_option.o ./fs/pxe/pxe.o ./fs/pxe/tftp.o ./fs/pxe/urlparse.o ./lwip/src/netif/ethernetif.o ./lwip/src/netif/etharp.o ./lwip/src/netif/slipif.o ./lwip/src/netif/ppp/md5.o ./lwip/src/netif/ppp/randm.o ./lwip/src/netif/ppp/chpms.o

...e_sess->sess_cmd_map)[tag]; memset(req, 0, sizeof(*req)); req->se_cmd.map_tag = tag; + req->se_cmd.map_cpu = cpu; req->se_cmd.tag = next_orb; return req; @@ -1460,7 +1461,8 @@ static void sbp_free_request(struct sbp_target_request *req) kfree(req->pg_tbl); kfree(req->cmd_buf); - percpu_ida_free(&se_sess->sess_tag_pool, se_cmd->map_tag); + sbitmap_queue_clear(&se_sess->sess_tag_pool, se_cmd->map_tag, + se_cmd->map_cpu); } static void sbp_mgt_agent_process(struct work_struct *work) diff --git a/drivers/target/target_core_transport.c b/drive...

Removing the percpu_ida code nets over 400 lines of removal. It's not as spectacular as deleting an entire architecture, but it's still a worthy reduction in lines of code. Untested due to lack of hardware and not understanding how to set up a target platform. Changes from v1: - Fixed bugs pointed out by Jens in iscsit_wait_for_tag() - Abstracted out tag freeing as requested by Bart

Removing the percpu_ida code nets over 400 lines of removal. It's not as spectacular as deleting an entire architecture, but it's still a worthy reduction in lines of code. Untested due to lack of hardware and not understanding how to set up a target platform. Changes from v1: - Fixed bugs pointed out by Jens in iscsit_wait_for_tag() - Abstracted out tag freeing as requested by Bart

From: Matthew Wilcox <mawilcox at microsoft.com> This is a pretty rough-and-ready conversion of the target drivers from using percpu_ida to sbitmap. It compiles; I don't have a target setup, so it's completely untested. I haven't tried to do anything particularly clever here, so it's possible that, for example, the wait queue in iscsi_target_util could be more clever, like