search for: cmake_version

...without being on CMake 3.4 or newer. These limitations make using ExternalProject to build the LLVM test-suite and runtime libraries (compiler-rt, libcxx, etc) difficult. > > The other big motivation that I have for this is the ability to cleanup code. We have a lot of CMake code that checks CMAKE_VERSION and enables and disables features used on the version. None of the places where we currently have CMAKE_VERSION checks should impact build correctness, but most people don’t realize that if you’re using Ninja your build will be faster on a newer CMake than on an older one. It would be nice if we ju...

...ould be a lot of work... > One approach commonly used with CMake modules that change frequently upstream is for the project to keep a local copy and have a check in place to use CMake's version if new enough. For instance, in llvm's source tree: cmake/modules/ExternalProject.cmake: if(CMAKE_VERSION VERSION_LESS "3.5.1") include(${PROJECT_SOURCE_DIR}/cmake/modules/newcmake/ExternalProject.cmake) else() include(${CMAKE_ROOT}/Modules/ExternalProject.cmake) endif() cmake/modules/newcmake/ExternalProject.cmake - Copy of the ExternalProject.cmake shipped with 3.5.1 Then in the top le...

...OR DEFINED ARG_LINK_COMPONENTS) + if (LLVM_LINK_LLVM_DYLIB AND NOT ARG_DISABLE_LLVM_LINK_LLVM_DYLIB) + set(llvm_libs LLVM) + else() + llvm_map_components_to_libnames(llvm_libs + ${ARG_LINK_COMPONENTS} + ${LLVM_LINK_COMPONENTS} + ) + endif() endif() if(CMAKE_VERSION VERSION_LESS 2.8.12) Index: cmake/modules/LLVM-Config.cmake =================================================================== --- cmake/modules/LLVM-Config.cmake (revision 259743) +++ cmake/modules/LLVM-Config.cmake (working copy) @@ -40,10 +40,17 @@ # done in case libLLVM does not c...

...> newer. These limitations make using ExternalProject to build the LLVM >> test-suite and runtime libraries (compiler-rt, libcxx, etc) difficult. >> >> The other big motivation that I have for this is the ability to cleanup >> code. We have a lot of CMake code that checks CMAKE_VERSION and enables and >> disables features used on the version. None of the places where we >> currently have CMAKE_VERSION checks should impact build correctness, but >> most people don’t realize that if you’re using Ninja your build will be >> faster on a newer CMake than on an...

...OR DEFINED ARG_LINK_COMPONENTS) + if (LLVM_LINK_LLVM_DYLIB AND NOT ARG_DISABLE_LLVM_LINK_LLVM_DYLIB) + set(llvm_libs LLVM) + else() + llvm_map_components_to_libnames(llvm_libs + ${ARG_LINK_COMPONENTS} + ${LLVM_LINK_COMPONENTS} + ) + endif() + endif() + if(CMAKE_VERSION VERSION_LESS 2.8.12) # Link libs w/o keywords, assuming PUBLIC. target_link_libraries(${name} @@ -885,11 +891,18 @@ add_llvm_executable(${test_name} IGNORE_EXTERNALIZE_DEBUGINFO ${ARGN}) set(outdir ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}) set_output_directory(${test_name}...

...build system to better facilitate LLVM development and provide a usable, extensible, and stable build system for LLVM and all sub-projects. ### Updating CMake More Regularly In the past we have clung to old versions of CMake for extended periods of time. This has resulted in significant checking `CMAKE_VERSION` to enable some features or being completely unable to use others. In particular recent CMake development extending generator expressions could provide substantial benefit to the project. If we stick to current upgrade policies, we may not be able to use the current CMake release for another few ye...

...o better facilitate LLVM development and provide a usable, extensible, and stable build system for LLVM and all sub-projects. > > ### Updating CMake More Regularly > In the past we have clung to old versions of CMake for extended periods of time. This has resulted in significant checking `CMAKE_VERSION` to enable some features or being completely unable to use others. In particular recent CMake development extending generator expressions could provide substantial benefit to the project. If we stick to current upgrade policies, we may not be able to use the current CMake release for another few ye...

...ilitate LLVM development and provide a usable, extensible, and stable build system for LLVM and all sub-projects. >> >> ### Updating CMake More Regularly >> In the past we have clung to old versions of CMake for extended periods of time. This has resulted in significant checking `CMAKE_VERSION` to enable some features or being completely unable to use others. In particular recent CMake development extending generator expressions could provide substantial benefit to the project. If we stick to current upgrade policies, we may not be able to use the current CMake release for another few ye...

...ble, > and stable build system for LLVM and all > sub-projects. > > ### Updating CMake More Regularly > In the past we have clung to old versions of > CMake for extended periods of time. This has > resulted in significant checking > `CMAKE_VERSION` to enable some features or > being completely unable to use others. In > particular recent CMake development extending > generator expressions could provide > substantial benefit to the project. If we > stick to current upgrade policies, we may not >...

Most of the comments I have are actually very well captured by Chandler's email, so I'm not going to pile on. I do have a few things to add. Renato, in your most recent email you comment about differentiating *stable* vs random versions of CMake built from source. I believe as a community our recommendation should be that people download CMake sources from https://CMake.org/download/