Displaying 3 results from an estimated 3 matches for "cmake_import_library_suffix".
2014 Feb 10
2
[LLVMdev] [llvm] r201072 - [CMake] Introduce llvm_add_library().
...bit.
if(ARG_MODULE)
set_property(TARGET ${name} PROPERTY SUFFIX ${LLVM_PLUGIN_EXT})
endif()
if(ARG_SHARED)
if (MSVC)
set_target_properties(${name}
PROPERTIES
IMPORT_SUFFIX ".imp")
endif ()
endif()
CMake provides CMAKE_SHARED_MODULE_SUFFIX and CMAKE_IMPORT_LIBRARY_SUFFIX.
Can you set those at directory scope instead of setting the target property
in the macro?
Anyway, just a note to consider moving instead in a direction of fewer
wrappers, rather than more. I'm not familiar enough with the llvm
buildsystem to know why you're doing some of the things y...
2014 Feb 13
2
[LLVMdev] [llvm] r201072 - [CMake] Introduce llvm_add_library().
...endif()
>>
>> if(ARG_SHARED)
>> if (MSVC)
>> set_target_properties(${name}
>> PROPERTIES
>> IMPORT_SUFFIX ".imp")
>> endif ()
>> endif()
>>
>>
>> CMake provides CMAKE_SHARED_MODULE_SUFFIX and CMAKE_IMPORT_LIBRARY_SUFFIX.
>> Can you set those at directory scope instead of setting the target property
>> in the macro?
>
> Reasonable. They could be put into common configurator, HandleLLVMOptions.
> For now in r201072, I simply gather common logics around there.
> I'd be happy if llvm_add_l...
2014 Feb 13
2
[LLVMdev] [llvm] r201072 - [CMake] Introduce llvm_add_library().
...>> endif()
>>
>> if(ARG_SHARED)
>> if (MSVC)
>> set_target_properties(${name}
>> PROPERTIES
>> IMPORT_SUFFIX ".imp")
>> endif ()
>> endif()
>>
>>
>> CMake provides CMAKE_SHARED_MODULE_SUFFIX and CMAKE_IMPORT_LIBRARY_SUFFIX.
>> Can you set those at directory scope instead of setting the target property
>> in the macro?
>>
>>
>> Reasonable. They could be put into common configurator, HandleLLVMOptions.
>> For now in r201072, I simply gather common logics around there.
>> I...