search for: cleanup_socket

...it() has a different parameter list than atexit(), as shown below: int atexit(void (*function)(void)); int on_exit(void (*function)(int , void *), void *arg); Since the differing parameter is for arguments I thought it might be safe to just set it to NULL, as shown below: /* if (atexit(cleanup_socket) < 0) { */ /* Original, causes gcc to barf */ if (on_exit(cleanup_socket, NULL) < 0) { /* Revised, now finger-lickin' good */ This seems to do the trick, allowing me to compile. Furthermore, I've been running the daemon for a little while now and I don't *seem* to hav...

...On macOS 13.3, I got the following 100% CPU spin in `ssh-agent`'s `cleanup_handler()`: ``` 8438 _sigtramp (in libsystem_platform.dylib) + 29 [0x7ff819a3e5ed] 8438 cleanup_handler (in ssh-agent) + 9 [0x10d0c5429] 8438 cleanup_socket (in ssh-agent) + 81 [0x10d0c3d11] 8438 sshlog (in ssh-agent) + 116 [0x10d0f3504] 8438 sshlogv (in ssh-agent) + 127 [0x10d0f35af] 8438 snprintf (in libsystem_c.dylib) + 156 [0x7ff8198c60d4]...

Hi, I noticed that Markus has fixed the temporary file cleanup problems in OpenSSH cvs. What files need patching for this ? I only noticed changes in: session.c, channels.h and channels.c. -Jarno -- Jarno Huuskonen <Jarno.Huuskonen at uku.fi>

...achment.cgi?id=2432&action=edit proposed fix ssh-agent sometimes forks child processes. For example, ask_permission() may fork a child process to execute an askpass program. If it fails to execute, the child process exits using fatal(), which in turn calls cleanup_exit(), and the latter calls cleanup_socket(). As result, an error in child process causes unintended UNIX-domain socket removal. The fix is to record pid of the process that is responsible for socket cleanup, and skip this cleanup for other processes. -- You are receiving this mail because: You are watching the assignee of the bug.

.... However, after upgrading to OpenSSH 7.6p1, I saw very different behavior. In this case, the following debugging output was seen: debug2: fd 3 setting O_NONBLOCK debug3: fd 4 is O_NONBLOCK debug1: process_message: socket 1 (fd=4) type 13 process_sign_request2: buffer error: invalid format debug1: cleanup_socket: cleanup The ssh-agent actually exited in this case, as the ?buffer error? here was a fatal() condition. The message sent to the agent was well-formed, though. It was only the key blob that was not recognizable. Looking more closely at the code, the 7.5p1 code looked like: if ((r = sshbuf...

...t_name[PATH_MAX]; char socket_dir[PATH_MAX]; +#ifdef WITH_SYSTEMD +/* tracks whether the active AUTH_SOCKET was passed to us by a third party */ +int external_socket = 0; +#endif + /* Pattern-list of allowed PKCS#11/Security key paths */ static char *allowed_providers; @@ -1946,6 +1954,10 @@ cleanup_socket(void) { if (cleanup_pid != 0 && getpid() != cleanup_pid) return; +#ifdef WITH_SYSTEMD + if (external_socket) + return; +#endif debug_f("cleanup"); if (socket_name[0]) unlink(socket_name); @@ -2000,7 +2012,7 @@ int main(int ac, char **av) { int c_flag = 0, d_flag...

http://bugzilla.mindrot.org/show_bug.cgi?id=500 ------- Additional Comments From djm at mindrot.org 2003-02-24 12:43 ------- I think that: [ -z "$SSH_AUTH_SOCK" ] && eval `ssh-agent -s` [ -z "$SSH_AGENT_PID" ] || ssh-add -l >/dev/null 2>&1 || ssh-add Is as effective and a lot more concise. On the other hand, fragile heuristics like: > export

https://bugzilla.mindrot.org/show_bug.cgi?id=3181 Bug ID: 3181 Summary: ssh-agent doesn't exit automatically after child program exits Product: Portable OpenSSH Version: 8.0p1 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 Component: ssh-agent

Hello, The version 0.11 of "PKCS#11 support in OpenSSH" is published. Changes: 1. Updated against OpenSSH 4.3p2. 2. Modified against Roumen Petrov's X.509 patch (version 5.4), so self-signed certificates are treated by the X.509 patch now. 3. Added --pkcs11-x509-force-ssh if X.509 patch applied, until some issues with the X.509 patch are resolved. 4. Fixed issues with gcc-2. You