search for: cleanup_new_fname

Hi, As the man page says, the --partial flag is to "keep partially transferred files". I'm assuming if I don't have partial flag any partially transferred files should be deleted. However this is not what I'm seeing. Example: (Using a big file so that rsync times a while to run. This gives me time to hit CTRL-C for the SIGINT). > mkdir example > dd if=/dev/zero

I've run into a bug in the IO handling when reading a file. Suppose I have a file that lives on an NFS filesystem. That filesystem is NOT being exported with auth=0 permissions. So, if I try to access a file as root, it successfully opens the file, but subsequent reads fail with EACCES. This produces a destination file full of null bytes. I noticed this with 2.5.7, but checked 2.6.2 as

...Paul --- a/cleanup.c 2012-04-15 14:14:02.913993934 +0200 +++ b/cleanup.c 2012-04-15 14:13:58.834033097 +0200 @@ -157,8 +157,9 @@ flush_write_file(cleanup_fd_w); close(cleanup_fd_w); } + cleanup_file->modtime = 0; /* solves problem with --partial --update */ finish_transfer(cleanup_new_fname, fname, NULL, NULL, - cleanup_file, 0, !partial_dir); + cleanup_file, 1, !partial_dir); } /* FALLTHROUGH */ On Sun 01 May 2011, Samuel Thibault wrote: > > Hello, > > My rsync script uses both options -u and --partial. This results into > partial files not being co...

...------- diff -rupNP rsync-2.6.2/cleanup.c rsync-2.6.2-fnameconv.clean/cleanup.c --- rsync-2.6.2/cleanup.c 2004-01-27 10:14:33.000000000 +0200 +++ rsync-2.6.2-fnameconv.clean/cleanup.c 2004-05-29 21:17:08.000000000 +0300 @@ -119,6 +119,7 @@ void _exit_cleanup(int code, const char finish_transfer(cleanup_new_fname, fname, cleanup_file); } io_flush(FULL_FLUSH); + cleanup_fname_convert(); if (cleanup_fname) do_unlink(cleanup_fname); if (code) { diff -rupNP rsync-2.6.2/errcode.h rsync-2.6.2-fnameconv.clean/errcode.h --- rsync-2.6.2/errcode.h 2003-12-15 10:04:14.000000000 +0200 +++ rsync-2.6.2-fnameco...