search for: clean_flist

...looked what's going, and found that my /testing.txt (containing it's origin) was transfered multible times: to be more exact, it was ever second matching tree [the longest file survived]. rsync -vvvv told me a bit more concrete what happened: removing duplicate name %s from file list %d clean_flist() in flist.c announces that he will remove the duplicated entry of the _previous_ list. but the file is beeing removed from the current list, while retaining the file from the previous list. thus, when the next file list is checked against this one (now "previous"), the file did not occur...

...f (verbose > 2) - rprintf(FINFO, "make_file(%s,*,%d)\n", fname, exclude_level); + if (verbose > 2) { + rprintf(FINFO, "[%c] make_file(%s,*,%d)\n", + *who_am_i, fname, exclude_level); + } file = new(struct file_struct); if (!file) @@ -1416,8 +1420,8 @@ static void clean_flist(struct file_list return; for (i = 0; i < flist->count; i++) { - rprintf(FINFO, "[%ld] i=%d %s %s mode=0%o len=%.0f\n", - (long) getpid(), i, + rprintf(FINFO, "[%c] i=%d %s %s mode=0%o len=%.0f\n", + *who_am_i, i, NS(flist->files[i]->dirname), NS(...

I am using rsnapshot <http://www.rsnapshot.org/> to make snapshots of my filesystem. rsnapshot uses rsync to do all the heavy lifting. I was recently browsing my snapshots and discovered that none of the excluded files or files deleted in the source are getting deleted from the snapshot. rsnapshot calls rsync like this: /usr/bin/rsync -a --delete --numeric-ids --relative --delete-excluded

Hi all, today we had a performance issue transfering a big amount of data where one file was over 50GB. Rsync was tunneled over SSH and we expected the data to be synced within hours. However after over 10 hours the data is still not synced ... The sending box has rsync running with 60-80 % CPU load (2GHz Pentium 4) while the receiver is nearly idle. So far I had no acces to the poblematic

...;re done. */ protocol_version = save_pv; stats.total_read = save_read; diff -rupNP --exclude-from cvs/.ignore cvs/flist.c pool2/flist.c --- cvs/flist.c Wed Feb 4 17:39:32 2004 +++ pool2/flist.c Thu Feb 5 18:41:21 2004 @@ -76,13 +76,12 @@ static unsigned int min_file_struct_len; static void clean_flist(struct file_list *flist, int strip_root, int no_dups); static void output_flist(struct file_list *flist); - void init_flist(void) { - struct file_struct f; + struct file_struct f; - /* Figure out how big the file_struct is without trailing padding */ - min_file_struct_len = ((char*)...

...itial proposal for a fix i posted, as suggested at the project's web site, to the rsync mailing list was: http://www.mail-archive.com/rsync@lists.samba.org/msg03117.html unfortunately, the only response to this issue was "Huh? I don't care about this at all." our both fixes for clean_flist() work. but with your fix, the clearing process will delete the second and following references of duplicated files. while in my approach the last reference of a duplicated file wins. i think, that deleting all but the last reference - is the right way because it's exactly what you expect and...

...clean_fname() function in utils.c. I think it will not produce the intended result for constructs like "./////foo" or "bar/././". The former case might pose a security risk. I think the first two ifs should be whiles. Regards, Christoph PS: Just let me say that having to run clean_flist() on both client and server _after_ the file list has been transmitted is a real PITA. -- Christoph Bartelmus mailto:bartelmus@eyeled.de Eyeled GmbH, Science Park Saar http://www.eyeled.de Stuhlsatzenhausweg 69 phone: +49-(0)6...

> Just curious: what about the rsync+ patch? Thanks for the reminder. I've just committed Jos's rsync+ patch onto the "branch_mbp_rsyncplus_merge" branch. If it works OK and nobody screams I will move it across onto the main tree tomorrow or Wednesday. I see the patch doesn't add documentation about the new options to the man page, so we should fix that in the future.

People of cygwin & rsync, I recently attempted to get cygwin and rsync working to solve a backup/mirroring need in my computer life. Well, as you might guess, I ran into a little but of trouble. Strangely enough, rsync seemed to be regularly hanging when I attempted to do a "get" (sycronize a remote to a local dir). Well, considering I want to automate this, that was not going