search for: cldap_search_state_destructor

...; When this is passed to cldap_search_send() it segfaults on line 603: > > if (!cldap->connected) { > > This is going to be icky, isn't it? No, it's not so bad. libcli/cldap/cldap.c is clearly supposed to cope with caller.cldap == NULL - you can see this in the function cldap_search_state_destructor() which checks: if (s->caller.cldap) before doing anything. Can you try this (amended) patch ? Thanks so much for your timely testing ! Cheers, Jeremy.

On 2016-10-17 19:37, Jeremy Allison wrote: > On Mon, Oct 17, 2016 at 11:27:12AM -0700, Jeremy Allison wrote: > >> No, it's not so bad. libcli/cldap/cldap.c is clearly supposed to cope >> with caller.cldap == NULL - you can see this in the function >> cldap_search_state_destructor() which checks: >> >> if (s->caller.cldap) >> >> before doing anything. Can you try this (amended) patch ? > > Scratch that - EBADPATCH (sorry :-). > > Here's something I think might actually work :-). > > Sorry, > > Jeremy. Glad you che...

On Mon, Oct 17, 2016 at 09:41:10AM -0700, Jeremy Allison via samba wrote: > On Mon, Oct 17, 2016 at 05:13:08PM +0100, Rebecca Gellman via samba wrote: > > > > > > Hi, > > > > So I did some digging into the source code, and I think I've found the > > issue. Around line 120 of source3/libads/cldap.c: > > > > for (i=0; i<num_servers;