search for: cirrus_mode

...m" uncovered a bug in the cirrus driver. It must create its own primary plane, using the correct format list, depending on the bpp module parameter, so it is consistent with mode_config->preferred_depth. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/cirrus/cirrus_mode.c | 67 +++++++++++++++++++++++++++++++++++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c index a830e70fc0..2e966a22c5 100644 --- a/drivers/gpu/drm/cirrus/cirrus_mode.c +++ b/drivers/gpu/drm/cirrus/cirrus_m...

--- drivers/gpu/drm/cirrus/cirrus_mode.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c index 4a02854..432ce94 100644 --- a/drivers/gpu/drm/cirrus/cirrus_mode.c +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c @@ -430,14 +430,6 @@ void cirrus_crtc_fb_gamm...

Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c index 7f9bc32af685..32ce2c1040b4 100644 --- a/drivers/gpu/drm/cirrus/cirrus_mode.c +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c @@ -615,6 +615,7 @@ void cirrus_modeset_fin...

Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/cirrus/cirrus_drv.h | 1 - drivers/gpu/drm/cirrus/cirrus_mode.c | 9 ++------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.h b/drivers/gpu/drm/cirrus/cirrus_drv.h index 915709739257..828b150cdb20 100644 --- a/drivers/gpu/drm/cirrus/cirrus_drv.h +++ b/drivers/gpu/drm/cirrus/cirrus_drv.h @@ -101,7 +101,6 @@ s...

--- drivers/gpu/drm/cirrus/cirrus_mode.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c index 4a02854..432ce94 100644 --- a/drivers/gpu/drm/cirrus/cirrus_mode.c +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c @@ -430,14 +430,6 @@ void cirrus_crtc_fb_gamm...

...s. So lets go with 16bpp. Also use the default depth for the framebuffer console and mode_info->preferred_depth. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/cirrus/cirrus_drv.c | 4 ++-- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 3 +-- drivers/gpu/drm/cirrus/cirrus_mode.c | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c b/drivers/gpu/drm/cirrus/cirrus_drv.c index 69c4e352dd..b4f7be056c 100644 --- a/drivers/gpu/drm/cirrus/cirrus_drv.c +++ b/drivers/gpu/drm/cirrus/cirrus_drv.c @@ -16,11 +16,11 @@ #include &...

...2 - drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_fb.c | 20 --- drivers/gpu/drm/ast/ast_mode.c | 28 +--- drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - drivers/gpu/drm/cirrus/cirrus_mode.c | 73 +++-------- drivers/gpu/drm/drm_atomic_helper.c | 37 ++---- drivers/gpu/drm/drm_color_mgmt.c | 27 +++- drivers/gpu/drm/drm_fb_helper.c | 195 +++++++++++++++++----------- drivers/gpu/drm/gma500/framebuffer.c | 22 ---- drivers/gpu/drm/gma50...

...2 - drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_fb.c | 20 --- drivers/gpu/drm/ast/ast_mode.c | 28 +--- drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - drivers/gpu/drm/cirrus/cirrus_mode.c | 73 +++-------- drivers/gpu/drm/drm_atomic_helper.c | 37 ++---- drivers/gpu/drm/drm_color_mgmt.c | 27 +++- drivers/gpu/drm/drm_fb_helper.c | 195 +++++++++++++++++----------- drivers/gpu/drm/gma500/framebuffer.c | 22 ---- drivers/gpu/drm/gma50...

...2 - drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_fb.c | 20 --- drivers/gpu/drm/ast/ast_mode.c | 28 +--- drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - drivers/gpu/drm/cirrus/cirrus_mode.c | 73 +++-------- drivers/gpu/drm/drm_atomic_helper.c | 37 ++---- drivers/gpu/drm/drm_color_mgmt.c | 27 +++- drivers/gpu/drm/drm_fb_helper.c | 195 +++++++++++++++++----------- drivers/gpu/drm/gma500/framebuffer.c | 22 ---- drivers/gpu/drm/gma50...

...gpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +- drivers/gpu/drm/ast/ast_mode.c | 2 +- drivers/gpu/drm/cirrus/cirrus_mode.c | 2 +- drivers/gpu/drm/drm_atomic_helper.c | 37 +++++++------------------------- drivers/gpu/drm/drm_color_mgmt.c | 27 ++++++++++++++++++++++- drivers/gpu/drm/gma500/gma_display.c | 2 +- drivers/gpu/drm/gma500/gma_display.h | 2 +- drivers/gpu/drm/mgag200/mgag200_m...

...y crtc mode_fixup function. drm/ast: removed optional dummy crtc mode_fixup function. drivers/gpu/drm/ast/ast_mode.c | 8 -------- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 --------- drivers/gpu/drm/bochs/bochs_kms.c | 8 -------- drivers/gpu/drm/cirrus/cirrus_mode.c | 13 ------------- drivers/gpu/drm/drm_crtc_helper.c | 9 ++++++--- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 8 -------- drivers/gpu/drm/gma500/cdv_intel_display.c | 13 ++++++------- drivers/gpu/drm/gma500/gma_display.c | 7 ------- drivers/gpu/dr...

...y crtc mode_fixup function. drm/ast: removed optional dummy crtc mode_fixup function. drivers/gpu/drm/ast/ast_mode.c | 8 -------- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 --------- drivers/gpu/drm/bochs/bochs_kms.c | 8 -------- drivers/gpu/drm/cirrus/cirrus_mode.c | 13 ------------- drivers/gpu/drm/drm_crtc_helper.c | 9 ++++++--- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 8 -------- drivers/gpu/drm/gma500/cdv_intel_display.c | 13 ++++++------- drivers/gpu/drm/gma500/gma_display.c | 7 ------- drivers/gpu/dr...

...| 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 8 -------- drivers/gpu/drm/ast/ast_mode.c | 8 -------- drivers/gpu/drm/bochs/bochs_kms.c | 8 -------- drivers/gpu/drm/cirrus/cirrus_mode.c | 9 --------- drivers/gpu/drm/exynos/exynos_dp_core.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 -------- drivers/gpu/d...

...| 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 8 -------- drivers/gpu/drm/ast/ast_mode.c | 8 -------- drivers/gpu/drm/bochs/bochs_kms.c | 8 -------- drivers/gpu/drm/cirrus/cirrus_mode.c | 9 --------- drivers/gpu/drm/exynos/exynos_dp_core.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 -------- drivers/gpu/d...

...raxel at redhat.com> > Cc: virtualization at lists.linux-foundation.org > --- > drivers/gpu/drm/cirrus/cirrus_drv.h | 1 - > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 8 ++++---- > drivers/gpu/drm/cirrus/cirrus_main.c | 25 ++++--------------------- > drivers/gpu/drm/cirrus/cirrus_mode.c | 4 ++-- > 4 files changed, 10 insertions(+), 28 deletions(-) Reviewed-by: Thierry Reding <treding at nvidia.com> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL:...

....com> > Cc: virtualization at lists.linux-foundation.org > --- > drivers/gpu/drm/cirrus/cirrus_drv.h | 9 ++------- > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 20 ++++++++++---------- > drivers/gpu/drm/cirrus/cirrus_main.c | 20 ++++++++++---------- > drivers/gpu/drm/cirrus/cirrus_mode.c | 12 +++--------- > 4 files changed, 25 insertions(+), 36 deletions(-) Reviewed-by: Thierry Reding <treding at nvidia.com> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not availa...

...drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_fb.c | 20 ----- drivers/gpu/drm/ast/ast_mode.c | 26 ++---- drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - drivers/gpu/drm/cirrus/cirrus_mode.c | 71 ++++----------- drivers/gpu/drm/drm_fb_helper.c | 131 +++++++++------------------- drivers/gpu/drm/gma500/framebuffer.c | 22 ----- drivers/gpu/drm/gma500/gma_display.c | 32 +++---- drivers/gpu/drm/gma500/psb_intel_display.c | 7 +- drivers/gpu/drm/g...

..._drv.h | 1 - > drivers/gpu/drm/ast/ast_fb.c | 20 ----- > drivers/gpu/drm/ast/ast_mode.c | 26 ++---- > drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - > drivers/gpu/drm/cirrus/cirrus_mode.c | 71 ++++----------- > drivers/gpu/drm/drm_fb_helper.c | 131 +++++++++------------------- > drivers/gpu/drm/gma500/framebuffer.c | 22 ----- > drivers/gpu/drm/gma500/gma_display.c | 32 +++---- > drivers/gpu/drm/gma500/psb_intel_display.c | 7 +...

On Wed, Apr 3, 2019 at 9:23 AM Gerd Hoffmann <kraxel at redhat.com> wrote: > > Time to kill some bad sample code people are copying from ;) > > This is a complete rewrite of the cirrus driver. The cirrus_mode_set() > function is pretty much the only function which is carried over largely > unmodified. Everything else is upside down. > > It is a single monster patch. But given that it does some pretty > fundamental changes to the drivers workflow and also reduces the code > size by ro...

Time to kill some bad sample code people are copying from ;) This is a complete rewrite of the cirrus driver. The cirrus_mode_set() function is pretty much the only function which is carried over largely unmodified. Everything else is upside down. It is a single monster patch. But given that it does some pretty fundamental changes to the drivers workflow and also reduces the code size by roughly 70% I think it'll s...