search for: cirrus_fbdev

...sed. Using 32bpp would limit the resolution to 800x600 due to hardware constrains. So lets go with 16bpp. Also use the default depth for the framebuffer console. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/cirrus/cirrus_drv.c | 4 ++-- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c b/drivers/gpu/drm/cirrus/cirrus_drv.c index 69c4e352dd..b4f7be056c 100644 --- a/drivers/gpu/drm/cirrus/cirrus_drv.c +++ b/drivers/gpu/drm/cirrus/cirrus_drv.c @@ -16,11 +16,11 @@ #include &...

...resolution to 800x600 due to hardware constrains. So lets go with 16bpp. Also use the default depth for the framebuffer console and mode_info->preferred_depth. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/cirrus/cirrus_drv.c | 4 ++-- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 3 +-- drivers/gpu/drm/cirrus/cirrus_mode.c | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c b/drivers/gpu/drm/cirrus/cirrus_drv.c index 69c4e352dd..b4f7be056c 100644 --- a/drivers/gpu/drm/cirrus/cirrus_drv.c +++ b/drivers/gpu/drm/cirru...

...l > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> > --- > drivers/gpu/drm/cirrus/cirrus_drv.h | 251 ----------- > drivers/gpu/drm/cirrus/cirrus.c | 602 +++++++++++++++++++++++++ > drivers/gpu/drm/cirrus/cirrus_drv.c | 161 ------- > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 309 ------------- > drivers/gpu/drm/cirrus/cirrus_main.c | 328 -------------- > drivers/gpu/drm/cirrus/cirrus_mode.c | 617 -------------------------- > drivers/gpu/drm/cirrus/cirrus_ttm.c | 343 -------------- > drivers/gpu/drm/cirrus/Kconfig | 2 +- > drivers/gpu...

...- It's a atomic driver now. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/cirrus/cirrus_drv.h | 251 ----------- drivers/gpu/drm/cirrus/cirrus.c | 602 +++++++++++++++++++++++++ drivers/gpu/drm/cirrus/cirrus_drv.c | 161 ------- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 309 ------------- drivers/gpu/drm/cirrus/cirrus_main.c | 328 -------------- drivers/gpu/drm/cirrus/cirrus_mode.c | 617 -------------------------- drivers/gpu/drm/cirrus/cirrus_ttm.c | 343 -------------- drivers/gpu/drm/cirrus/Kconfig | 2 +- drivers/gpu/drm/cirrus/Makefile...

...- It's a atomic driver now. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/cirrus/cirrus_drv.h | 251 ----------- drivers/gpu/drm/cirrus/cirrus.c | 602 +++++++++++++++++++++++++ drivers/gpu/drm/cirrus/cirrus_drv.c | 161 ------- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 309 ------------- drivers/gpu/drm/cirrus/cirrus_main.c | 328 -------------- drivers/gpu/drm/cirrus/cirrus_mode.c | 617 -------------------------- drivers/gpu/drm/cirrus/cirrus_ttm.c | 343 -------------- drivers/gpu/drm/cirrus/Kconfig | 2 +- drivers/gpu/drm/cirrus/Makefile...

...driver now. - It runs wayland. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/cirrus/cirrus_drv.h | 251 ---------- drivers/gpu/drm/cirrus/cirrus.c | 657 ++++++++++++++++++++++++++ drivers/gpu/drm/cirrus/cirrus_drv.c | 161 ------- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 309 ------------ drivers/gpu/drm/cirrus/cirrus_main.c | 328 ------------- drivers/gpu/drm/cirrus/cirrus_mode.c | 617 ------------------------ drivers/gpu/drm/cirrus/cirrus_ttm.c | 343 -------------- drivers/gpu/drm/cirrus/Kconfig | 2 +- drivers/gpu/drm/cirrus/Makefile |...

...river now. - It runs wayland. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/cirrus/cirrus_drv.h | 251 ----------- drivers/gpu/drm/cirrus/cirrus.c | 621 ++++++++++++++++++++++++++ drivers/gpu/drm/cirrus/cirrus_drv.c | 161 ------- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 309 ------------- drivers/gpu/drm/cirrus/cirrus_main.c | 328 -------------- drivers/gpu/drm/cirrus/cirrus_mode.c | 617 ------------------------- drivers/gpu/drm/cirrus/cirrus_ttm.c | 343 -------------- drivers/gpu/drm/cirrus/Kconfig | 2 +- drivers/gpu/drm/cirrus/Makefile...

On Thu, Nov 15, 2018 at 12:10:36PM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/cirrus/cirrus_fbdev.c: In function 'cirrusfb_create': > drivers/gpu/drm/cirrus/cirrus_fbdev.c:172:20: warning: > variable 'bo' set but not used [-Wunused-but-set-variable] > > It never used since introduction in commit > f9aa76a85248 ("drm/kms: driver for virtual cirrus under qemu...

...ged, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.h b/drivers/gpu/drm/cirrus/cirrus_drv.h index 915709739257..828b150cdb20 100644 --- a/drivers/gpu/drm/cirrus/cirrus_drv.h +++ b/drivers/gpu/drm/cirrus/cirrus_drv.h @@ -101,7 +101,6 @@ struct cirrus_crtc { struct cirrus_fbdev; struct cirrus_mode_info { - bool mode_config_initialized; struct cirrus_crtc *crtc; /* pointer to fbdev info structure */ struct cirrus_fbdev *gfbdev; diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c index 32ce2c1040b4..b109cd71426f 100644 --- a/...

..._FB_WIDTH 4096 - -#define CIRRUS_DPMS_CLEARED (-1) - -#define to_cirrus_crtc(x) container_of(x, struct cirrus_crtc, base) -#define to_cirrus_encoder(x) container_of(x, struct cirrus_encoder, base) - -struct cirrus_crtc { - struct drm_crtc base; - int last_dpms; - bool enabled; -}; - -struct cirrus_fbdev; -struct cirrus_mode_info { - struct cirrus_crtc *crtc; - /* pointer to fbdev info structure */ - struct cirrus_fbdev *gfbdev; -}; - -struct cirrus_encoder { - struct drm_encoder base; - int last_dpms; -}; - -struct cirrus_connector { - struct drm_connector base; -}; - -struct cirrus_mc { -...

..._FB_WIDTH 4096 - -#define CIRRUS_DPMS_CLEARED (-1) - -#define to_cirrus_crtc(x) container_of(x, struct cirrus_crtc, base) -#define to_cirrus_encoder(x) container_of(x, struct cirrus_encoder, base) - -struct cirrus_crtc { - struct drm_crtc base; - int last_dpms; - bool enabled; -}; - -struct cirrus_fbdev; -struct cirrus_mode_info { - struct cirrus_crtc *crtc; - /* pointer to fbdev info structure */ - struct cirrus_fbdev *gfbdev; -}; - -struct cirrus_encoder { - struct drm_encoder base; - int last_dpms; -}; - -struct cirrus_connector { - struct drm_connector base; -}; - -struct cirrus_mc { -...

...2 - drivers/gpu/drm/armada/armada_fbdev.c | 2 - drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_fb.c | 20 --- drivers/gpu/drm/ast/ast_mode.c | 28 +--- drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - drivers/gpu/drm/cirrus/cirrus_mode.c | 73 +++-------- drivers/gpu/drm/drm_atomic_helper.c | 37 ++---- drivers/gpu/drm/drm_color_mgmt.c | 27 +++- drivers/gpu/drm/drm_fb_helper.c | 195 +++++++++++++++++----------- drivers/gpu/drm/gma500/fr...

...2 - drivers/gpu/drm/armada/armada_fbdev.c | 2 - drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_fb.c | 20 --- drivers/gpu/drm/ast/ast_mode.c | 28 +--- drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - drivers/gpu/drm/cirrus/cirrus_mode.c | 73 +++-------- drivers/gpu/drm/drm_atomic_helper.c | 37 ++---- drivers/gpu/drm/drm_color_mgmt.c | 27 +++- drivers/gpu/drm/drm_fb_helper.c | 195 +++++++++++++++++----------- drivers/gpu/drm/gma500/fr...

...2 - drivers/gpu/drm/armada/armada_fbdev.c | 2 - drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_fb.c | 20 --- drivers/gpu/drm/ast/ast_mode.c | 28 +--- drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - drivers/gpu/drm/cirrus/cirrus_mode.c | 73 +++-------- drivers/gpu/drm/drm_atomic_helper.c | 37 ++---- drivers/gpu/drm/drm_color_mgmt.c | 27 +++- drivers/gpu/drm/drm_fb_helper.c | 195 +++++++++++++++++----------- drivers/gpu/drm/gma500/fr...

...off-by: Daniel Stone <daniels at collabora.com> > Cc: Dave Airlie <airlied at redhat.com> > Cc: Gerd Hoffmann <kraxel at redhat.com> > Cc: virtualization at lists.linux-foundation.org > --- > drivers/gpu/drm/cirrus/cirrus_drv.h | 1 - > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 8 ++++---- > drivers/gpu/drm/cirrus/cirrus_main.c | 25 ++++--------------------- > drivers/gpu/drm/cirrus/cirrus_mode.c | 4 ++-- > 4 files changed, 10 insertions(+), 28 deletions(-) Reviewed-by: Thierry Reding <treding at nvidia.com> -------------- next part -------------...

...Daniel Stone <daniels at collabora.com> > Cc: Dave Airlie <airlied at redhat.com> > Cc: Gerd Hoffmann <kraxel at redhat.com> > Cc: virtualization at lists.linux-foundation.org > --- > drivers/gpu/drm/cirrus/cirrus_drv.h | 9 ++------- > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 20 ++++++++++---------- > drivers/gpu/drm/cirrus/cirrus_main.c | 20 ++++++++++---------- > drivers/gpu/drm/cirrus/cirrus_mode.c | 12 +++--------- > 4 files changed, 25 insertions(+), 36 deletions(-) Reviewed-by: Thierry Reding <treding at nvidia.com> -------------- next par...

...performs the clean-up > of a failed initialization. If the fbdev's framebuffer was not initialized, > the clean-up will fail within drm_framebuffer_unregister_private. Booting > with cirrus.bpp=16 triggers this bug. > > The framebuffer is currently stored directly within struct cirrus_fbdev. To > fix the bug, we turn it into a pointer that is only set for initialized > framebuffers. The fbdev's clean-up code skips uninitialized framebuffers. > > The memory for struct drm_framebuffer is allocated dynamically. This requires > additional error handling within cirrusfb...

...dce_virtual.c | 23 ----- > drivers/gpu/drm/ast/ast_drv.h | 1 - > drivers/gpu/drm/ast/ast_fb.c | 20 ----- > drivers/gpu/drm/ast/ast_mode.c | 26 ++---- > drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - > drivers/gpu/drm/cirrus/cirrus_mode.c | 71 ++++----------- > drivers/gpu/drm/drm_fb_helper.c | 131 +++++++++------------------- > drivers/gpu/drm/gma500/framebuffer.c | 22 ----- > drivers/gpu/drm/gma500/gma_display.c | 32 +++----...

...ivers/gpu/drm/amd/amdgpu/dce_virtual.c | 23 ----- drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_fb.c | 20 ----- drivers/gpu/drm/ast/ast_mode.c | 26 ++---- drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - drivers/gpu/drm/cirrus/cirrus_mode.c | 71 ++++----------- drivers/gpu/drm/drm_fb_helper.c | 131 +++++++++------------------- drivers/gpu/drm/gma500/framebuffer.c | 22 ----- drivers/gpu/drm/gma500/gma_display.c | 32 +++---- drivers/gpu/drm/gma...

...a/armada_fbdev.c | 2 - > drivers/gpu/drm/ast/ast_drv.h | 1 - > drivers/gpu/drm/ast/ast_fb.c | 20 ---- > drivers/gpu/drm/ast/ast_mode.c | 26 +---- > drivers/gpu/drm/cirrus/cirrus_drv.h | 8 -- > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 - > drivers/gpu/drm/cirrus/cirrus_mode.c | 71 +++--------- > drivers/gpu/drm/drm_fb_helper.c | 164 +++++++++++++--------------- > drivers/gpu/drm/gma500/framebuffer.c | 22 ---- > drivers/gpu/drm/gma500/gma_display.c | 32 ++---- >...