search for: checksum2

...block collisions are reproducible and predictable. Thus, some files will be permanently "unlucky" in batch mode and will always need retransmission. Also, it means a malicious adversary can perform a performance degradation attack by injecting a pair of blocks with the same checksum1 and checksum2 (so that, for example, if you use rsync to backup your website database, someone could slow down your backups by posting carefully crafted comments). The latter issue also exists in non-batch mode, since time() is often predictable. The right thing to do is to always use a really random value (e.g....

...atched/checksum.c --- rsync-3.2.7.patch_orig/checksum.c 2023-05-16 14:17:31.078521657 -0400 +++ rsync-3.2.7.patched/checksum.c 2023-05-16 15:36:44.253892249 -0400 @@ -98,7 +98,7 @@ { CSUM_MD5, NNI_BUILTIN, "md5", NULL }; struct name_num_item *xfer_sum_nni; /* used for the transfer checksum2 computations */ -int xfer_sum_len; +size_t xfer_sum_len; struct name_num_item *file_sum_nni; /* used for the pre-transfer --checksum computations */ int file_sum_len, file_sum_extra_cnt; diff -Naur rsync-3.2.7.patch_orig/match.c rsync-3.2.7.patched/match.c --- rsync-3.2.7.patch_orig/match.c 202...

...(struct sum_buf *)malloc(sizeof(s->sums[0])*s->count); if (!s->sums) out_of_memory("generate_sums"); for (i=0;i<count;i++) { - int n1 = MIN(len,n); - char *map = map_ptr(buf,offset,n1); + map_ptr(buf,offset,n); - s->sums[i].sum1 = get_checksum1(map,n1); - get_checksum2(map,n1,s->sums[i].sum2); + s->sums[i].sum1 = get_checksum1(buf->m_ptr,buf->m_len); + get_checksum2(buf->m_ptr,buf->m_len,s->sums[i].sum2); s->sums[i].offset = offset; - s->sums[i].len = n1; + s->sums[i].len = buf->m_len; s->sums[i].i = i; if (ver...