search for: checkdebugify

...rototyped this idea for IR-level tests over the break. Adding a debug info test looks like this: > RUN: opt -S -debugify -loop-reduce -check-debugify addrec-gep.ll -o - | FileCheck ... > > The check-debugify pass can determine which DILocations and DIVariables went missing: > >> CheckDebugify: Instruction with empty DebugLoc -- %lsr.iv1 = bitcast double* %lsr.iv to i1* >> CheckDebugify: Missing line 3 >> CheckDebugify: Missing line 4 >> ... >> CheckDebugify: Missing line 33 > > This could be a handy way to create new targeted test cases at the IR/MIR lev...

> On Nov 13, 2017, at 11:53 AM, Vedant Kumar via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi Amara, > >> On Nov 10, 2017, at 9:12 AM, Amara Emerson via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >> >> Hi everyone, >> >> This RFC concerns the design and architecture of a generic machine

...you mind if I implement the debugify-each mode and refactor the code to have DebugifyFunctionPass and DebugifyLoopPass? I am sorry if it bothers you, I should have done this earlier, so you could focus on fixing the optimization passes. FYI, my debugify-each is quite ready, I am having Debugify and CheckDebugify before and after each ModulePass, then I just need to implement the FunctionPass and LoopPass. On Thu, Apr 26, 2018 at 8:53 PM, Vedant Kumar <vsk at apple.com> wrote: > Hello, > > On Apr 26, 2018, at 6:44 AM, Son Tuan VU <sontuan.vu119 at gmail.com> wrote: > > Hi Vedan...

...unction Pass Manager) and override the add() method like this: > > class DebugifyEachPassManager : public legacy::PassManager { > public: > void add(Pass *P) override { > PassManager::add(createDebugifyPass()); > PassManager::add(P); > PassManager::add(createCheckDebugifyPass()); > } > > bool run(Module &M) { > return PassManager::run(M); > } > }; > > However, we can't apply and check debugify of FunctionPasses since these passes are managed by Function Pass Managers created on the fly duri...

...ost. The idea is to make it easier to write targeted test cases for debug info preservation. For example, here is a quick way to test that Mem2Reg doesn't drop debug info from one test input: > ; RUN: opt < %s -debugify -mem2reg -check-debugify -S 2>&1 | FileCheck %s > ; CHECK: CheckDebugify: PASS So far, I've used this utility to identify problems in LSR and instcombine (haven't gotten around to filing bugs yet). There's some more discussion about this utility on the thread "RFC: [GlobalISel] Towards a generic MI combiner framework", where Amara and Daniel sugge...

...new *Module* Pass Manager (not Function Pass Manager) and override the *add()* method like this: class DebugifyEachPassManager : public legacy::PassManager { public: void add(Pass *P) override { PassManager::add(createDebugifyPass()); PassManager::add(P); PassManager::add(createCheckDebugifyPass()); } bool run(Module &M) { return PassManager::run(M); } }; However, we can't apply and check debugify of *FunctionPass*es since these passes are managed by Function Pass Managers created on the fly during *schedulePass()*. I guess we'd have to implement the Functio...

Mhm I see now, thanks for your explanation! Son Tuan Vu On Fri, Mar 16, 2018 at 10:58 PM, Vedant Kumar <vsk at apple.com> wrote: > > On Mar 16, 2018, at 2:30 PM, Son Tuan VU <sontuan.vu119 at gmail.com> wrote: > > Hi Vedant, > > Thank you for your reply. I think I can make this debugify-each mode, but > I guess this is reserved for your GSoC project ? > >

> On Mar 16, 2018, at 2:30 PM, Son Tuan VU <sontuan.vu119 at gmail.com> wrote: > > Hi Vedant, > > Thank you for your reply. I think I can make this debugify-each mode, but I guess this is reserved for your GSoC project ? No, there's no reserved work. If you'd like to work on this I encourage you to do so. There's plenty of other work slated for the GSoC project.

...it easier to write targeted test cases for debug info preservation. For > example, here is a quick way to test that Mem2Reg doesn't drop debug info > from one test input: > > > ; RUN: opt < %s -debugify -mem2reg -check-debugify -S 2>&1 | FileCheck %s > > ; CHECK: CheckDebugify: PASS > > So far, I've used this utility to identify problems in LSR and instcombine > (haven't gotten around to filing bugs yet). There's some more discussion > about this utility on the thread "RFC: [GlobalISel] Towards a generic MI > combiner framework", wher...