search for: check_str

...g length : ......... Locations : ............ Matching groups : .............. Test padding : .... Splitting strings : ......................... Extracting substrings : ................... Trimming strings : ........ 1. Failure(@test-check.r#4): string is atomic ---------------------------------- check_string(list()) does not match 'must be an atomic'. Actual value: "Error in force(expr) : could not find function "check_string"\n" 2. Failure(@test-check.r#9): pattern is a string ------------------------------- check_pattern(1) does not match 'must be a character vecto...

Dear Raju I agree to Dirk that this is not really the best place for these matters, but as I got curious, I checked and found you should use test_package() and not test_dir(), as the latter does not load unexported functions of the package (such as check_string()) that may occur in the tests. For packaging of r-cran-stringr, it is probably most efficient to file a bug report there because of the missing Suggests for r-cran-testthat. Kind regards, Johannes Am Sonntag, 19. April 2015, 17:58:53 schrieb kamaraju kusumanchi: > I am trying to learn h...

...? ? #' @keywords character? ? #' @seealso \code{\link{nchar}} which this function wraps? ? #' @export #' @examples? ? #' str_length(letters)? ? #' str_length(c("i", "like", "programming", NA))? ? str_length <- function(string) { string <- check_string(string) ? ? ? nc <- nchar(string, allowNA = TRUE)? ? ? is.na(nc) <- is.na(string)? ? ? nc? ? } When you `roxygenise` your package these comments will be automatically transformed to the Rd file you need to pass `R CMD check`: ? ? \name{str_length}? ? \alias{str_length}? ? \title{The length...

...? ? #' @keywords character? ? #' @seealso \code{\link{nchar}} which this function wraps? ? #' @export #' @examples? ? #' str_length(letters)? ? #' str_length(c("i", "like", "programming", NA))? ? str_length <- function(string) { string <- check_string(string) ? ? ? nc <- nchar(string, allowNA = TRUE)? ? ? is.na(nc) <- is.na(string)? ? ? nc? ? } When you `roxygenise` your package these comments will be automatically transformed to the Rd file you need to pass `R CMD check`: ? ? \name{str_length}? ? \alias{str_length}? ? \title{The length...

Since the v1 series (0/4, at [1]), I've applied patches 1 and 2, rewritten patch 3 [Forbid NUL in export and context names] into patch 4 here, patch 4 there turned into patch 6 here, and everything else here is new. [1]https://www.redhat.com/archives/libguestfs/2019-September/msg00180.html I don't know if there is a handy reusable function for checking whether a string contains valid

...rror)) { g_string_append_printf (output, " ERROR: Could not spawn diff to compare the results: %s\n", diff --git a/test/various/gc.c b/test/various/gc.c index a6e378b..ebc87a8 100644 --- a/test/various/gc.c +++ b/test/various/gc.c @@ -33,7 +33,7 @@ }G_STMT_END static guint -check_strings () +check_strings (void) { const char *s; guint errors = 0; @@ -52,7 +52,7 @@ check_strings () } static guint -check_objects () +check_objects (void) { SwfdecAsObject *object; guint errors = 0; @@ -85,7 +85,7 @@ check_objects () } static guint -check_object_variables () +c...

..._from_set_meta_context, exportname); + conn->meta_context_base_allocation = false; + } + + if (protocol_common_open (exportsize, &conn->eflags, exportname) == -1) return -1; debug ("newstyle negotiation: flags: export 0x%x", conn->eflags); @@ -238,22 +256,13 @@ check_string (uint32_t option, char *buf, uint32_t len, uint32_t maxlen, */ static int check_export_name (uint32_t option, char *buf, - uint32_t exportnamelen, uint32_t maxlen, bool save) + uint32_t exportnamelen, uint32_t maxlen) { GET_CONN; if (check_string...

...rotocol_common_open (conn, exportsize, &conn->eflags) == -1) + struct connection *conn = GET_CONN; + + if (protocol_common_open (exportsize, &conn->eflags) == -1) return -1; debug ("newstyle negotiation: flags: export 0x%x", conn->eflags); @@ -233,9 +231,11 @@ check_string (uint32_t option, char *buf, uint32_t len, uint32_t maxlen, * validate an export name. */ static int -check_export_name (struct connection *conn, uint32_t option, char *buf, +check_export_name (uint32_t option, char *buf, uint32_t exportnamelen, uint32_t maxlen, bool sav...

v1 was here: https://www.redhat.com/archives/libguestfs/2020-February/msg00081.html v2 replaces struct connection *conn = GET_CONN; with GET_CONN; which sets conn implicitly and asserts that it is non-NULL. If we actually want to test if conn is non-NULL or behave differently, then you must use threadlocal_get_conn() instead, and some existing uses do that. Rich.

The third patch is a large but mechanical change which gets rid of passing around struct connection * entirely within the server, preferring instead to reference the connection through thread-local storage. I hope this is a gateway to simplifying other parts of the code. Rich.

...mb2/lock.c Compiling torture/smb2/notify.c Compiling torture/smb2/smb2.c Compiling torture/smb2/durable_open.c Compiling torture/smb2/oplock.c Compiling torture/smb2/dir.c torture/smb2/dir.c:550:1: warning: macro "CHECK_UNIX_NAME" is not used torture/smb2/dir.c:509:1: warning: macro "CHECK_STR" is not used torture/smb2/dir.c:478:1: warning: macro "CHECK_TIME" is not used Compiling torture/smb2/lease.c Compiling torture/smb2/create.c torture/smb2/create.c:116:1: warning: macro "SET_ATTRIB" is not used torture/smb2/create.c:59:1: warning: macro "CHECK_TIME&quo...