search for: check_programs

CentOS 6 has libguestfs-devel 1.20.11, which predates the support in guestfs_add_drive_opts() for requesting an nbd drive instead of a local file (annoyingly, guestfs documentation merely states the function was available since 0.3, without saying which later releases added new options); causing a compilation failure during 'make check'. Maybe the guestfs plugin should still be built,

...oring to the HAVE_LIBGUESTFS conditional, coupled with the addition of a LIBGUESTFS_TESTS intermediate list, allows us to run a few more tests on CentOS 6 (adding some tests of command-line behavior and filters that was previously completely skipped). For the two tests that we can't run, using check_PROGRAMS still causes those programs to try to compile (which leads to compile errors); but using EXTRA_PROGRAMS keeps automake silent without getting those sources in the way, while still distributing the sources for someone motivated to fix the tests. Compared to the previous patch (14/14 pass and 5 skip...

...m index 96030407..59ae71f4 100644 --- a/src/test_grabbag/cuesheet/Makefile.am +++ b/src/test_grabbag/cuesheet/Makefile.am @@ -23,7 +23,7 @@ EXTRA_DIST = \ test_cuesheet.vcxproj.filters AM_CPPFLAGS = -I$(top_builddir) -I$(srcdir)/include -I$(top_srcdir)/include -noinst_PROGRAMS = test_cuesheet +check_PROGRAMS = test_cuesheet test_cuesheet_SOURCES = \ main.c test_cuesheet_LDADD = \ diff --git a/src/test_grabbag/picture/Makefile.am b/src/test_grabbag/picture/Makefile.am index b1a949e5..0ee04a41 100644 --- a/src/test_grabbag/picture/Makefile.am +++ b/src/test_grabbag/picture/Makefile.am @@ -23,7 +23,7...

...that change was not supposed to exist in the repos yet diff --git a/test/trace/Makefile.am b/test/trace/Makefile.am index e1c8e02..6fda1cf 100644 --- a/test/trace/Makefile.am +++ b/test/trace/Makefile.am @@ -1,11 +1,3 @@ -if HAVE_MING -SUBDIRS = ming -else -SUBDIRS = -endif -DIST_SUBDIRS = ming - -check_PROGRAMS = trace TESTS = $(check_PROGRAMS) trace_SOURCES = trace.c

I was a little surprised to find that LIBNBD_TLS_ALLOW worked out of the box, so I had to examine the logs whereupon I saw the magic message ... libnbd: debug: nbd1: nbd_connect_command: server refused TLS (policy), continuing with unencrypted connection I don't believe this path has ever been tested before. It's possible the tests could be improved if they actually checked for this

Add a dummy C source, otherwise automake tries to look for e.g. common_utils_tests.c. Also, set check_PROGRAMS properly with them. --- mllib/Makefile.am | 48 +++++++++++++++++++++++++++++++++--------------- mllib/dummy.c | 2 ++ po/POTFILES | 1 + 3 files changed, 36 insertions(+), 15 deletions(-) create mode 100644 mllib/dummy.c diff --git a/mllib/Makefile.am b/mllib/Makefile.am index c7967...

...\ { \ diff --git a/tests/Makefile.am b/tests/Makefile.am index c2d473a..daf1d2a 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -71,6 +71,12 @@ check-valgrind: # Basic server command line and start-up tests. +check_PROGRAMS = +check_DATA = +check_SCRIPTS = +check_LTLIBRARIES = +noinst_LTLIBRARIES = + TESTS = \ test-help.sh \ test-help-plugin.sh \ @@ -86,24 +92,34 @@ TESTS = \ test-ipv4.sh \ test-socket-activation -check_PROGRAMS = \ +check_PROGRAMS += \ test-socket-activation test_socket_activation_SOU...

This version uses Eric's subtype suggestion: https://bugzilla.redhat.com/show_bug.cgi?id=1418328#c6 Rich.

This version uses a static initializer function (https://bugzilla.redhat.com/show_bug.cgi?id=1418328#c9). Rich.

Hi Erik, I've found a middleground for the problem of setting default CFLAGS. I've gone back to setting them if {C,CXX,CPP,LD}FLAGS are unset at the onset of the configure script (i.e., the user hasn't specified anything) and then proceed to set them to the defaults as before. This has been suggested before: https://lists.gnu.org/archive/html/autoconf/2006-04/msg00022.html In

...nstalled header. Signed-off-by: Eric Blake <eblake at redhat.com> --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index c2d473a..9076d6b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -103,7 +103,7 @@ check_PROGRAMS += \ test_cxx_SOURCES = test-cxx.cpp test_cxx_CXXFLAGS = \ - $(WARNINGS_CFLAGS) + -I ../include $(WARNINGS_CFLAGS) endif # In-depth tests need libguestfs, since that is a convenient way to -- 2.9.3

...discussion rather than actually pushing it. --- interop/Makefile.am | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/interop/Makefile.am b/interop/Makefile.am index 16438dc..b0ee5a3 100644 --- a/interop/Makefile.am +++ b/interop/Makefile.am @@ -45,9 +45,22 @@ check_PROGRAMS += \ interop-qemu-nbd-tls-certs \ interop-qemu-nbd-tls-psk TESTS += \ - interop-qemu-nbd \ - interop-qemu-nbd-tls-certs \ + interop-qemu-nbd + +# tls tests assume the pre-existence of files created in ../tests/Makefile.am, +# so we can only run them under the same conditions used there +if HAV...

...b/common/include/Makefile.am index a7d0d026..0521f65b 100644 --- a/common/include/Makefile.am +++ b/common/include/Makefile.am @@ -45,13 +45,14 @@ EXTRA_DIST = \ nextnonzero.h \ random.h \ rounding.h \ + test-proof.sh \ tvdiff.h \ unix-path-max.h \ $(NULL) # Unit tests. -TESTS = \ +check_PROGRAMS = \ test-ascii-ctype \ test-ascii-string \ test-byte-swapping \ @@ -63,7 +64,10 @@ TESTS = \ test-random \ test-tvdiff \ $(NULL) -check_PROGRAMS = $(TESTS) +TESTS = \ + test-proof.sh \ + $(check_PROGRAMS) \ + $(NULL) test_ascii_ctype_SOURCES = test-ascii-ctype.c ascii-ctype.h test_a...

...ot tested. - Implement nbd_connect + systemd socket activation. Improve function trace output so that: diff --git a/interop/Makefile.am b/interop/Makefile.am index 8a5b787..43350a8 100644 --- a/interop/Makefile.am +++ b/interop/Makefile.am @@ -145,17 +145,25 @@ if HAVE_GNUTLS if HAVE_CERTTOOL check_PROGRAMS += \ interop-nbdkit-tls-certs \ + interop-nbdkit-tls-certs-allow-enabled \ + interop-nbdkit-tls-certs-allow-fallback \ $(NULL) TESTS += \ interop-nbdkit-tls-certs \ + interop-nbdkit-tls-certs-allow-enabled \ + interop-nbdkit-tls-certs-allow-fallback \ $(NULL) endif if HAVE_PSKTOOL check...

...CAMLPACKAGES_TESTS) \ + $(getopt_tests_THEOBJECTS) -o $@ + JSON_tests_DEPENDENCIES = $(JSON_tests_THEOBJECTS) $(top_srcdir)/ocaml-link.sh JSON_tests_LINK = \ $(top_srcdir)/ocaml-link.sh -- \ @@ -201,8 +225,10 @@ JSON_tests_LINK = \ TESTS_ENVIRONMENT = $(top_builddir)/run --test -TESTS = -check_PROGRAMS = +TESTS = \ + test-getopt.sh +check_PROGRAMS = \ + getopt_tests if HAVE_OCAML_PKG_OUNIT check_PROGRAMS += common_utils_tests JSON_tests diff --git a/mllib/getopt_tests.ml b/mllib/getopt_tests.ml new file mode 100644 index 0000000..fb089ec --- /dev/null +++ b/mllib/getopt_tests.ml @@ -0,0 +1,68...

Hi, few miscellaneous fixes for nbdkit. Thanks, Pino Toscano (3): build: use AC_MSG_RESULT for $PERL_LDOPTS crypto: add missing '{' tests: fix generation of PKI test data configure.ac | 1 + src/crypto.c | 2 +- tests/Makefile.am | 10 +++++----- 3 files changed, 7 insertions(+), 6 deletions(-) -- 2.13.6

...s.c +/tests/c-api/test-threads /tests/c-api/test*.tmp /tests/c-api/test-user-cancel /tests/charsets/test-charset-fidelity diff --git a/tests/c-api/Makefile.am b/tests/c-api/Makefile.am index d79b8ed52..e80f88fa0 100644 --- a/tests/c-api/Makefile.am +++ b/tests/c-api/Makefile.am @@ -41,7 +41,8 @@ check_PROGRAMS = \ test-debug-to-file \ test-environment \ test-pwd \ - test-event-string + test-event-string \ + test-threads if HAVE_LIBDL check_PROGRAMS += \ test-dlopen @@ -59,7 +60,8 @@ TESTS = \ test-user-cancel \ test-debug-to-file \ test-environment \ - test-event-string + test-event-strin...

...100644 --- a/test/various/.gitignore +++ b/test/various/.gitignore @@ -10,4 +10,3 @@ Makefile.in gc ringbuffer -urlencode diff --git a/test/various/Makefile.am b/test/various/Makefile.am index 36bc8da..072c490 100644 --- a/test/various/Makefile.am +++ b/test/various/Makefile.am @@ -1,4 +1,4 @@ -check_PROGRAMS = gc ringbuffer urlencode +check_PROGRAMS = gc ringbuffer TESTS = $(check_PROGRAMS) gc_SOURCES = gc.c @@ -9,7 +9,3 @@ ringbuffer_SOURCES = ringbuffer.c ringbuffer_CFLAGS = $(GLOBAL_CFLAGS) $(SWFDEC_CFLAGS) $(CAIRO_CFLAGS) ringbuffer_LDFLAGS = $(SWFDEC_LIBS) $(CAIRO_LIBS) -urlencode_SOURCES...

...\""$(datadir)/locale"\" \ -I$(top_srcdir)/src -I$(top_builddir)/src \ -I$(top_srcdir)/fish \ diff --git a/tests/protocol/Makefile.am b/tests/protocol/Makefile.am index 8494fa0..4cdd96f 100644 --- a/tests/protocol/Makefile.am +++ b/tests/protocol/Makefile.am @@ -43,7 +43,6 @@ check_PROGRAMS = test-error-messages test_error_messages_SOURCES = \ test-error-messages.c test_error_messages_CPPFLAGS = \ - -DGUESTFS_PRIVATE=1 \ -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \ -I$(top_srcdir)/src -I$(top_builddir)/src test_error_messages_CFLAGS = \ diff --git a/tests/qemu/Ma...

....ml \ + var_expander.ml \ python_script.ml \ name_from_disk.ml \ vCenter.ml \ @@ -442,7 +444,7 @@ TESTS += \ endif if HAVE_OCAML_PKG_OUNIT -TESTS += v2v_unit_tests +TESTS += v2v_unit_tests var_expander_tests endif if ENABLE_APPLIANCE @@ -651,7 +653,7 @@ EXTRA_DIST += \ # Unit tests. check_PROGRAMS = if HAVE_OCAML_PKG_OUNIT -check_PROGRAMS += v2v_unit_tests +check_PROGRAMS += v2v_unit_tests var_expander_tests endif v2v_unit_tests_BOBJECTS = \ @@ -671,13 +673,28 @@ v2v_unit_tests_SOURCES = $(virt_v2v_SOURCES) v2v_unit_tests_CPPFLAGS = $(virt_v2v_CPPFLAGS) v2v_unit_tests_CFLAGS = $(virt_...