search for: check_ltlibraries

...\ diff --git a/tests/Makefile.am b/tests/Makefile.am index c2d473a..daf1d2a 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -71,6 +71,12 @@ check-valgrind: # Basic server command line and start-up tests. +check_PROGRAMS = +check_DATA = +check_SCRIPTS = +check_LTLIBRARIES = +noinst_LTLIBRARIES = + TESTS = \ test-help.sh \ test-help-plugin.sh \ @@ -86,24 +92,34 @@ TESTS = \ test-ipv4.sh \ test-socket-activation -check_PROGRAMS = \ +check_PROGRAMS += \ test-socket-activation test_socket_activation_SOURCES = test-socket-activation.c test_socket_activat...

This version uses Eric's subtype suggestion: https://bugzilla.redhat.com/show_bug.cgi?id=1418328#c6 Rich.

This version uses a static initializer function (https://bugzilla.redhat.com/show_bug.cgi?id=1418328#c9). Rich.

..._PLUGIN(plugin) > +++ b/tests/Makefile.am > > +# This builds a plugin using an ANSI (ISO C90) compiler to ensure that > +# the header file is compatible. The plugin does nothing very > +# interesting, it's mainly a compile test. > +TESTS += \ > + test-ansi-c.sh > +# check_LTLIBRARIES won't build a shared library (see automake manual). > +# So we have to do this and add a dependency. > +noinst_LTLIBRARIES += test-ansi-c-plugin.la > +test-ansi-c.sh: test-ansi-c-plugin.la > + > +test_ansi_c_plugin_la_SOURCES = \ > + test-ansi-c-plugin.c \ > + $(top_srcdir)...

...-full.sh \ @@ -267,6 +268,7 @@ TESTS += \ test-foreground.sh \ test-debug-flags.sh \ test-long-name.sh \ + test-flush.sh \ test-swap.sh \ test-shutdown.sh \ $(NULL) @@ -282,6 +284,25 @@ test_socket_activation_CPPFLAGS = \ $(NULL) test_socket_activation_CFLAGS = $(WARNINGS_CFLAGS) +# check_LTLIBRARIES won't build a shared library (see automake manual). +# So we have to do this and add a dependency. +noinst_LTLIBRARIES += \ + test-flush-plugin.la \ + $(NULL) +test-flush.sh: test-flush-plugin.la + +test_flush_plugin_la_SOURCES = \ + test-flush-plugin.c \ + $(top_srcdir)/include/nbdkit-plugin.h...

...TESTS += \ test-start.sh \ test-single.sh \ test-single-from-file.sh \ + test-single-sh.sh \ + test-stdio.sh \ test-captive.sh \ test-random-sock.sh \ test-tls.sh \ @@ -289,6 +293,25 @@ test_socket_activation_CPPFLAGS = \ $(NULL) test_socket_activation_CFLAGS = $(WARNINGS_CFLAGS) +# check_LTLIBRARIES won't build a shared library (see automake manual). +# So we have to do this and add a dependency. +noinst_LTLIBRARIES += \ + test-stdio-plugin.la \ + $(NULL) +test-stdio.sh: test-stdio-plugin.la + +test_stdio_plugin_la_SOURCES = \ + test-stdio-plugin.c \ + $(top_srcdir)/include/nbdkit-plugin.h...

We previously discussed allowing the plugin API to be consumed by non-GCC/non-Clang/old compilers. This implements a test. Rich.

...test-version.sh \ @@ -351,6 +352,33 @@ test_just_filter_header_CPPFLAGS = \ $(NULL) test_just_filter_header_CFLAGS = $(WARNINGS_CFLAGS) +# Build a plugin with libtool -undefined flag. This is how plugins +# were built before libnbdkit.so existed. +TESTS += \ + test-undefined.sh \ + $(NULL) +# check_LTLIBRARIES won't build a shared library (see automake manual). +# So we have to do this and add a dependency. +noinst_LTLIBRARIES += test-undefined-plugin.la +test-undefined.sh: test-undefined-plugin.la + +test_undefined_plugin_la_SOURCES = \ + test-undefined-plugin.c \ + $(top_srcdir)/include/nbdkit-plug...

...h \ + test-dlopen.sh \ test-debug-flags.sh \ test-dump-config.sh \ test-dump-plugin.sh \ @@ -374,6 +375,30 @@ test_cxx_filter_la_LDFLAGS = \ $(NULL) endif HAVE_CXX +# This builds a plugin that calls dlopen, to test our dlopen override +# that supplies a prefix. +TESTS += test-dlopen.sh +# check_LTLIBRARIES won't build a shared library (see automake manual). +# So we have to do this and add a dependency. +noinst_LTLIBRARIES += test-dlopen-plugin.la +test-dlopen.sh: test-dlopen-plugin.la + +test_dlopen_plugin_la_SOURCES = \ + test-dlopen-plugin.c \ + $(top_srcdir)/include/nbdkit-plugin.h \ + $(NULL...

Either patch 1 or patch 2 in isolation is sufficient to fix the problem that Rich forwarded on from an archlinux tester (name so I can credit them?). But both patches should be applied, as well as backported to appropriate stable branches, to maximize cross-version interoperability of nbdkit vs. plugins. Patch 3 will let us detect future similar bugs much faster. I want patch 4 to ensure that

...62,29 @@ test_socket_activation_CFLAGS = $(WARNINGS_CFLAGS) endif HAVE_PLUGINS +# This builds a plugin using an ANSI (ISO C90) compiler to ensure that +# the header file is compatible. The plugin does nothing very +# interesting, it's mainly a compile test. +TESTS += \ + test-ansi-c.sh +# check_LTLIBRARIES won't build a shared library (see automake manual). +# So we have to do this and add a dependency. +noinst_LTLIBRARIES += test-ansi-c-plugin.la +test-ansi-c.sh: test-ansi-c-plugin.la + +test_ansi_c_plugin_la_SOURCES = \ + test-ansi-c-plugin.c \ + $(top_srcdir)/include/nbdkit-plugin.h +test_ansi...

...= nouveau_bo(*bo); if (!nvbo->name) { diff --git a/tests/Makefile.am b/tests/Makefile.am index 37b8d3a..38e4094 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -28,6 +28,10 @@ if HAVE_TEGRA SUBDIRS += tegra endif +if HAVE_NOUVEAU +SUBDIRS += nouveau +endif + if HAVE_LIBUDEV check_LTLIBRARIES = libdrmtest.la diff --git a/tests/nouveau/.gitignore b/tests/nouveau/.gitignore new file mode 100644 index 0000000..837bfb9 --- /dev/null +++ b/tests/nouveau/.gitignore @@ -0,0 +1 @@ +threaded diff --git a/tests/nouveau/Makefile.am b/tests/nouveau/Makefile.am new file mode 100644 index 0000000..8e...

....am +++ b/tests/Makefile.am @@ -265,6 +265,7 @@ TESTS += \ test-debug-flags.sh \ test-long-name.sh \ test-swap.sh \ + test-shutdown.sh \ $(NULL) check_PROGRAMS += \ @@ -278,6 +279,25 @@ test_socket_activation_CPPFLAGS = \ $(NULL) test_socket_activation_CFLAGS = $(WARNINGS_CFLAGS) +# check_LTLIBRARIES won't build a shared library (see automake manual). +# So we have to do this and add a dependency. +noinst_LTLIBRARIES += \ + test-shutdown-plugin.la \ + $(NULL) +test-shutdown.sh: test-shutdown-plugin.la + +test_shutdown_plugin_la_SOURCES = \ + test-shutdown-plugin.c \ + $(top_srcdir)/include/...

...a/tests/Makefile.am +++ b/tests/Makefile.am @@ -272,6 +272,7 @@ test_stdio_plugin_la_CFLAGS = $(WARNINGS_CFLAGS) test_stdio_plugin_la_LDFLAGS = \ -module -avoid-version -shared $(NO_UNDEFINED_ON_WINDOWS) -rpath /nowhere \ $(NULL) +test_stdio_plugin_la_LIBADD = $(LINK_LIBNBDKIT_ON_WINDOWS) # check_LTLIBRARIES won't build a shared library (see automake manual). # So we have to do this and add a dependency. @@ -291,6 +292,7 @@ test_flush_plugin_la_CFLAGS = $(WARNINGS_CFLAGS) test_flush_plugin_la_LDFLAGS = \ -module -avoid-version -shared $(NO_UNDEFINED_ON_WINDOWS) -rpath /nowhere \ $(NULL) +test...

https://bugzilla.redhat.com/show_bug.cgi?id=701814

...kefile.am b/tests/Makefile.am > index 37b8d3a..38e4094 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -28,6 +28,10 @@ if HAVE_TEGRA > SUBDIRS += tegra > endif > > +if HAVE_NOUVEAU > +SUBDIRS += nouveau > +endif > + > if HAVE_LIBUDEV > > check_LTLIBRARIES = libdrmtest.la > diff --git a/tests/nouveau/.gitignore b/tests/nouveau/.gitignore > new file mode 100644 > index 0000000..837bfb9 > --- /dev/null > +++ b/tests/nouveau/.gitignore > @@ -0,0 +1 @@ > +threaded > diff --git a/tests/nouveau/Makefile.am b/tests/nouveau/Makefile.a...

In v2: - use int instead of bool in the public header - split the tests from the code - don't overload test-layers; instead, add new tests - add a missing fflush exposed by the new tests - other minor cleanups Eric Blake (3): server: Add nbdkit_stdio_safe server: Sanitize stdin/out before running plugin code server: More tests of stdin/out handling docs/nbdkit-plugin.pod |

...e4094 100644 >> --- a/tests/Makefile.am >> +++ b/tests/Makefile.am >> @@ -28,6 +28,10 @@ if HAVE_TEGRA >> SUBDIRS += tegra >> endif >> >> +if HAVE_NOUVEAU >> +SUBDIRS += nouveau >> +endif >> + >> if HAVE_LIBUDEV >> >> check_LTLIBRARIES = libdrmtest.la >> diff --git a/tests/nouveau/.gitignore b/tests/nouveau/.gitignore >> new file mode 100644 >> index 0000000..837bfb9 >> --- /dev/null >> +++ b/tests/nouveau/.gitignore >> @@ -0,0 +1 @@ >> +threaded >> diff --git a/tests/nouveau/Makefi...

...pv4.sh \ + test-socket-activation + +check_PROGRAMS = \ + test-socket-activation + +test_socket_activation_SOURCES = test-socket-activation.c +test_socket_activation_CFLAGS = $(WARNINGS_CFLAGS) # In-depth tests need libguestfs, since that is a convenient way to # drive qemu. @@ -103,7 +110,6 @@ check_LTLIBRARIES = libtest.la libtest_la_SOURCES = test.c test.h libtest_la_CFLAGS = $(WARNINGS_CFLAGS) -check_PROGRAMS = check_DATA = check_SCRIPTS = diff --git a/tests/test-socket-activation.c b/tests/test-socket-activation.c new file mode 100644 index 0000000..5ecdde1 --- /dev/null +++ b/tests/test-socke...

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at ubuntu.com> --- xf86atomic.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xf86atomic.h b/xf86atomic.h index 8c4b696..17fb088 100644 --- a/xf86atomic.h +++ b/xf86atomic.h @@ -49,6 +49,7 @@ typedef struct { # define atomic_read(x) ((x)->atomic) # define atomic_set(x, val) ((x)->atomic = (val)) # define atomic_inc(x)