search for: check_ip_opt

I'm seeing something similar to bug 1179 (https://bugzilla.mindrot.org/show_bug.cgi?id=1179), even with the reordered IP options check. For some reason, getsockopt is returning an IP options of length 2, value 00 00. Would Mark Weindling's original patch (https://bugzilla.mindrot.org/attachment.cgi?id=1105) break anything if I incorporated it? Platform: HP NonStop S7000 series

...== NULL) + fatal("Couldn't allocate session state"); + active_state = ssh; /* XXX legacy API compat */ + if (ssh_packet_set_connection(ssh, sock_in, sock_out) != NULL) + fatal("ssh_packet_set_connection failed"); packet_set_server(); - ssh = active_state; /* XXX */ check_ip_options(ssh); -- 1.9.5 (Apple Git-50.3)+GitX

...ipal(authctxt->krb5_ctx, localname, NULL , KRB5_NT_SRV_HST, &server); if (problem) goto err; -------------- next part -------------- *** canohost.c.orig Mon May 20 11:54:18 2002 --- canohost.c Mon May 20 11:59:56 2002 *************** *** 22,27 **** --- 22,100 ---- static void check_ip_options(int, char *); /* + * Return the canonical name of the localhost of the socket. The + * caller should free the returned string with xfree. + */ + + const char * + get_local_hostname(int socket) + { + struct sockaddr_storage addr_6or4; + int i; + socklen_t addr_6o...

...ints, &aitop) != 0) { log("reverse mapping checking getaddrinfo for %.700s failed - POSSIBLE BREAKIN ATTEMPT!", name); - strlcpy(name, ntop, sizeof name); + strlcpy(name, ntop, name_size); goto check_ip_options; } /* Look for the address from the list of addresses. */ @@ -113,13 +125,13 @@ /* Address not found for the host name. */ log("Address %.100s maps to %.600s, but this does not map back to the address - POSSIBL...

...xes Found a really old redhat CD and installed it on my test machine.... # uname -r 1.2.13 # rpm -q libc libc-5.2.18-1 The patch changes: session.c: only does session_break_req if TIOCSBRK is defined. bsd-misc.h: adds CMSG_DATA and CMSG_FIRSTHDR macros (stolen from OpenBSD). canohost.c: only does check_ip_options if IP_OPTIONS is defined. Everything appears to work OK apart from PrivSep (because mmap seems terminally broken). With a newer kernel with a working mmap, PrivSep might even work. Anyone complaining about older systems is on their own :-). Anything objectionable in this patch? ------- Y...

...216): undefined reference to `howmany' /openssh/openssh-2.9p2/packet.c(1220): undefined reference to `howmany' ./libssh.a(channels.o): In function `channel_prepare_select': /openssh/openssh-2.9p2/channels.c(1171): undefined reference to `howmany' ./libssh.a(canohost.o): In function `check_ip_options': /openssh/openssh-2.9p2/canohost.c(152): undefined reference to `getprotobynamopenbsd-compat//libopenbsd-compat.a(fake-getaddrinfo.o): In function `getaddri': /openssh/openssh-2.9p2/openbsd-compat/fake-getaddrinfo.c(99): undefined refere to `gethostbyname' openbsd-compat//libopenbs...

...; } +#ifdef HAVE_BLUETOOTH + if (from.ss_family == AF_BLUETOOTH) { + struct sockaddr_rc *from_rc = (void *)&from; + char ba[28]; + + sprintf(ba, "Bluetooth:"); + ba2str(&from_rc->rc_bdaddr, ba + 10); + return xstrdup(ba); + } +#endif if (from.ss_family == AF_INET) check_ip_options(sock, ntop); @@ -264,6 +279,16 @@ get_socket_address(int sock, int remote, return NULL; } +#ifdef HAVE_BLUETOOTH + if (addr.ss_family == AF_BLUETOOTH) { + struct sockaddr_rc *from_rc = (void *)&addr; + char ba[28]; + + sprintf(ba, "Bluetooth:"); + ba2str(&from_rc...

...c version used for linking auth.o: In function `allowed_user': /home/john/Downloads/openssh-6.6p1/auth.c:112: warning: Using 'getspnam' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking ./libssh.a(canohost.o): In function `check_ip_options': /home/john/Downloads/openssh-6.6p1/canohost.c:161: warning: Using 'getprotobyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

...linking servconf.o: In function `add_one_listen_addr': /builddir/build/BUILD/openssh-5.6p1/servconf.c:515: warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking ./libssh.a(canohost.o): In function `check_ip_options': /builddir/build/BUILD/openssh-5.6p1/canohost.c:168: warning: Using 'getprotobyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking openbsd-compat//libopenbsd-compat.a(xcrypt.o): In function `xcrypt': /builddir...

.../openssh-3.8p1/packet.c(858): undefined reference to `howmany' ./libssh.a(packet.o): In function `packet_write_wait': /openssh-3.8p1/packet.c(1371): undefined reference to `howmany' /openssh-3.8p1/packet.c(1375): undefined reference to `howmany' ./libssh.a(canohost.o): In function `check_ip_options': /openssh-3.8p1/canohost.c(150): undefined reference to `getprotobyname' openbsd-compat//libopenbsd-compat.a(fake-rfc2553.o): In function `ssh_getnameinfo': /openssh-3.8p1/openbsd-compat/fake-rfc2553.c(64): undefined reference to `gethostbyaddr' openbsd-compat//libopenbsd-compa...