search for: check_exit

Exit with an error if we would overwrite an existing libvirt domain. Fixes RHBZ#617110 --- lib/Sys/VirtV2V/Connection/LibVirt.pm | 4 ++++ lib/Sys/VirtV2V/Target/LibVirt.pm | 31 ++++++++++++++++++++++++++++++- lib/Sys/VirtV2V/Target/RHEV.pm | 11 +++++++++++ 3 files changed, 45 insertions(+), 1 deletions(-) diff --git a/lib/Sys/VirtV2V/Connection/LibVirt.pm

doing "make check" on flac-1.1.2, I get a segmentation fault ././test_metaflac.sh: line 51: 17370 Segmentation fault flac $* when running this portion of the test/test_metaflac.sh script: (set -x && run_metaflac --preserve-modtime --add-padding=12345 $flacfile) check_exit check_flac <---------------- where the segfault happens All other tests in 'make check' passed. I commented out this portion of the test script and got a failure in the next line. I also tried adding --dont-use-padding (since that was reported to be a previous workaroun...

Cleanup was not happening properly if a migration to RHEV was killed prematurely with a Ctrl-C. Firstly, the SIGINT and SIGQUIT handlers were not being registered early enough in virt-v2v.pl. Secondly, if Ctrl-C killed the guestfs qemu process first it would deliver a SIGPIPE to v2v, which caused an unclean shutdown without cleanup. Fixes RHBZ#596015 --- v2v/virt-v2v.pl | 17 ++++++++++++++---

....1.2, I get a segmentation fault > > ././test_metaflac.sh: line 51: 17370 Segmentation fault flac > $* > > when running this portion of the test/test_metaflac.sh script: > > (set -x && run_metaflac --preserve-modtime --add-padding=12345 > $flacfile) > check_exit > check_flac <---------------- where the segfault > happens > > All other tests in 'make check' passed. I commented out this portion > of the test script and got a failure in the next line. I also tried > adding --dont-use-padding (since that was repor...

...$now->mday(), $now->mon() + 1, $now->year() + 1900, - $now->hour(), $now->min(), $now->sec()); + my $vmcreation = _format_time(gmtime()); my $osuuid = Sys::VirtV2V::Target::RHEV::UUIDHelper::get_uuid(); @@ -651,6 +648,14 @@ EOF $nfs->check_exit(); } +sub _format_time +{ + my ($time) = @_; + return sprintf("%04d/%02d/%02d %02d:%02d:%02d", + $time->year() + 1900, $time->mon() + 1, $time->mday(), + $time->hour(), $time->min(), $time->sec()); +} + sub _disks { my...

...elf->{insize}; + $self->write("\0" x $pad) if ($pad); + # Close the writer pipe, which will cause the child to exit close($self->{writer}->{tochild}) or die("Error closing tochild pipe"); @@ -330,6 +348,7 @@ sub close $self->{writer}->check_exit(); delete($self->{writer}); + delete($self->{written}); } package Sys::VirtV2V::Target::RHEV; -- 1.7.0.1

...ause destructors to be called in the child. @@ -113,10 +121,28 @@ sub new return $self; } +sub values +{ + my $self = shift; + + my @values; + my $fromchild = $self->{fromchild}; + while(<$fromchild>) { + chomp; + push(@values, $_); + } + + $self->check_exit(); + return @values; +} + sub check_exit { my $self = shift; + # Make sure it's not waiting on more input + close($self->{tochild}); + my $ret = waitpid($self->{pid}, 0); # If the process terminated normally, check the exit status and stderr @@ -158,215 +184,...

Move all target-specific functionality into its own module in preparation for output to RHEV. --- MANIFEST | 1 + lib/Sys/VirtV2V/Connection.pm | 46 ++--- lib/Sys/VirtV2V/Converter.pm | 138 +------------ lib/Sys/VirtV2V/Target/LibVirt.pm | 419 +++++++++++++++++++++++++++++++++++++ lib/Sys/VirtV2V/Transfer/ESX.pm | 91 +++------ po/POTFILES.in

This will allow use of raw data from os description in addition to libvirt XML when writing guest output. --- lib/Sys/VirtV2V/Target/LibVirt.pm | 2 +- lib/Sys/VirtV2V/Target/RHEV.pm | 2 +- v2v/virt-v2v.pl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Sys/VirtV2V/Target/LibVirt.pm b/lib/Sys/VirtV2V/Target/LibVirt.pm index