search for: check_err

tl;dr ===== This patchset adds a single bit to the skb to indicate that a packet encountered a layer 2 miss in the bridge and extends flower to match on this metadata. This is required for non-DF (Designated Forwarder) filtering in EVPN multi-homing which prevents decapsulated BUM packets from being forwarded multiple times to the same multi-homed host. Background ========== In a typical EVPN

tl;dr ===== This patchset adds a single bit to the skb to indicate that a packet encountered a layer 2 miss in the bridge and extends flower to match on this metadata. This is required for non-DF (Designated Forwarder) filtering in EVPN multi-homing which prevents decapsulated BUM packets from being forwarded multiple times to the same multi-homed host. Background ========== In a typical EVPN

...t;> + $MZ $swp1 -c 1 -p 128 -t udp "sp=54321,dp=12345" \ >> + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q >> + tc_check_packets "dev $swp2 egress" 1 1 >> + check_fail $? "Dynamic FDB entry did not age out" > > Shouldn't this be check_err()? After the FDB entry was aged you want to > make sure that packets received via $swp1 with SMAC being $mac are no > longer forwarded by the bridge. I was thinking that check_fail() will pass when tc_check_packets() does not see any packets, thus the test passing here when no packets are fo...

...p 128 -t udp "sp=54321,dp=12345" \ > >> + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q > >> + tc_check_packets "dev $swp2 egress" 1 1 > >> + check_fail $? "Dynamic FDB entry did not age out" > > > > Shouldn't this be check_err()? After the FDB entry was aged you want to > > make sure that packets received via $swp1 with SMAC being $mac are no > > longer forwarded by the bridge. > > I was thinking that check_fail() will pass when tc_check_packets() does > not see any packets, thus the test passing he...

...45 action pass > + > + $MZ $swp1 -c 1 -p 128 -t udp "sp=54321,dp=12345" \ > + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q Packets should be injected via $h1, not $swp1. See other test cases in this file. > + tc_check_packets "dev $swp2 egress" 1 1 > + check_err $? "Packet not seen on egress after adding dynamic FDB" Does this actually work? The packet is transmitted via $swp1, I don't understand how it can arrive at the egress of $swp2. > + > + sleep $((LOW_AGEING_TIME / 100 + 10)) > + > + $MZ $swp1 -c 1 -p 128 -t udp "sp=...

...ilter add dev $swp2 egress protocol ip pref 1 handle 1 flower \ + dst_ip 192.0.2.2 ip_proto udp dst_port 12345 action pass + + $MZ $swp1 -c 1 -p 128 -t udp "sp=54321,dp=12345" \ + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q + tc_check_packets "dev $swp2 egress" 1 1 + check_err $? "Packet not seen on egress after adding dynamic FDB" + + sleep $((LOW_AGEING_TIME / 100 + 10)) + + $MZ $swp1 -c 1 -p 128 -t udp "sp=54321,dp=12345" \ + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q + tc_check_packets "dev $swp2 egress" 1 1 + check_fail $? &...

...p=54321,dp=12345" \ >> >> + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q >> >> + tc_check_packets "dev $swp2 egress" 1 1 >> >> + check_fail $? "Dynamic FDB entry did not age out" >> > >> > Shouldn't this be check_err()? After the FDB entry was aged you want to >> > make sure that packets received via $swp1 with SMAC being $mac are no >> > longer forwarded by the bridge. >> >> I was thinking that check_fail() will pass when tc_check_packets() does >> not see any packets, thus...

...e allocator bit is clear, this inode must be stale */ if (!set) { - mlog(0, "inode %llu suballoc bit is clear\n", blkno); + mlog(0, "inode %llu suballoc bit is clear\n", + (unsigned long long)blkno); status = -ESTALE; goto unlock_nfs_sync; } @@ -114,7 +115,7 @@ check_err: if (status < 0) { if (status == -ESTALE) { mlog(0, "stale inode ino: %llu generation: %u\n", - blkno, handle->ih_generation); + (unsigned long long)blkno, handle->ih_generation); } result = ERR_PTR(status); goto bail; @@ -129,8 +130,8 @@ check_err...

...e allocator bit is clear, this inode must be stale */ if (!set) { - mlog(0, "inode %llu suballoc bit is clear\n", blkno); + mlog(0, "inode %llu suballoc bit is clear\n", + (unsigned long long)blkno); status = -ESTALE; goto unlock_nfs_sync; } @@ -114,7 +115,7 @@ check_err: if (status < 0) { if (status == -ESTALE) { mlog(0, "stale inode ino: %llu generation: %u\n", - blkno, handle->ih_generation); + (unsigned long long)blkno, handle->ih_generation); } result = ERR_PTR(status); goto bail; @@ -129,8 +130,8 @@ check_err...

...2_ilookup(sb, blkno); + /* found in-memory inode, goes to check generation */ + if (inode) + goto check_gen; + + /* takes nfs_sync_lock in EX mode */ + status = ocfs2_nfs_sync_lock(osb, 1); + if (status < 0) { + mlog(ML_ERROR, "getting nfs sync lock(EX) failed %d\n", status); + goto check_err; + } + + status = ocfs2_test_inode_bit(osb, blkno, &set); + if (status < 0) { + if (status == -EINVAL) { + /* meta block never be re-allocated as data block. + * nfsd gives us wrong blkno */ + status = -EEXIST; + } else { + mlog(ML_ERROR, "test inode bit failed %d\n", st...

...2_ilookup(sb, blkno); + /* found in-memory inode, goes to check generation */ + if (inode) + goto check_gen; + + /* takes nfs_sync_lock in EX mode */ + status = ocfs2_nfs_sync_lock(osb, 1); + if (status < 0) { + mlog(ML_ERROR, "getting nfs sync lock(EX) failed %d\n", status); + goto check_err; } - inode = ocfs2_iget(OCFS2_SB(sb), handle->ih_blkno, 0, 0); + status = ocfs2_test_inode_bit(osb, blkno, &set); + if (status < 0) { + if (status == -EINVAL) { + /* meta block never be re-allocated as data block. + * nfs gives us wrong blkno, we return ESTALE though */ + mlog...

...p=54321,dp=12345" \ >> >> + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q >> >> + tc_check_packets "dev $swp2 egress" 1 1 >> >> + check_fail $? "Dynamic FDB entry did not age out" >> > >> > Shouldn't this be check_err()? After the FDB entry was aged you want to >> > make sure that packets received via $swp1 with SMAC being $mac are no >> > longer forwarded by the bridge. >> >> I was thinking that check_fail() will pass when tc_check_packets() does >> not see any packets, thus...

...2_ilookup(sb, blkno); + /* found in-memory inode, goes to check generation */ + if (inode) + goto check_gen; + + /* takes nfs_sync_lock in EX mode */ + status = ocfs2_nfs_sync_lock(osb, 1); + if (status < 0) { + mlog(ML_ERROR, "getting nfs sync lock(EX) failed %d\n", status); + goto check_err; + } + + status = ocfs2_test_inode_bit(osb, blkno, &set); + if (status < 0) { + if (status == -EINVAL) { + /* meta block never be re-allocated as data block. + * nfs gives us wrong blkno, we return ESTALE though */ + mlog(0, "test inode bit failed %d\n", status); + status...

...2_ilookup(sb, blkno); + /* found in-memory inode, goes to check generation */ + if (inode) + goto check_gen; + + /* takes nfs_sync_lock in EX mode */ + status = ocfs2_nfs_sync_lock(osb, 1); + if (status < 0) { + mlog(ML_ERROR, "getting nfs sync lock(EX) failed %d\n", status); + goto check_err; + } + + status = ocfs2_test_inode_bit(osb, blkno, &set); + if (status < 0) { + if (status == -EINVAL) { + /* meta block never be re-allocated as data block. + * nfs gives us wrong blkno, we return ESTALE though */ + mlog(0, "test inode bit failed %d\n", status); + status...

...2_ilookup(sb, blkno); + /* found in-memory inode, goes to check generation */ + if (inode) + goto check_gen; + + /* takes nfs_sync_lock in EX mode */ + status = ocfs2_nfs_sync_lock(osb, 1); + if (status < 0) { + mlog(ML_ERROR, "getting nfs sync lock(EX) failed %d\n", status); + goto check_err; } - inode = ocfs2_iget(OCFS2_SB(sb), handle->ih_blkno, 0, 0); + status = ocfs2_test_inode_bit(osb, blkno, &set); + if (status < 0) { + if (status == -EINVAL) { + /* meta block never be re-allocated as data block. + * nfs gives us wrong blkno, we return ESTALE though */ + mlog...

...> >> >> + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q > >> >> + tc_check_packets "dev $swp2 egress" 1 1 > >> >> + check_fail $? "Dynamic FDB entry did not age out" > >> > > >> > Shouldn't this be check_err()? After the FDB entry was aged you want to > >> > make sure that packets received via $swp1 with SMAC being $mac are no > >> > longer forwarded by the bridge. > >> > >> I was thinking that check_fail() will pass when tc_check_packets() does > >>...

...2_ilookup(sb, blkno); + /* found in-memory inode, goes to check generation */ + if (inode) + goto check_gen; + + /* takes nfs_sync_lock in EX mode */ + status = ocfs2_nfs_sync_lock(osb, 1); + if (status < 0) { + mlog(ML_ERROR, "getting nfs sync lock(EX) failed %d\n", status); + goto check_err; + } + + status = ocfs2_test_inode_bit(osb, blkno, &set); + if (status < 0) { + if (status == -EINVAL) { + /* meta block never be re-allocated as data block. + * nfs gives us wrong blkno, we return ESTALE though */ + mlog(0, "test inode bit failed %d\n", status); + status...

...2_ilookup(sb, blkno); + /* found in-memory inode, goes to check generation */ + if (inode) + goto check_gen; + + /* takes nfs_sync_lock in EX mode */ + status = ocfs2_nfs_sync_lock(osb, 1); + if (status < 0) { + mlog(ML_ERROR, "getting nfs sync lock(EX) failed %d\n", status); + goto check_err; } - inode = ocfs2_iget(OCFS2_SB(sb), handle->ih_blkno, 0, 0); + status = ocfs2_get_suballoc_slot_bit(osb, blkno, &suballoc_slot, + &suballoc_bit); + if (status < 0) { + if (status == -EINVAL) { + /* meta block never be re-allocated as data block. + * nfsd gives us...

Hi, The following patches comprise the bulk of Ocfs2 updates for the 2.6.30 merge window. Aside from larger, more involved fixes, we're adding the following features, which I will describe in the order their patches are mailed. Sunil's exported some more state to our debugfs files, and consolidated some other aspects of our debugfs infrastructure. This will further aid us in debugging