search for: check_data

Make the tests 'check_DATA' so they only get built when running the tests. This saves a couple of seconds on the build time. --- ocaml/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index e781363..a535b43 100644 --- a/ocaml/Makefile.am +++ b/o...

...-maintainer-clean-local: +# ‘make distclean’. +DISTCLEANFILES += keys.psk +distclean-local: distclean-local-tls +distclean-local-tls: rm -rf pki #---------------------------------------------------------------------- @@ -226,7 +228,7 @@ if HAVE_PLUGINS # Common data shared by multiple tests check_DATA += file-data -MAINTAINERCLEANFILES += file-data +CLEANFILES += file-data file-data: rm -f $@ $@-t for f in `$(SEQ) 1 512`; do echo -ne '\x01\x02\x03\x04\x05\x06\x07\x08'; done > $@-t @@ -286,7 +288,7 @@ endif HAVE_LIBGUESTFS # common disk image shared with several tests if HAVE_GU...

Hi, few miscellaneous fixes for nbdkit. Thanks, Pino Toscano (3): build: use AC_MSG_RESULT for $PERL_LDOPTS crypto: add missing '{' tests: fix generation of PKI test data configure.ac | 1 + src/crypto.c | 2 +- tests/Makefile.am | 10 +++++----- 3 files changed, 7 insertions(+), 6 deletions(-) -- 2.13.6

Hi, I've created a shared library from including this code (with g++ -I/usr/local/lib/R/include -I/usr/local/include -c Rtest.cpp; g++ -shared -L/usr/local/lib -o Rtest.so Rtest.cpp): void check_data (SEXP data) { int l=length (data); } But when I try to load it in R I get this error message: unable to load shared library ... ... undefined symbol: _Z9Rf_lengthP7SEXPREC How can I solve this problem? Philip

CentOS 6 has libguestfs-devel 1.20.11, which predates the support in guestfs_add_drive_opts() for requesting an nbd drive instead of a local file (annoyingly, guestfs documentation merely states the function was available since 0.3, without saying which later releases added new options); causing a compilation failure during 'make check'. Maybe the guestfs plugin should still be built,

...lass: %.java - $(JAVAC) $(JAVAC_FLAGS) -d . -classpath $(srcdir):. $< + $(guestfs_am_v_javac)$(JAVAC) $(JAVAC_FLAGS) -d . -classpath $(srcdir):. $< libguestfs-${VERSION}.jar: $(libguestfs_jar_class_files) $(JAR) cf $@ $^ @@ -140,9 +140,9 @@ TESTS_ENVIRONMENT = $(top_builddir)/run --test check_DATA = Bindtests.class $(java_tests:.java=.class) t/%.class: t/%.java libguestfs-$(VERSION).jar - $(JAVAC) $(JAVAC_FLAGS) -classpath libguestfs-$(VERSION).jar -d t $< + $(guestfs_am_v_javac)$(JAVAC) $(JAVAC_FLAGS) -classpath libguestfs-$(VERSION).jar -d t $< Bindtests.class: Bindtests.java l...

...TS += test-file test_file_SOURCES = test-file.c test.h test_file_CFLAGS = $(WARNINGS_CFLAGS) $(LIBGUESTFS_CFLAGS) @@ -241,8 +243,7 @@ test_file_LDADD = libtest.la $(LIBGUESTFS_LIBS) if HAVE_ZLIB if HAVE_GUESTFISH -check_PROGRAMS += test-gzip -TESTS += test-gzip +LIBGUESTFS_TESTS += test-gzip check_DATA += disk disk.gz MAINTAINERCLEANFILES += disk disk.gz @@ -263,24 +264,21 @@ endif HAVE_GUESTFISH endif HAVE_ZLIB # memory plugin test. -check_PROGRAMS += test-memory -TESTS += test-memory +LIBGUESTFS_TESTS += test-memory test_memory_SOURCES = test-memory.c test.h test_memory_CFLAGS = $(WARNI...

...ndex 9a42964..f2775bd 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -133,6 +133,11 @@ TESTS += test-exit-with-parent test_exit_with_parent_SOURCES = test-exit-with-parent.c test.h test_exit_with_parent_CFLAGS = $(WARNINGS_CFLAGS) $(LIBGUESTFS_CFLAGS) +# PKI files for the TLS tests. +check_DATA += pki/.stamp +pki/.stamp: $(srcdir)/make-pki.sh + $(srcdir)/make-pki.sh + # In-depth tests need libguestfs, since that is a convenient way to # drive qemu. @@ -177,11 +182,6 @@ test_oldstyle_SOURCES = test-oldstyle.c test.h test_oldstyle_CFLAGS = $(WARNINGS_CFLAGS) $(LIBGUESTFS_CFLAGS) test_...

...tin Kletzander. --- v2v/Makefile.am | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/v2v/Makefile.am b/v2v/Makefile.am index a96166e49..d8a7487f3 100644 --- a/v2v/Makefile.am +++ b/v2v/Makefile.am @@ -479,6 +479,7 @@ endif ENABLE_APPLIANCE # The VMDK file is used for some -i ova tests. check_DATA = windows.vmdk +if ENABLE_APPLIANCE windows.vmdk: ../test-data/phony-guests/windows.img rm -f $@ $@-t if [ -s $< ]; then \ @@ -487,6 +488,10 @@ windows.vmdk: ../test-data/phony-guests/windows.img else \ touch $@; \ fi +else +windows.vmdk: + touch $@ +endif DISTCLEANFILES += \...

..., 1 deletion(-) diff --git a/tests/data/Makefile.am b/tests/data/Makefile.am index 03315de..5aa3219 100644 --- a/tests/data/Makefile.am +++ b/tests/data/Makefile.am @@ -82,7 +82,7 @@ images_files_build = \ initrd-x86_64.img.gz \ test-grep.txt.gz -noinst_DATA = $(images_files_build) test.iso +check_DATA = $(images_files_build) test.iso CLEANFILES = $(images_files_build) test.iso

This has got to the stage where it actually works, both for running the tests in-tree and installed. The 'test-harness' script has become rather over-complex in the process however. Rich.

...t;> [] then List.hd tests.check_fast + else if tests.check_slow <> [] then List.hd tests.check_slow + else if tests.check_local_guests <> [] then + List.hd tests.check_local_guests + else ( + assert (tests.check_data <> []); + List.hd tests.check_data + ) in + basename = dir && is_file any_file + ) tests in + Dir (dir, tests) + with + Not_found -> + failwith (sprintf "current directory (%s) is not a libguestf...

...t;> [] then List.hd tests.check_fast + else if tests.check_slow <> [] then List.hd tests.check_slow + else if tests.check_local_guests <> [] then + List.hd tests.check_local_guests + else ( + assert (tests.check_data <> []); + List.hd tests.check_data + ) in + basename = Filename.basename dir && is_file any_file + ) tests in + Dir (dir, tests) + with + Not_found -> + failwith (sprintf "current directory (%s)...

...t;> [] then List.hd tests.check_fast + else if tests.check_slow <> [] then List.hd tests.check_slow + else if tests.check_local_guests <> [] then + List.hd tests.check_local_guests + else ( + assert (tests.check_data <> []); + List.hd tests.check_data + ) in + basename = Filename.basename dir && is_file any_file + ) tests in + Dir (dir, tests) + with + Not_found -> + failwith (sprintf "current directory (%s)...

There is a small test provided. I tested this a lot more locally and it seems pretty robust. Rich.

...ile.am b/tests/Makefile.am index 2b5737b8..77f21d79 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -557,23 +557,6 @@ EXTRA_DIST += test-floppy.sh TESTS += test-full.sh EXTRA_DIST += test-full.sh -# gzip plugin test. -if HAVE_MKE2FS_WITH_D -if HAVE_ZLIB -LIBGUESTFS_TESTS += test-gzip -check_DATA += disk.gz -CLEANFILES += disk.gz - -test_gzip_SOURCES = test-gzip.c test.h -test_gzip_CFLAGS = $(WARNINGS_CFLAGS) $(LIBGUESTFS_CFLAGS) -test_gzip_LDADD = libtest.la $(LIBGUESTFS_LIBS) - -disk.gz: disk - rm -f $@ - gzip -9 -c disk > $@ -endif HAVE_ZLIB -endif HAVE_MKE2FS_WITH_D - # info plugin...

...AX_PROC_NR b/src/MAX_PROC_NR index c92ddb6..658bd78 100644 --- a/src/MAX_PROC_NR +++ b/src/MAX_PROC_NR @@ -1 +1 @@ -458 +459 diff --git a/tests/daemon/Makefile.am b/tests/daemon/Makefile.am index bb380c5..329b00c 100644 --- a/tests/daemon/Makefile.am +++ b/tests/daemon/Makefile.am @@ -25,7 +25,8 @@ check_DATA = captive-daemon.pm TESTS = \ test-daemon-start.pl \ - test-btrfs.pl + test-btrfs.pl \ + test-expand-gpt.pl TESTS_ENVIRONMENT = $(top_builddir)/run --test $(VG) diff --git a/tests/daemon/test-expand-gpt.pl b/tests/daemon/test-expand-gpt.pl new file mode 100755 index 0000000..637b90e --- /dev...

Just a quick update, I''ve dropped the hashing stuff in favor of doing a memcmp in the kernel to make sure the data is still the same. The thing that takes a while is reading the data up from disk, so doing a memcmp of the entire buffer isn''t that big of a deal, not to mention there''s a possiblity for malicious users if there is a problem with the hashing algorithms we

These changes allow virt-v2v to be compiled against the build directory of a non-installed libguestfs. Note that some small changes are also required to common and virt-v2v itself. I will post those separately. Rich.

...od +/ocaml/guestfs /ocaml/guestfs-c-actions.c /ocaml/guestfs-c-errnos.c /ocaml/guestfs.ml diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index c85efee64..c02246270 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -197,4 +197,21 @@ install-data-hook: CLEANFILES += $(noinst_DATA) $(check_DATA) -endif +# This "tricks" ocamlfind into allowing us to compile other OCaml +# programs against a locally compiled copy of the libguestfs sources. +# ocamlfind needs to see a directory called ‘guestfs’ which contains +# ‘META’. The current directory is called ‘ocaml’, but if we make +#...