search for: channel_register_fd

I've been trying to cut down the size of openssh so I can run it on my Nokia 770. One thing which helps a fair amount (and will help even more when I get '-ffunction-sections -fdata-sections --gc-sections' working) is to have the option of compiling out privilege separation... Is it worth me tidying this up and trying to make it apply properly to the OpenBSD version? Does the openbsd

...05/11 20:30:25 + 20140317 - (djm) [sandbox-seccomp-filter.c] Soft-fail stat() syscalls. Add XXX to remind myself to add sandbox violation logging via the log socket. diff --git a/channels.c b/channels.c index 9efe89c..72f166d 100644 --- a/channels.c +++ b/channels.c @@ -265,8 +265,7 @@ channel_register_fds(Channel *c, int rfd, int wfd, int efd, } /* - * Allocate a new channel object and set its type and socket. This will cause - * remote_name to be freed. + * Allocate a new channel object and set its type and socket. */ Channel * channel_new(char *ctype, int type, int rfd, int wfd...

...attempt is not yet known. When TCP stack finaly decides then connection attempt has failed, it places the error into pending socket error, where it is later pulled up by select()/poll(). However OpenSSH does a bunch of other stuff between connect() and select(). In particular, it calls channels.c:channel_register_fds. And the Portable OpenSSH (not "pure" OpenSSH) invokes isatty() here. On Solaris, isatty() invokes underlaying ioctl() which gets and clears the pending socket error. Therefore on Solaris, there is a race condition when the following happens: - OpenSSH invokes connect() which returns EI...

...82/100 Dec 2 03:31:16 yoda sshd[8276]: debug3: channel 0: close_fds r -1 w -1 e -1 c -1 Dec 2 03:31:16 yoda sshd[8275]: debug1: parent Dec 2 03:31:16 yoda sshd[8275]: debug1: calling session_set_fds Dec 2 03:31:16 yoda sshd[8275]: debug1: channel_set_fds Dec 2 03:31:16 yoda sshd[8275]: debug1: channel_register_fds Dec 2 03:31:16 yoda sshd[8275]: debug2: fd 7 setting O_NONBLOCK Dec 2 03:31:16 yoda sshd[8275]: debug3: fd 7 is O_NONBLOCK Dec 2 03:31:16 yoda sshd[8275]: debug2: fd 9 setting O_NONBLOCK Dec 2 03:31:16 yoda sshd[8275]: debug1: calling session_set_fds done Dec 2 03:31:16 yoda sshd[8276]: debug...

...nnel %d: pre_rdynamic: need more", c->self); + /* need more */ + } else { + /* switch to the next state */ + struct channel_connect cctx; + int sock; + + sock = connect_to_helper(c->path, c->host_port, &cctx); + if (sock < 0) { + chan_mark_dead(c); + return; + } + + channel_register_fds(c, sock, sock, -1, 0, 1, 0); + c->connect_ctx = cctx; + + FD_SET(c->sock, writeset); + } +} + +static void +channel_post_rdynamic(Channel *c, fd_set *readset, fd_set *writeset) +{ + if (c->sock < 0) + return; + if (FD_ISSET(c->sock, writeset)) { + int err = 0; + socklen_t sz =...

https://bugzilla.mindrot.org/show_bug.cgi?id=1528 Summary: sshd hangs when pasting more than 2k of text Product: Portable OpenSSH Version: 5.1p1 Platform: Sparc OS/Version: Solaris Status: NEW Severity: normal Priority: P2 Component: sshd AssignedTo: unassigned-bugs at mindrot.org

...SD$ Index: channels.c =================================================================== RCS file: /cvs/src/usr.bin/ssh/channels.c,v retrieving revision 1.301 diff -u -p -r1.301 channels.c --- channels.c 11 Jan 2010 01:39:46 -0000 1.301 +++ channels.c 14 Jan 2010 03:07:48 -0000 @@ -235,7 +235,6 @@ channel_register_fds(Channel *c, int rfd c->rfd = rfd; c->wfd = wfd; c->sock = (rfd == wfd) ? rfd : -1; - c->ctl_fd = -1; /* XXX: set elsewhere */ c->efd = efd; c->extended_usage = extusage; @@ -323,6 +322,9 @@ channel_new(char *ctype, int type, int r c->output_filter = NULL; c-&gt...