search for: channel_input_data

Hi, protocolkeepalives sends ssh_msg_ignore, which the ssh2 server handles incorrectly (i.e. it produces some output to syslog, instead of ignoring the packet): Jul 9 11:58:07 ren sshd[16580]: error: Hm, dispatch protocol error: type 32 plen 4 This patch implements a highly advanced function to ignore these packets ;) Matthew -------------- next part -------------- An embedded and

...ror message is provided. [Note that client_process_output does provide an error message in a similar situation, but it wasn't used since I was using the 2.0 protocol.] Now, suppose this happens while data is still being sent from a command running on the SSH server. When the client gets into channel_input_data, it will notice that the output channel is no longer open, and simply return. This means it won't update c->local_window. It also won't call channel_handle_wfd, which would in any case return directly, which means that c->local_consumed won't be updated either. This means that...

...However, the server side continues to send data which the client now ignores. This causes the client to stop sending window updates to the server. If the server has a sufficient amount of data still to send it will exhaust its window and stalls indefinitely. The solution is to adjust the case in channel_input_data() in channels.c. When it tests c->ostate != CHAN_OUTPUT_OPEN, instead of just returning we 'fake' the consumption of the data by moving the packet_get_string() call to above the conditional and then subtracting data_len from c->local_window and adding data_len to c->local_consume...

...l_clear_permitted_opens(void); void channel_input_port_forward_request(int, int); int channel_connect_to(const char *, u_short); --- clientloop.c 28 Jan 2003 18:06:51 -0000 1.1.1.2 +++ clientloop.c 28 Jan 2003 19:06:35 -0000 1.3 @@ -1342,7 +1344,7 @@ dispatch_set(SSH_MSG_CHANNEL_DATA, &channel_input_data); dispatch_set(SSH_MSG_CHANNEL_OPEN_CONFIRMATION, &channel_input_open_confirmation); dispatch_set(SSH_MSG_CHANNEL_OPEN_FAILURE, &channel_input_open_failure); - dispatch_set(SSH_MSG_PORT_OPEN, &channel_input_port_open); + dispatch_set(SSH_MSG_PORT_OPEN, &channel_input_port_open_q...

When I encounter the problem with TCP port forwarding locking up, I'll see this on the client window (if I haven't invoked ssh with -q): chan_shutdown_read failed for #1/fd6: Transport endpoint is not connected chan_shutdown_read failed for #1/fd6: Transport endpoint is not connected This is with Blowfish encryption. I have to kill and restart the client when this happens. Phil

...,20 +1268,28 @@ client_init_dispatch_13(void) { dispatch_init(NULL); +#ifdef WITH_PROTO13 dispatch_set(SSH_MSG_CHANNEL_CLOSE, &channel_input_close); dispatch_set(SSH_MSG_CHANNEL_CLOSE_CONFIRMATION, &channel_input_close_confirmation); +#endif dispatch_set(SSH_MSG_CHANNEL_DATA, &channel_input_data); dispatch_set(SSH_MSG_CHANNEL_OPEN_CONFIRMATION, &channel_input_open_confirmation); dispatch_set(SSH_MSG_CHANNEL_OPEN_FAILURE, &channel_input_open_failure); +#ifdef WITH_TCPFWD dispatch_set(SSH_MSG_PORT_OPEN, &channel_input_port_open); +#endif dispatch_set(SSH_SMSG_EXITSTATUS,...

Hi, sorry if it is the wrong approuch to suggest improvments to OpenSSH, but here comes my suggestion: I recently stumbled upon the scponly shell which in it's chroot:ed form is an ideal solution when you want to share some files with people you trust more or less. The problem is, if you use the scponlyc as shell, port forwarding is still allowed. This can of course be dissallowed in

...INPUT_DRAINING && + c->type != SSH_CHANNEL_RDYNAMIC) continue; } else { - if (c->type != SSH_CHANNEL_OPEN) + if (c->type != SSH_CHANNEL_OPEN && + c->type != SSH_CHANNEL_RDYNAMIC) continue; } if (compat20 && @@ -2318,7 +2436,8 @@ channel_input_data(int type, u_int32_t seq, void *ctxt) /* Ignore any data for non-open channels (might happen on close) */ if (c->type != SSH_CHANNEL_OPEN && - c->type != SSH_CHANNEL_X11_OPEN) + c->type != SSH_CHANNEL_X11_OPEN && + c->type != SSH_CHANNEL_RDYNAMIC) return...

...TIVELY_PROHIBITED); - packet_put_cstring("bla bla"); + packet_put_cstring("bla bla"); /* TODO: Perhaps a little better + explanation */ packet_put_cstring(""); packet_send(); } @@ -1045,7 +1052,7 @@ dispatch_set(SSH_MSG_CHANNEL_DATA, &channel_input_data); dispatch_set(SSH_MSG_CHANNEL_OPEN_CONFIRMATION, &channel_input_open_confirmation); dispatch_set(SSH_MSG_CHANNEL_OPEN_FAILURE, &channel_input_open_failure); - dispatch_set(SSH_MSG_PORT_OPEN, &channel_input_port_open); + dispatch_set(SSH_MSG_PORT_OPEN, &client_channel_input_port...