search for: change_gid

hello- i am using rsync via ssh to maintain a copy of a few directories on a remote server, and am getting an error when rsync tries to chmod a certain file following it's transfer. there are a couple of cases in which this occurring - below is one example. local machine is debian testing - rsync version 2.6.3 protocol version 28 remote machine is macos x 10.3.7 - rsync version 2.6.2

...ding file list ... done chmod: b wrote 54 bytes read 20 bytes 49.33 bytes/sec total size is 0 speedup is 0.00 2. Patch --- rsync-2.6.2/rsync.c Tue Mar 23 11:16:15 2004 +++ rsync-2.6.2-new/rsync.c Wed Sep 15 01:35:16 2004 @@ -129,7 +129,6 @@ STRUCT_STAT st2; int change_uid, change_gid; - if (dry_run) return 0; if (!st) { if (link_stat(fname,&st2) != 0) { @@ -142,6 +141,10 @@ if (preserve_times && !S_ISLNK(st->st_mode) && cmp_modtime(st->st_mtime, file->modtime) != 0) { + if (dry_ru...

...ng pointer to incomplete type rsync.c:189: dereferencing pointer to incomplete type rsync.c:206: dereferencing pointer to incomplete type rsync.c:208: dereferencing pointer to incomplete type rsync.c:152: warning: `change_uid' might be used uninitialized in this function rsync.c:152: warning: `change_gid' might be used uninitialized in this function rsync.c: In function `finish_transfer': rsync.c:245: dereferencing pointer to incomplete type make: *** [rsync.o] Error 1 I really do not want to use an RPMs, I have searched but only found one person with the same problem - no answers, thou...

...ing pointer to incomplete type rsync.c:189: dereferencing pointer to incomplete type rsync.c:206: dereferencing pointer to incomplete type rsync.c:208: dereferencing pointer to incomplete type rsync.c:152: warning: `change_uid' might be used uninitialized in this function rsync.c:152: warning: `change_gid' might be used uninitialized in this function rsync.c: In function `finish_transfer': rsync.c:245: dereferencing pointer to incomplete type make: *** [rsync.o] Error 1 ================================ cut _____________________________________________________________________ ? ?? ?! ??? ?...

...> - rprintf(FERROR,"failed to set times on %s : %s\n", > - fname,strerror(errno)); > - return 0; > - } else { > - updated = 1; > - } > - } > - > change_uid = am_root && preserve_uid && st->st_uid != file->uid; > change_gid = preserve_gid && file->gid != (gid_t) -1 && \ > st->st_gid != file->gid; > --- 166,171 ---- > *************** > *** 215,220 **** > --- 205,233 ---- > } > #endif > > + /* If we don't have a symbolic link, then we have to see...

...ord (0x00000000) Jul 6 18:59:02 testvm login[1230]: pam_winbind(login:auth): user ‘domainuser' granted access Jul 6 18:59:02 testvm login[1230]: pam_winbind(login:account): user ‘domainuser' granted access Jul 6 18:59:02 testvm login[1230]: pam_mail(login:session): pam_modutil_drop_priv: change_gid failed: Success Jul 6 18:59:02 testvm login[1230]: pam_keyinit(login:session): Unable to change GID to 70005 temporarily Jul 6 18:59:02 testvm login[1230]: pam_unix(login:session): session opened for user domainuser by LOGIN(uid=0) Jul 6 18:59:02 testvm mkhomedir_helper: PAM unable to change per...

...incomplete type rsync.c:189: dereferencing pointer to incomplete type rsync.c:206: dereferencing pointer to incomplete type rsync.c:208: dereferencing pointer to incomplete type rsync.c:152: warning: `change_uid' might be used uninitialized in this function rsync.c:152: warning: `change_gid' might be used uninitialized in this function rsync.c: In function `finish_transfer': rsync.c:245: dereferencing pointer to incomplete type make: *** [rsync.o] Error 1 Some info about the build environment: uname -sr Linux 2.2.20 gcc --version egcs-2.91.66 ls -d /lib/libc*...

...ls_only); int lp_numservices(void); int lp_number(char *name); diff -ur rsync-2.5.5/rsync.c rsync-2.5.5-umask/rsync.c --- rsync-2.5.5/rsync.c Thu Dec 20 16:33:13 2001 +++ rsync-2.5.5-umask/rsync.c Sun Mar 2 22:26:40 2003 @@ -150,6 +150,8 @@ int updated = 0; STRUCT_STAT st2; int change_uid, change_gid; + extern int am_daemon; + extern int module_id; if (dry_run) return 0; @@ -203,9 +205,18 @@ #ifdef HAVE_CHMOD if (!S_ISLNK(st->st_mode)) { - if (st->st_mode != file->mode) { + mode_t mode = file->mode; /* file->mode shouldn't be modified */ + + if (am_daemon) { +...

As I reported a while back rsync doesn't handle metadata (permissions and ownership) in dryrun mode. I offered to make a patch and that offer still stands. I didn't have the time for it until now and want to pick it up again. I had some ugly hack back then but I want to redo it in a clean way. I would like some input on my thoughts. IMHO, it would be ideally if the check for dry_run

We use rsync to update an nfs server. After an update, we noticed that a large number of clients didn't see the updated data. It took me a while to be able to reliably reproduce this problem, but it happens on old and new versions of rysnc. It also happens across all the platforms we use here (sun/linux/netapp). This shows the problem: [Note my home directory is NFS mounted]

...inter to incomplete type ../rsync-2.5.2/rsync.c:206: dereferencing pointer to incomplete type ../rsync-2.5.2/rsync.c:208: dereferencing pointer to incomplete type ../rsync-2.5.2/rsync.c:152: warning: `change_uid' might be used uninitialized in this function ../rsync-2.5.2/rsync.c:152: warning: `change_gid' might be used uninitialized in this function ../rsync-2.5.2/rsync.c: In function `finish_transfer': ../rsync-2.5.2/rsync.c:245: dereferencing pointer to incomplete type make: *** [rsync.o] Error 1 rc=2

...ender; @@ -160,9 +161,11 @@ updated = 1; } - change_uid = am_root && preserve_uid && st->st_uid != file->uid; + change_uid = am_root && preserve_uid && st->st_uid != file->uid + && !(S_ISDIR(st->st_mode) && omit_dir_changes); change_gid = preserve_gid && file->gid != GID_NONE - && st->st_gid != file->gid; + && st->st_gid != file->gid + && !(S_ISDIR(st->st_mode) && omit_dir_changes); #if !defined HAVE_LCHOWN && !defined CHOWN_MODIFIES_SYMLINK if (S_ISLNK(st-&gt...

...p; !S_ISDIR(st->st_mode)) { rprintf(FERROR, "failed to set times on %s: %s\n", full_fname(fname), strerror(errno)); return 0; - } + } else { updated = 1; } + } change_uid = am_root && preserve_uid && st->st_uid != file->uid; change_gid = preserve_gid && file->gid != GID_NONE @@ -236,7 +251,7 @@ return; /* move tmp file over real file */ - ret = robust_rename(fnametmp, fname, file->mode & INITACCESSPERMS); + ret = robust_rename(fnametmp, fname, 0600); if (ret < 0) { rprintf(FERROR, "%s %s -&gt...

...%s", @@ -423,6 +472,9 @@ int set_file_attrs(const char *fname, st } } if (am_root >= 0) { +#ifdef SUPPORT_FLAGS + make_mutable(fname, sxp->st.st_mode, sxp->st.st_flags); +#endif if (do_lchown(fname, change_uid ? (uid_t)F_OWNER(file) : sxp->st.st_uid, change_gid ? (gid_t)F_GROUP(file) : sxp->st.st_gid) != 0) { @@ -457,7 +509,13 @@ int set_file_attrs(const char *fname, st #ifdef HAVE_CHMOD if (!BITS_EQUAL(sxp->st.st_mode, new_mode, CHMOD_BITS)) { - int ret = am_root < 0 ? 0 : do_chmod(fname, new_mode); + int ret = 0; + if (am_root >= 0)...