search for: cfgtrait

...irtual methods in a CfgInterface interface class. Please take a look at the following Phabricator reviews and related changes you can navigate to via the "Stack" tab: 1. https://reviews.llvm.org/D83088: Introduces the classes and templates that enable this new way of writing analyses (CfgTraits, CfgInterface, CfgInterfaceImpl<CfgTraitsT>, ...). 2. https://reviews.llvm.org/D83089: Refactors the dominator tree implementation so that algorithms that operate on CfgBlockRef will be able to use a standard dominator tree as input. The calculation of dominator trees remains unchanged...

...your proposal does type erasure at the bottom, while polymorphic iterators from the top. Alina should know this problem space best. Interesting! I'm not sure what those polymorphic iterators would look like. > I think that generic DomTree construction/updater could be rewritten to work on CfgTraits directly, while GraphDiff would provide CfgTraits directly usable by the updaters. Same with the generic IDF calculator. The biggest question for me here is how all of that would affect compilation times. What are your thoughts on more refactoring like this? How do you plan to evaluate compilation...

...nt coding style advises not to duplicate. This link may be helpful: <http://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments>. +#ifndef _AMDIL7XXDEVICEIMPL_H_ +#define _AMDIL7XXDEVICEIMPL_H_ Identifiers starting with underscore and a capital letter are reserved. + CFGTraits::insertCondBranchBefore(branchInstrPos, + CFGTraits::getBranchNzeroOpcode(oldOpcode), + passRep, +»······»·······»·······»·······»·······»·······»·······»·······»·······branchDL); No tabs, please. +AMDGPUCFGStructurizer::AMDGP...

...t; This link may be helpful: > <http://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments>. > > +#ifndef _AMDIL7XXDEVICEIMPL_H_ > +#define _AMDIL7XXDEVICEIMPL_H_ > > Identifiers starting with underscore and a capital letter are reserved. > > + CFGTraits::insertCondBranchBefore(branchInstrPos, > + CFGTraits::getBranchNzeroOpcode(oldOpcode), > + passRep, > +»······»·······»·······»·······»·······»·······»·······»·······»·······branchDL); > > No tabs, please. >...

On Sat, Nov 17, 2012 at 10:56:26PM +0100, Benjamin Kramer wrote: > > On 01.11.2012, at 14:44, Tom Stellard <tom at stellard.net> wrote: > > > Moving this thread to llvmdev. > > > > On Tue, Oct 30, 2012 at 11:09:34PM -0700, Chris Lattner wrote: > >> On Oct 30, 2012, at 11:35 AM, Tom Stellard <tom at stellard.net> wrote: > >>>> Hi

...Traits; > + typedef GraphTraits<Inverse<BlockT *> > InvBlockGTraits; > + //typedef BlockGTraits::succ_iterator InstructionIterator; > + typedef typename BlockT::iterator InstrIterator; > + > + typedef CFGStructTraits<PassT> CFGTraits; > + typedef BlockInformation<InstrT> BlockInfo; > + typedef std::map<BlockT *, BlockInfo *> BlockInfoMap; > + > + typedef int RegiT; > + typedef typename PassT::LoopType LoopT; > + typedef...