Displaying 3 results from an estimated 3 matches for "cf8f5246".
2019 Oct 04
1
Re: [nbdkit PATCH 2/5] retry: Check size before transactions
...e plugins and document those assumptions, but as
you've written the code now let's go with this.
Rich.
> filters/retry/retry.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/filters/retry/retry.c b/filters/retry/retry.c
> index 840d7383..cf8f5246 100644
> --- a/filters/retry/retry.c
> +++ b/filters/retry/retry.c
> @@ -148,6 +148,17 @@ struct retry_data {
> int delay; /* Seconds to wait before retrying. */
> };
>
> +static bool
> +valid_range (struct nbdkit_next_ops *next_ops, void *nxdata,
>...
2019 Oct 04
0
[nbdkit PATCH 2/5] retry: Check size before transactions
...support,
we'll get to revisit how the retry filter fits in).
Fixes: f0f0ec49
Signed-off-by: Eric Blake <eblake@redhat.com>
---
filters/retry/retry.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/filters/retry/retry.c b/filters/retry/retry.c
index 840d7383..cf8f5246 100644
--- a/filters/retry/retry.c
+++ b/filters/retry/retry.c
@@ -148,6 +148,17 @@ struct retry_data {
int delay; /* Seconds to wait before retrying. */
};
+static bool
+valid_range (struct nbdkit_next_ops *next_ops, void *nxdata,
+ uint32_t count, uint64_t offs...
2019 Oct 04
6
[nbdkit PATCH 0/5] Another round of retry fixes
I still don't have .prepare/.finalize working cleanly across reopen,
but did find a nasty bug where a botched assertion means we failed to
notice reads beyond EOF in both the xz and retry filter.
Refactoring backend.c will make .finalize work easier.
Eric Blake (5):
xz: Avoid reading beyond EOF
retry: Check size before transactions
tests: Test retry when get_size values change