search for: celt_lpc_sse

Hi all, This is Linfeng Zhang from Google. I'll work on ARM NEON optimization in the next few months. I'm submitting 2 patches in the following couple of emails, which have the new created celt_fir_neon(). I revised celt_fir_c() to not pass in argument "mem" in Patch 1. If there are concerns to this change, please let me know. Many thanks to your comments. Linfeng Zhang

...| 4 +- celt/pitch.h | 19 +- celt/tests/test_unit_dft.c | 4 +- celt/tests/test_unit_mathops.c | 11 +- celt/tests/test_unit_mdct.c | 4 +- celt/tests/test_unit_rotation.c | 11 +- celt/x86/celt_lpc_sse.c | 4 + celt/x86/celt_lpc_sse.h | 12 +- celt/x86/pitch_sse.c | 334 +++++++++++++------------------ celt/x86/pitch_sse.h | 256 ++++++++++------------- celt/x86/pitch_sse2.c | 95 +++++++++ celt/x86/p...

...| 4 +- celt/pitch.h | 19 +- celt/tests/test_unit_dft.c | 4 +- celt/tests/test_unit_mathops.c | 11 +- celt/tests/test_unit_mdct.c | 4 +- celt/tests/test_unit_rotation.c | 11 +- celt/x86/celt_lpc_sse.c | 4 + celt/x86/celt_lpc_sse.h | 12 +- celt/x86/pitch_sse.c | 334 +++++++++++++------------------ celt/x86/pitch_sse.h | 256 ++++++++++------------- celt/x86/pitch_sse2.c | 95 +++++++++ celt/x86/p...

...rmcpu.c" # include "celt_lpc.c" # include "pitch.c" diff --git a/celt/tests/test_unit_mathops.c b/celt/tests/test_unit_mathops.c index 5b446b7..fd3319d 100644 --- a/celt/tests/test_unit_mathops.c +++ b/celt/tests/test_unit_mathops.c @@ -63,8 +63,7 @@ # include "x86/celt_lpc_sse.c" # endif # include "x86/x86_celt_map.c" -#elif defined(OPUS_HAVE_RTCD) && \ - (defined(OPUS_ARM_ASM) || defined(OPUS_ARM_MAY_HAVE_NEON_INTR)) +#elif defined(OPUS_ARM_ASM) || defined(OPUS_ARM_MAY_HAVE_NEON_INTR) # include "arm/armcpu.c" # if defined(OPU...

...rmcpu.c" # include "celt_lpc.c" # include "pitch.c" diff --git a/celt/tests/test_unit_mathops.c b/celt/tests/test_unit_mathops.c index 5b446b7..fd3319d 100644 --- a/celt/tests/test_unit_mathops.c +++ b/celt/tests/test_unit_mathops.c @@ -63,8 +63,7 @@ # include "x86/celt_lpc_sse.c" # endif # include "x86/x86_celt_map.c" -#elif defined(OPUS_HAVE_RTCD) && \ - (defined(OPUS_ARM_ASM) || defined(OPUS_ARM_MAY_HAVE_NEON_INTR)) +#elif defined(OPUS_ARM_ASM) || defined(OPUS_ARM_MAY_HAVE_NEON_INTR) # include "arm/armcpu.c" # if defined(OPU...

...t.h | 14 +- celt/mips/celt_mipsr1.h | 2 +- celt/pitch.c | 4 +- celt/pitch.h | 19 +- celt/tests/test_unit_mathops.c | 9 +- celt/tests/test_unit_rotation.c | 9 +- celt/x86/celt_lpc_sse.c | 4 + celt/x86/celt_lpc_sse.h | 12 +- celt/x86/pitch_sse.c | 334 +++++++++++++------------------ celt/x86/pitch_sse.h | 261 ++++++++++-------------- celt/x86/pitch_sse2.c | 95 +++++++++ celt/x86/...

Fixes build failure on platforms with MAY_HAVE_SSE4_1 (but not PRESUME_SSE4_1) with --enable-intrinsics. --- silk/fixed/main_FIX.h | 11 +++++++++++ silk/x86/x86_silk_map.c | 2 ++ 2 files changed, 13 insertions(+) diff --git a/silk/fixed/main_FIX.h b/silk/fixed/main_FIX.h index ffeb4f3..375b5eb 100644 --- a/silk/fixed/main_FIX.h +++ b/silk/fixed/main_FIX.h @@ -97,6 +97,17 @@ void

Fixes build failure on platforms with MAY_HAVE_SSE4_1 (but not PRESUME_SSE4_1) with --enable-intrinsics. --- silk/fixed/main_FIX.h | 11 +++++++++++ silk/x86/x86_silk_map.c | 2 ++ 2 files changed, 13 insertions(+) diff --git a/silk/fixed/main_FIX.h b/silk/fixed/main_FIX.h index ffeb4f3..375b5eb 100644 --- a/silk/fixed/main_FIX.h +++ b/silk/fixed/main_FIX.h @@ -97,6 +97,17 @@ void

...tions(+) diff --git a/win32/VS2015/opus.vcxproj b/win32/VS2015/opus.vcxproj index d9aaa03..f55ea37 100644 --- a/win32/VS2015/opus.vcxproj +++ b/win32/VS2015/opus.vcxproj @@ -852,6 +852,7 @@ <ClInclude Include="..\..\celt\vq.h" /> <ClInclude Include="..\..\celt\x86\celt_lpc_sse.h" /> <ClInclude Include="..\..\celt\x86\pitch_sse.h" /> + <ClInclude Include="..\..\celt\x86\vq_sse.h" /> <ClInclude Include="..\..\celt\x86\x86cpu.h" /> <ClInclude Include="..\..\celt\_kiss_fft_guts.h" />...

The attached patch cleans up Opus's x86 intrinsics configury. It: * Makes ?enable-intrinsics work with clang and other non-GCC compilers * Enables RTCD for the floating-point-mode SSE code in Celt. * Disables use of RTCD in cases where the compiler targets an instruction set by default. * Enables the SSE4.1 Silk optimizations that apply to the common parts of Silk when Opus is built in

...quot;arm/armcpu.c" #if !defined(FIXED_POINT) #if defined(HAVE_ARM_NE10) diff --git a/celt/tests/test_unit_mathops.c b/celt/tests/test_unit_mathops.c index a1cf2f7..2e43e07 100644 --- a/celt/tests/test_unit_mathops.c +++ b/celt/tests/test_unit_mathops.c @@ -65,17 +65,18 @@ #include "x86/celt_lpc_sse.c" #endif #include "x86/x86_celt_map.c" + #elif ((defined(OPUS_ARM_ASM) && defined(FIXED_POINT)) \ - || defined(OPUS_ARM_NEON_INTR)) -#if defined(OPUS_ARM_NEON_INTR) + || defined(OPUS_ARM_MAY_HAVE_NEON_INTR)) +#if defined(OPUS_ARM_MAY_HAVE_NEON_INTR) #include...

...elt/static_modes_float_arm_ne10.h | 404 +++++++++++++++++++++++++++++++ celt/tests/test_unit_dft.c | 55 +++-- celt/tests/test_unit_mathops.c | 21 +- celt/tests/test_unit_mdct.c | 85 ++++--- celt/tests/test_unit_rotation.c | 21 +- celt/x86/celt_lpc_sse.c | 4 + celt/x86/celt_lpc_sse.h | 12 +- celt/x86/pitch_sse.c | 334 ++++++++++--------------- celt/x86/pitch_sse.h | 256 ++++++++------------ celt/x86/pitch_sse2.c | 95 ++++++++ celt/x86/pitch_sse4_...

...elt/static_modes_float_arm_ne10.h | 404 +++++++++++++++++++++++++++++++ celt/tests/test_unit_dft.c | 56 +++-- celt/tests/test_unit_mathops.c | 22 +- celt/tests/test_unit_mdct.c | 88 ++++--- celt/tests/test_unit_rotation.c | 22 +- celt/x86/celt_lpc_sse.c | 4 + celt/x86/celt_lpc_sse.h | 12 +- celt/x86/pitch_sse.c | 334 ++++++++++--------------- celt/x86/pitch_sse.h | 256 ++++++++------------ celt/x86/pitch_sse2.c | 95 ++++++++ celt/x86/pitch_sse4_...

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi Jesus, Thanks for the report. As far as I can tell, what's happening is that when intrinsics are enabled, we compile all tests with -msse4.1, even when it's only run-time detected. In most cases, that doesn't cause any issue, but sometimes the compiler will take the C code and generate an SSEx instruction on its own. I think this is

HI trying to build libopus beta compiler complains about more fixed point specific names referenced in common unconditional code Particularly: ./celt/x86/celt_lpc_sse.c(100): error: identifier "SIG_SHIFT" is undefined noA = EXTEND32(1) << SIG_SHIFT >> 1; ^ SIG_SHIFT is defined in arch.h provided FIXED_POINT is used (not on floating point build) and silk/x86/x86_silk_map.c unconditionally references alot nam...

...;. It should rebuild file "celt/tests/test_unit_mathops". 6. Error: """ # make make all-recursive make[1]: Entering directory `/tmp/opus-1.1.1' make[2]: Entering directory `/tmp/opus-1.1.1' CC celt/tests/test_unit_mathops.o In file included from ./celt/x86/celt_lpc_sse.c:34:0, from celt/tests/test_unit_mathops.c:63: /usr/lib/gcc/x86_64-linux-gnu/4.8/include/smmintrin.h:31:3: error: #error "SSE4.1 instruction set not enabled" # error "SSE4.1 instruction set not enabled" ^ make[2]: *** [celt/tests/test_unit_mathops.o] Error...

...rch) \ ((void)(arch),celt_pitch_xcorr_c(_x, _y, xcorr, len, max_pitch, arch)) diff --git a/celt/tests/test_unit_mathops.c b/celt/tests/test_unit_mathops.c index 3076bbf..cdb2939 100644 --- a/celt/tests/test_unit_mathops.c +++ b/celt/tests/test_unit_mathops.c @@ -56,7 +56,7 @@ #include "x86/celt_lpc_sse.c" #endif #include "x86/x86_celt_map.c" -#elif defined(OPUS_ARM_ASM) && defined(FIXED_POINT) +#elif defined(OPUS_ARM_ASM) #include "arm/arm_celt_map.c" #endif diff --git a/celt/tests/test_unit_rotation.c b/celt/tests/test_unit_rotation.c index 37ba74e..906fa7e...

Hi, Optimizes celt_pitch_xcorr for ARM NEON floating point. Changes from RFCv3: - celt_neon_intr.c - removed warnings due to not having constant pointers - Put simpler loop to take care of corner cases. Unrolling using intrinsics was not really mapping well to what was done in celt_pitch_xcorr_arm.s - Makefile.am Removed explicit -O3 optimization - test_unit_mathops.c,

...elt/static_modes_float_arm_ne10.h | 404 +++++++++++++++++++++++++++++++ celt/tests/test_unit_dft.c | 62 +++-- celt/tests/test_unit_mathops.c | 22 +- celt/tests/test_unit_mdct.c | 88 ++++--- celt/tests/test_unit_rotation.c | 22 +- celt/x86/celt_lpc_sse.c | 4 + celt/x86/celt_lpc_sse.h | 12 +- celt/x86/pitch_sse.c | 334 ++++++++++--------------- celt/x86/pitch_sse.h | 256 ++++++++------------ celt/x86/pitch_sse2.c | 95 ++++++++ celt/x86/pitch_sse4_...

...elt/static_modes_float_arm_ne10.h | 404 +++++++++++++++++++++++++++++++ celt/tests/test_unit_dft.c | 62 +++-- celt/tests/test_unit_mathops.c | 22 +- celt/tests/test_unit_mdct.c | 88 ++++--- celt/tests/test_unit_rotation.c | 22 +- celt/x86/celt_lpc_sse.c | 4 + celt/x86/celt_lpc_sse.h | 12 +- celt/x86/pitch_sse.c | 334 ++++++++++--------------- celt/x86/pitch_sse.h | 256 ++++++++------------ celt/x86/pitch_sse2.c | 95 ++++++++ celt/x86/pitch_sse4_...