search for: ccw_cmd_set_ind

...; +??????? indicatorp = kmalloc(sizeof(indicators(vcdev)), >>>> ?????????????????????? GFP_DMA | GFP_KERNEL); >>>> ????????? if (!indicatorp) >>>> ????????????? return; >>>> ????????? *indicatorp = 0; >>>> ????????? ccw->cmd_code = CCW_CMD_SET_IND; >>>> -??????? ccw->count = sizeof(&vcdev->indicators); >>>> +??????? ccw->count = sizeof(indicators(vcdev)); >>> >>> This looks strange to me. Was already weird before. >>> Lucky we are indicators are long... >>> may be just...

...; +??????? indicatorp = kmalloc(sizeof(indicators(vcdev)), >>>> ?????????????????????? GFP_DMA | GFP_KERNEL); >>>> ????????? if (!indicatorp) >>>> ????????????? return; >>>> ????????? *indicatorp = 0; >>>> ????????? ccw->cmd_code = CCW_CMD_SET_IND; >>>> -??????? ccw->count = sizeof(&vcdev->indicators); >>>> +??????? ccw->count = sizeof(indicators(vcdev)); >>> >>> This looks strange to me. Was already weird before. >>> Lucky we are indicators are long... >>> may be just...

...ayload is the address of the indicators */ > - indicatorp = kmalloc(sizeof(&vcdev->indicators), > + indicatorp = kmalloc(sizeof(indicators(vcdev)), > GFP_DMA | GFP_KERNEL); > if (!indicatorp) > return; > *indicatorp = 0; > ccw->cmd_code = CCW_CMD_SET_IND; > - ccw->count = sizeof(&vcdev->indicators); > + ccw->count = sizeof(indicators(vcdev)); This looks strange to me. Was already weird before. Lucky we are indicators are long... may be just sizeof(long) > ccw->cda = (__u32)(unsigned long) indicatorp; > } >...

...ayload is the address of the indicators */ > - indicatorp = kmalloc(sizeof(&vcdev->indicators), > + indicatorp = kmalloc(sizeof(indicators(vcdev)), > GFP_DMA | GFP_KERNEL); > if (!indicatorp) > return; > *indicatorp = 0; > ccw->cmd_code = CCW_CMD_SET_IND; > - ccw->count = sizeof(&vcdev->indicators); > + ccw->count = sizeof(indicators(vcdev)); This looks strange to me. Was already weird before. Lucky we are indicators are long... may be just sizeof(long) > ccw->cda = (__u32)(unsigned long) indicatorp; > } >...

...tors(vcdev)), >>>>>> ?????????????????????? GFP_DMA | GFP_KERNEL); >>>>>> ????????? if (!indicatorp) >>>>>> ????????????? return; >>>>>> ????????? *indicatorp = 0; >>>>>> ????????? ccw->cmd_code = CCW_CMD_SET_IND; >>>>>> -??????? ccw->count = sizeof(&vcdev->indicators); >>>>>> +??????? ccw->count = sizeof(indicators(vcdev)); >>>>> >>>>> This looks strange to me. Was already weird before. >>>>> Lucky we are indicato...

...tors(vcdev)), >>>>>> ?????????????????????? GFP_DMA | GFP_KERNEL); >>>>>> ????????? if (!indicatorp) >>>>>> ????????????? return; >>>>>> ????????? *indicatorp = 0; >>>>>> ????????? ccw->cmd_code = CCW_CMD_SET_IND; >>>>>> -??????? ccw->count = sizeof(&vcdev->indicators); >>>>>> +??????? ccw->count = sizeof(indicators(vcdev)); >>>>> >>>>> This looks strange to me. Was already weird before. >>>>> Lucky we are indicato...

...oc(sizeof(&vcdev->indicators), >> +??????? indicatorp = kmalloc(sizeof(indicators(vcdev)), >> ?????????????????????? GFP_DMA | GFP_KERNEL); >> ????????? if (!indicatorp) >> ????????????? return; >> ????????? *indicatorp = 0; >> ????????? ccw->cmd_code = CCW_CMD_SET_IND; >> -??????? ccw->count = sizeof(&vcdev->indicators); >> +??????? ccw->count = sizeof(indicators(vcdev)); > > This looks strange to me. Was already weird before. > Lucky we are indicators are long... > may be just sizeof(long) AFAIK the size of the indicators...

.../* payload is the address of the indicators */ > - indicatorp = kmalloc(sizeof(&vcdev->indicators), > + indicatorp = kmalloc(sizeof(indicators(vcdev)), > GFP_DMA | GFP_KERNEL); > if (!indicatorp) > return; > *indicatorp = 0; > ccw->cmd_code = CCW_CMD_SET_IND; > - ccw->count = sizeof(&vcdev->indicators); > + ccw->count = sizeof(indicators(vcdev)); > ccw->cda = (__u32)(unsigned long) indicatorp; > } > /* Deregister indicators from host. */ > - vcdev->indicators = 0; > + *indicators(vcdev) = 0; I'm not...

.../* payload is the address of the indicators */ > - indicatorp = kmalloc(sizeof(&vcdev->indicators), > + indicatorp = kmalloc(sizeof(indicators(vcdev)), > GFP_DMA | GFP_KERNEL); > if (!indicatorp) > return; > *indicatorp = 0; > ccw->cmd_code = CCW_CMD_SET_IND; > - ccw->count = sizeof(&vcdev->indicators); > + ccw->count = sizeof(indicators(vcdev)); > ccw->cda = (__u32)(unsigned long) indicatorp; > } > /* Deregister indicators from host. */ > - vcdev->indicators = 0; > + *indicators(vcdev) = 0; I'm not...

Hi, here's the guest driver support for adapter interrupts in virtio-ccw. We use one summary indicator per page of indicators. For each device, we try to find a space in an indicator where all of its virtqueues fit. Locking probably needs some more love, but it seems to work fine so far. Cornelia Huck (2): KVM: s390: virtio-ccw: Handle command rejects. KVM: s390: virtio-ccw adapter

Hi, here's the guest driver support for adapter interrupts in virtio-ccw. We use one summary indicator per page of indicators. For each device, we try to find a space in an indicator where all of its virtqueues fit. Locking probably needs some more love, but it seems to work fine so far. Cornelia Huck (2): KVM: s390: virtio-ccw: Handle command rejects. KVM: s390: virtio-ccw adapter

...d long) thinint_area; } else { /* payload is the address of the indicators */ - indicatorp = kmalloc(sizeof(&vcdev->indicators), + indicatorp = kmalloc(sizeof(indicators(vcdev)), GFP_DMA | GFP_KERNEL); if (!indicatorp) return; *indicatorp = 0; ccw->cmd_code = CCW_CMD_SET_IND; - ccw->count = sizeof(&vcdev->indicators); + ccw->count = sizeof(indicators(vcdev)); ccw->cda = (__u32)(unsigned long) indicatorp; } /* Deregister indicators from host. */ - vcdev->indicators = 0; + *indicators(vcdev) = 0; ccw->flags = 0; ret = ccw_io_helper(vcde...

...malloc(sizeof(indicators(vcdev)), > >>>> ?????????????????????? GFP_DMA | GFP_KERNEL); > >>>> ????????? if (!indicatorp) > >>>> ????????????? return; > >>>> ????????? *indicatorp = 0; > >>>> ????????? ccw->cmd_code = CCW_CMD_SET_IND; > >>>> -??????? ccw->count = sizeof(&vcdev->indicators); > >>>> +??????? ccw->count = sizeof(indicators(vcdev)); > >>> > >>> This looks strange to me. Was already weird before. > >>> Lucky we are indicators are long......

...d long) thinint_area; } else { /* payload is the address of the indicators */ - indicatorp = kmalloc(sizeof(&vcdev->indicators), + indicatorp = kmalloc(sizeof(indicators(vcdev)), GFP_DMA | GFP_KERNEL); if (!indicatorp) return; *indicatorp = 0; ccw->cmd_code = CCW_CMD_SET_IND; - ccw->count = sizeof(&vcdev->indicators); + ccw->count = sizeof(indicators(vcdev)); ccw->cda = (__u32)(unsigned long) indicatorp; } /* Deregister indicators from host. */ - vcdev->indicators = 0; + *indicators(vcdev) = 0; ccw->flags = 0; ret = ccw_io_helper(vcde...

...d long) thinint_area; } else { /* payload is the address of the indicators */ - indicatorp = kmalloc(sizeof(&vcdev->indicators), + indicatorp = kmalloc(sizeof(indicators(vcdev)), GFP_DMA | GFP_KERNEL); if (!indicatorp) return; *indicatorp = 0; ccw->cmd_code = CCW_CMD_SET_IND; - ccw->count = sizeof(&vcdev->indicators); + ccw->count = sizeof(indicators(vcdev)); ccw->cda = (__u32)(unsigned long) indicatorp; } /* Deregister indicators from host. */ - vcdev->indicators = 0; + *indicators(vcdev) = 0; ccw->flags = 0; ret = ccw_io_helper(vcde...

...d long) thinint_area; } else { /* payload is the address of the indicators */ - indicatorp = kmalloc(sizeof(&vcdev->indicators), + indicatorp = kmalloc(sizeof(indicators(vcdev)), GFP_DMA | GFP_KERNEL); if (!indicatorp) return; *indicatorp = 0; ccw->cmd_code = CCW_CMD_SET_IND; - ccw->count = sizeof(&vcdev->indicators); + ccw->count = sizeof(indicators(vcdev)); ccw->cda = (__u32)(unsigned long) indicatorp; } /* Deregister indicators from host. */ - vcdev->indicators = 0; + *indicators(vcdev) = 0; ccw->flags = 0; ret = ccw_io_helper(vcde...

...ators), > >> +??????? indicatorp = kmalloc(sizeof(indicators(vcdev)), > >> ?????????????????????? GFP_DMA | GFP_KERNEL); > >> ????????? if (!indicatorp) > >> ????????????? return; > >> ????????? *indicatorp = 0; > >> ????????? ccw->cmd_code = CCW_CMD_SET_IND; > >> -??????? ccw->count = sizeof(&vcdev->indicators); > >> +??????? ccw->count = sizeof(indicators(vcdev)); > > > > This looks strange to me. Was already weird before. > > Lucky we are indicators are long... > > may be just sizeof(long) >...

Hi, next version of the guest exploitation of virtio-ccw adapter interrupts. Changes from the last version: - adapt to latest kvm-next - changed housekeeping for indicator locations: we now use cacheline-sized and aligned areas - minor tweaks Cornelia Huck (2): KVM: s390: virtio-ccw: Handle command rejects. KVM: s390: virtio-ccw adapter interrupt support. arch/s390/include/asm/irq.h

Hi, next version of the guest exploitation of virtio-ccw adapter interrupts. Changes from the last version: - adapt to latest kvm-next - changed housekeeping for indicator locations: we now use cacheline-sized and aligned areas - minor tweaks Cornelia Huck (2): KVM: s390: virtio-ccw: Handle command rejects. KVM: s390: virtio-ccw adapter interrupt support. arch/s390/include/asm/irq.h

Hi Michael, here are two virtio/s390 patches (one cleanup, one bugfix), prepared against your vhost branch of mst/vhost.git. Please apply. Cornelia Huck (1): virtio/s390: size of SET_IND payload Geliang Tang (1): virtio/s390: use dev_to_virtio drivers/s390/virtio/virtio_ccw.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) -- 2.3.9