search for: cce43d7

I'm not sure if this is worth pursuing. On paper, it makes sense (if we know we have multiple commands batched to send over the wire, AND those commands are short in length, we might as well use MSG_MORE), but the measurement numbers with it applied might just be in the noise. Eric Blake (2): examples: Enhance access patterns of threaded-reads-and-writes states: Another use for MSG_MORE

...run 'examples/threaded-reads-and-writes localhost 10809' my machine improved runtime from 12.68s to 12.59s. --- generator/states-issue-command.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/generator/states-issue-command.c b/generator/states-issue-command.c index cce43d7..5d2a7e6 100644 --- a/generator/states-issue-command.c +++ b/generator/states-issue-command.c @@ -42,7 +42,7 @@ h->request.count = htobe32 ((uint32_t) cmd->count); h->wbuf = &h->request; h->wlen = sizeof (h->request); - if (cmd->type == NBD_CMD_WRITE) + if (cmd-&...

...ator/states-newstyle-opt-export-name.c | 1 + generator/states-newstyle-opt-go.c | 3 +++ generator/states-newstyle-opt-set-meta-context.c | 5 +++++ 4 files changed, 11 insertions(+) diff --git a/generator/states-issue-command.c b/generator/states-issue-command.c index 627a54f..cce43d7 100644 --- a/generator/states-issue-command.c +++ b/generator/states-issue-command.c @@ -42,6 +42,8 @@ h->request.count = htobe32 ((uint32_t) cmd->count); h->wbuf = &h->request; h->wlen = sizeof (h->request); + if (cmd->type == NBD_CMD_WRITE) + h->wflags = M...

Appears to have a measurable benefit, see 3/3 for test results. Rich.