search for: cc_x86_32_thiscall

Hello Aaron, Anton, LLVM-dev, While working on http://llvm.org/PR13676#c6 I found out that whenever I compile code with class methods returning structures it get generated incompatible with MSVC. Looking at lib/Target/X86/X86CallingConv.td, I found out that CC_X86_32_ThisCall maps SRet to EAX but in fact it should push the address of the return temp on stack. The following patch fixes the issue on Windows: --------------------------------- Index: lib/Target/X86/X86CallingConv.td =================================================================== --- lib/Target/X86/X86C...

...2 at 7:03 PM, Anton Korobeynikov <asl at math.spbu.ru> wrote: > Hello Timur, > >> I'd like to ask for advice: >> a) Is it OK to change the SRet/ThisCall behaviour on non-Windows platforms? >> [I suppose no] > no > >> >> b) Should I be altering CC_X86_32_ThisCall >> OR should I introduce CC_X86_Win32_ThisCall instead? >> [Answer not clear to me - is there any platform besides Windows >> that uses thiscall?] > no Can you please clarify which question you've answered here? Sorry for making the ambiguous questions in the fi...

...gt; I'd like to ask for advice: >>>>>> a) Is it OK to change the SRet/ThisCall behaviour on non-Windows platforms? >>>>>> [I suppose no] >>>>> no >>>>> >>>>>> >>>>>> b) Should I be altering CC_X86_32_ThisCall >>>>>> OR should I introduce CC_X86_Win32_ThisCall instead? >>>>>> [Answer not clear to me - is there any platform besides Windows >>>>>> that uses thiscall?] >>>>> no >>>> Can you please clarify which ques...

On Tue, Oct 2, 2012 at 8:44 PM, Anton Korobeynikov <asl at math.spbu.ru> wrote: >>>> b) Should I be altering CC_X86_32_ThisCall >>>> OR should I introduce CC_X86_Win32_ThisCall instead? >>>> [Answer not clear to me - is there any platform besides Windows >>>> that uses thiscall?] >>> no >> Can you please clarify which question you've answered here? > To b...

Hello Timur, > I'd like to ask for advice: > a) Is it OK to change the SRet/ThisCall behaviour on non-Windows platforms? > [I suppose no] no > > b) Should I be altering CC_X86_32_ThisCall > OR should I introduce CC_X86_Win32_ThisCall instead? > [Answer not clear to me - is there any platform besides Windows > that uses thiscall?] no It seems for me that you're trying to solve the problem from the wrong end. As far as I remember, there is a difference - &quo...

...>> Hello Timur, >>> >>>> I'd like to ask for advice: >>>> a) Is it OK to change the SRet/ThisCall behaviour on non-Windows platforms? >>>> [I suppose no] >>> no >>> >>>> >>>> b) Should I be altering CC_X86_32_ThisCall >>>> OR should I introduce CC_X86_Win32_ThisCall instead? >>>> [Answer not clear to me - is there any platform besides Windows >>>> that uses thiscall?] >>> no >> Can you please clarify which question you've answered here? >>...

...;asl at math.spbu.ru> wrote: >> Hello Timur, >> >>> I'd like to ask for advice: >>> a) Is it OK to change the SRet/ThisCall behaviour on non-Windows platforms? >>> [I suppose no] >> no >> >>> >>> b) Should I be altering CC_X86_32_ThisCall >>> OR should I introduce CC_X86_Win32_ThisCall instead? >>> [Answer not clear to me - is there any platform besides Windows >>> that uses thiscall?] >> no > Can you please clarify which question you've answered here? > Sorry for making the amb...

...t;> >>>>> I'd like to ask for advice: >>>>> a) Is it OK to change the SRet/ThisCall behaviour on non-Windows platforms? >>>>> [I suppose no] >>>> no >>>> >>>>> >>>>> b) Should I be altering CC_X86_32_ThisCall >>>>> OR should I introduce CC_X86_Win32_ThisCall instead? >>>>> [Answer not clear to me - is there any platform besides Windows >>>>> that uses thiscall?] >>>> no >>> Can you please clarify which question you've answ...