search for: case_sensitive_path

From: "Richard W.M. Jones" <rjones at redhat.com> Don't assume that if guestfs_case_sensitive_path returns NULL, that it means the file does not exist. The (previously undefined) behaviour of case_sensitive_path was that a NULL return meant "either the file doesn't exist or some other error". However in commit 973581780d8a006f336684fef6762801402d775d this was changed so that if th...

Proposed patches to fix https://bugzilla.redhat.com/show_bug.cgi?id=858126

...libguestfs: trace: is_file = 0 libguestfs: trace: is_file "/grub2/grub.cfg" libguestfs: trace: is_file = 0 libguestfs: trace: is_file "/hurd/console" libguestfs: trace: is_file = 0 libguestfs: trace: is_dir "/log" libguestfs: trace: is_dir = 0 libguestfs: trace: case_sensitive_path "/windows" libguestfs: trace: case_sensitive_path = "/windows" libguestfs: trace: case_sensitive_path "/windows/system32" libguestfs: trace: case_sensitive_path = NULL (error) libguestfs: trace: case_sensitive_path "/winnt" libguestfs: trace: case_sensit...

We were unconditionally creating /temp/v2v in the guest, and later using case_sensitive_path to look the path up again. If C:\Temp already existed, this would lead to unpredictable results. Fixes RHBZ#672521 --- lib/Sys/VirtV2V/Converter/Windows.pm | 21 ++++++++++++++------- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/lib/Sys/VirtV2V/Converter/Windows.pm b/lib/Sys/...

...libguestfs: trace: is_file "/grub2/grub.cfg" > libguestfs: trace: is_file = 0 > libguestfs: trace: is_file "/hurd/console" > libguestfs: trace: is_file = 0 > libguestfs: trace: is_dir "/log" > libguestfs: trace: is_dir = 0 > libguestfs: trace: case_sensitive_path "/windows" > libguestfs: trace: case_sensitive_path = "/windows" > libguestfs: trace: case_sensitive_path "/windows/system32" > libguestfs: trace: case_sensitive_path = NULL (error) > libguestfs: trace: case_sensitive_path "/winnt" > libgu...

...e: is_file "/grub2/grub.cfg" >> libguestfs: trace: is_file = 0 >> libguestfs: trace: is_file "/hurd/console" >> libguestfs: trace: is_file = 0 >> libguestfs: trace: is_dir "/log" >> libguestfs: trace: is_dir = 0 >> libguestfs: trace: case_sensitive_path "/windows" >> libguestfs: trace: case_sensitive_path = "/windows" >> libguestfs: trace: case_sensitive_path "/windows/system32" >> libguestfs: trace: case_sensitive_path = NULL (error) >> libguestfs: trace: case_sensitive_path "/winnt"...

..._loop: new request, len 0x40 guestfsd: main_loop: proc 37 (is_file) took 0.00libguestfs: trace: is_file = 0 libguestfs: trace: is_dir "/log" seconds guestfsd: main_loop: new request, len 0x34 guestfsd: main_loop: proc 38 (is_dir) took 0.00 libguestfs: trace: is_dir = 0 libguestfs: trace: case_sensitive_path "/windows" seconds guestfsd: main_loop: new request, len 0x34 libguestfs: trace: case_sensitive_path = "/windows" libguestfs: trace: case_sensitive_path "/windows/system32" guestfsd: main_loop: proc 197 (case_sensitive_path) took 0.02 seconds guestfsd: main_loop: new r...

Greetings, I am suffering of several weird errors which show randomly and make me suspect some concurrency issue. Libguestfs version is 1.28.1, linux kernel 3.16, libvirt 1.2.9 and qemu 2.1. What I'm trying to do is comparing the disk state at two different point of a guest execution. Disk snapshots are taken through libvirt in different moments (I am aware of caching issue), from such

This is the previously controversial 1/3 patch, split into two parts. The first patch contains these changes from last time: - set errno = 0 before readdir, and check for errors after - check for other errors from the chdir call which weren't ENOTDIR - the documentation is clarified about when you might use this function - more comprehensive tests, including the corner cases Matt

...gram files/windows nt/accessories: No such file or directory ><fs> ls "win:/program files/windows nt/accessories" mswrd6.wpc mswrd8.wpc wordpad.exe write.wpc ><fs> set-trace true ><fs> ls "win:/program files/windows nt/accessories" libguestfs: trace: case_sensitive_path "/program files/windows nt/accessories" libguestfs: trace: case_sensitive_path = "/Program Files/Windows NT/Accessories" libguestfs: trace: ls "/Program Files/Windows NT/Accessories" libguestfs: trace: ls0 "/Program Files/Windows NT/Accessories" "/tmp/li...

Hi, I am running virt-v2v under CentOS 7, I use the new libguestfs-1.27.48-1.1, and when I try to import my Windows 2008 (running perfectly using virt-manager) in my cloud oVirt, I encounter this issue : ........ libguestfs: trace: mkdir_p = 0 libguestfs: trace: case_sensitive_path "/Windows/system32/drivers/viostor.sys" libguestfs: trace: case_sensitive_path = "/Windows/System32/drivers/viostor.sys" libguestfs: trace: cp "/usr/share/virtio-win/drivers/amd64/Win2008/viostor.sys" "/Windows/System32/drivers/viostor.sys" libguestfs: trace:...

...tomize/inject_virtio_win.ml >> @@ -207,10 +207,16 @@ let rec inject_virtio_win_drivers ({ g } as t) reg = >> let target = sprintf "%s/system32/drivers/%s.sys" >> t.i_windows_systemroot driver_name in >> let target = g#case_sensitive_path target in >> + let installed_block_type, legacy_pciid, modern_pciid = ( >> + if driver_name = "vioscsi" then >> + Virtio_SCSI, vioscsi_legacy_pciid, vioscsi_modern_pciid >> + else >> + Virtio_blk, viostor_legacy_...

From: "Richard W.M. Jones" <rjones at redhat.com> case_sensitive_path was not defined when called on a path where the final element doesn't exist. In libguestfs >= 1.16.29 it was changed to return non-NULL if the final element doesn't exist so that creation of new files works. --- lib/Sys/VirtConvert/Converter/Windows.pm | 8 ++------ 1 file changed, 2 i...

...uot;, $system_filename); } -sub _upload_viostor +sub _upload_files { my $g = shift; my $tmpdir = shift; @@ -351,39 +350,35 @@ sub _upload_viostor my $devices = shift; my $config = shift; - my $driverpath = "/windows/system32/drivers"; - $driverpath = $g->case_sensitive_path ($driverpath); + # Check we have all required files + my @missing; + my %files; - my ($app, $depnames) = $config->match_app ($desc, "viostor", $desc->{arch}); - $app = $config->get_transfer_path ($g, $app); - $g->cp ($app, $driverpath); -} + for my $file...

...> +++ b/mlcustomize/inject_virtio_win.ml > @@ -207,10 +207,16 @@ let rec inject_virtio_win_drivers ({ g } as t) reg = > let target = sprintf "%s/system32/drivers/%s.sys" > t.i_windows_systemroot driver_name in > let target = g#case_sensitive_path target in > + let installed_block_type, legacy_pciid, modern_pciid = ( > + if driver_name = "vioscsi" then > + Virtio_SCSI, vioscsi_legacy_pciid, vioscsi_modern_pciid > + else > + Virtio_blk, viostor_legacy_pciid, viostor_moder...

...ew request, len 0x40 guestfsd: main_loop: proc 37 (is_file) took 0.00 seconds libguestfs: trace: is_file = 0 libguestfs: trace: is_dir "/log" guestfsd: main_loop: new request, len 0x34 guestfsd: main_loop: proc 38 (is_dir) took 0.00 seconds libguestfs: trace: is_dir = 0 libguestfs: trace: case_sensitive_path "/windows" guestfsd: main_loop: new request, len 0x34 guestfsd: main_loop: proc 197 (case_sensitive_path) took 0.00 seconds libguestfs: trace: case_sensitive_path = "/windows" libguestfs: trace: case_sensitive_path "/windows/system32" guestfsd: main_loop: new request,...

...ize/inject_virtio_win.ml +++ b/mlcustomize/inject_virtio_win.ml @@ -207,10 +207,16 @@ let rec inject_virtio_win_drivers ({ g } as t) reg = let target = sprintf "%s/system32/drivers/%s.sys" t.i_windows_systemroot driver_name in let target = g#case_sensitive_path target in + let installed_block_type, legacy_pciid, modern_pciid = ( + if driver_name = "vioscsi" then + Virtio_SCSI, vioscsi_legacy_pciid, vioscsi_modern_pciid + else + Virtio_blk, viostor_legacy_pciid, viostor_modern_pciid + ) in...

...ically when automatically installing drivers. +sub _prepare_virtio_drivers +{ + my $g = shift; + my $tmpdir = shift; + my $desc = shift; + my $devices = shift; + my $config = shift; + + # Copy the target VirtIO drivers to the guest + my $driverdir = File::Spec->catdir($g->case_sensitive_path("/windows"), "Drivers/VirtIO"); + + $g->mkdir_p($driverdir); + + my ($virtio) = $config->match_app ($desc, 'virtio', $desc->{arch}); + $virtio = $config->get_transfer_path($g, $virtio); + + foreach my $src ($g->ls($virtio)) { + my $name...

...tboot_dir, firstboot_dir_win - | dir :: path -> - let firstboot_dir = - if firstboot_dir = "" then "/" ^ dir else firstboot_dir // dir in - let firstboot_dir_win = firstboot_dir_win ^ "\\" ^ dir in - let firstboot_dir = g#case_sensitive_path firstboot_dir in - g#mkdir_p firstboot_dir; - loop firstboot_dir firstboot_dir_win path - in - loop "" "C:" ["Program Files"; "Red Hat"; "Firstboot"] in - - g#mkdir_p (firstboot_dir // "scripts"); - - (* C...

On Sun, Mar 23, 2014 at 12:26:28PM +0000, Richard W.M. Jones wrote: > Secondly, we should be able to inspect all Linux guests, including > Tiny Core Linux, but it looks like in this case it is failing. This > is a bug. I had a look at how the Tiny Core Linux ISO is arranged. It loads the main operating system root partition as a single large initramfs, with optional modules loaded