search for: captiv

Test the just-fixed bug in --run failing to detect an nbdkit assertion failure. While at it, sleep less when we don't actually need to wait for the socket to be opened. Signed-off-by: Eric Blake <eblake@redhat.com> --- tests/test-captive.sh | 46 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/tests/test-captive.sh b/tests/test-captive.sh index e89c387d..88c0d818 100755 --- a/tests/test-captive.sh +++ b/tests/test-captive.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash # nbdkit -...

I'd like to propose we backport this to 1.18 and some earlier stable branches too. Rich.

Found while working on the retry filter. Swap the order of the two patches to see nbdkit ignore assertion failures with status 0. Eric Blake (2): server: Propagate unexpected nbdkit failure with --run tests: Enhance captive test server/captive.c | 43 ++++++++++++++++++++++++++++++---------- tests/test-captive.sh | 46 +++++++++++++++++++++++++++++++++++++++---- 2 files changed, 75 insertions(+), 14 deletions(-) -- 2.21.0

...lake wrote: > Test the just-fixed bug in --run failing to detect an nbdkit assertion > failure. > > While at it, sleep less when we don't actually need to wait for the > socket to be opened. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > tests/test-captive.sh | 46 +++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 42 insertions(+), 4 deletions(-) > > diff --git a/tests/test-captive.sh b/tests/test-captive.sh > index e89c387d..88c0d818 100755 > --- a/tests/test-captive.sh > +++ b/tests/test-captive.sh > @@ -1,6 +1,6...

...al.sh we have a test which looks something like this: nbdkit eval close='echo closed > file' --run 'qemu-img info $nbd' if ! grep 'closed' file; then fail; fi However there was a race condition here. nbdkit exits when the --run command exits without waiting for the captive nbdkit subprocess. Thus we couldn't be sure that the final 'closed' message got written to the file. It worked most of the time, but on slow machines the test failed. This indicates that we ought to wait for the captive nbdkit to exit. One reason is so that plugin cleanup is done be...

...NBD project has not actually yet posted a link for the preferred URI syntax; once Rich is happy with his work on that project, we can touch this up to link to that page. Reported-by: Martin Kletzander <mkletzan@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com> --- docs/nbdkit-captive.pod | 8 +++++++- server/captive.c | 14 +++++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/docs/nbdkit-captive.pod b/docs/nbdkit-captive.pod index 6f69cca5..59df6690 100644 --- a/docs/nbdkit-captive.pod +++ b/docs/nbdkit-captive.pod @@ -42,9 +42,15 @@ The follo...

...NBD project has not actually yet posted a link for the preferred URI syntax; once Rich is happy with his work on that project, we can touch this up to link to that page. Reported-by: Martin Kletzander <mkletzan@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com> --- docs/nbdkit-captive.pod | 8 +++++++- server/captive.c | 14 +++++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/docs/nbdkit-captive.pod b/docs/nbdkit-captive.pod index 6f69cca5..59df6690 100644 --- a/docs/nbdkit-captive.pod +++ b/docs/nbdkit-captive.pod @@ -42,9 +42,15 @@ The follo...

...osted a link for the > preferred URI syntax; once Rich is happy with his work on that > project, we can touch this up to link to that page. > > Reported-by: Martin Kletzander <mkletzan@redhat.com> > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > docs/nbdkit-captive.pod | 8 +++++++- > server/captive.c | 14 +++++++++++++- > 2 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/docs/nbdkit-captive.pod b/docs/nbdkit-captive.pod > index 6f69cca5..59df6690 100644 > --- a/docs/nbdkit-captive.pod > +++ b/docs/nbdkit-capti...

...that the daemon starts > up, can be pinged, and exits. > --- > [...] > .gitignore | 1 + > Makefile.am | 1 + > configure.ac | 2 + > tests/daemon/Makefile.am | 36 +++++++++++ > tests/daemon/captive-daemon.pm.in | 126 ++++++++++++++++++++++++++++++++++++++ > tests/daemon/test-daemon-start.pl | 35 +++++++++++ > 6 files changed, 201 insertions(+) > create mode 100644 tests/daemon/Makefile.am > create mode 100644 tests/daemon/captive-daemon.pm.in > create mode 100755 tests/d...

Includes a rework of the previously posted patch for --run improvements (mostly with improved comments and commit message; I decided that waiting for the captive nbdkit to exit was overkill), and four new patches. The tests are intentionally separate, to allow rearranging the order of the series to see the failures being fixed. Eric Blake (6): server: Propagate unexpected nbdkit failure with --run tests: Enhance captive test retry: Check next_ops-&g...

When running captive, we were blindly calling kill(pid) of the captive nbdkit child process and ignoring failures, even if that process has already exited unexpectedly (most likely, from an assertion failure). Thankfully, because we did not wait on the process, we are guaranteed that the nbdkit child process is either...

When running captive, we were blindly calling kill(pid) of the captive nbdkit child process, even if that process has already exited unexpectedly (most likely, from an assertion failure) and another opened in its place (pid recycling is rare, but not impossible). We need to check that the child process still exists,...

...This commit only adds a single test that check that the daemon starts up, can be pinged, and exits. --- .gitignore | 1 + Makefile.am | 1 + configure.ac | 2 + tests/daemon/Makefile.am | 36 +++++++++++ tests/daemon/captive-daemon.pm.in | 126 ++++++++++++++++++++++++++++++++++++++ tests/daemon/test-daemon-start.pl | 35 +++++++++++ 6 files changed, 201 insertions(+) create mode 100644 tests/daemon/Makefile.am create mode 100644 tests/daemon/captive-daemon.pm.in create mode 100755 tests/daemon/test-daemon-start.p...

...This commit only adds a single test that check that the daemon starts up, can be pinged, and exits. --- .gitignore | 1 + Makefile.am | 1 + configure.ac | 2 + tests/daemon/Makefile.am | 36 +++++++++++ tests/daemon/captive-daemon.pm.in | 125 ++++++++++++++++++++++++++++++++++++++ tests/daemon/test-daemon-start.pl | 35 +++++++++++ 6 files changed, 200 insertions(+) create mode 100644 tests/daemon/Makefile.am create mode 100644 tests/daemon/captive-daemon.pm.in create mode 100755 tests/daemon/test-daemon-start.p...

Can anyone recommend a captive portal solution that is compatible Shorewall? I know they are not completely secure but I have use for it. Thanks! Matt Burleigh Senior Systems Engineer 703-236-0800 ext 790 ------------------------------------------------------------------------- Using Tomcat but need to do more?...

...(= 5.26) [1], as measure to fix security issues. Debian already started backporting the fixes for this [2], thus behaving this way in current Sid installations. Since the affected Perl sources are only the local daemon testing scripts, a simple fix is to force the 'requires' for the local captive-daemon.pm module to start from the current directory: this way there is no need to manually augment @INC, and only our local module is loaded automatically. [1] https://rt.perl.org/Public/Bug/Display.html?id=127810 [2] https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html --- test...

...del after model simplification so far: model1<-lm(log(wt)~log(pes)+origin+gender+gender:log(pes)) -->six intercepts and two slopes the problem is i have some things I can't include in my analysis: 1.Very different sample sizes for each of the treatments > tapply(log(wt),origin,length) captive site wild 119 149 19 2.Substantial differences in the range of values taken by the covariate (leg length) between treatments > tapply(pes,origin,var) captive site wild 82.43601 71.44442 60.42544 > tapply(pes,origin,mean) captive site wild 147.3261 14...

...nd only if the client uses it. This partially reverts commit e71178e9b71403, although for -Wshadow reasons, we now have to name the global variable export_name due to other code in the meantime using parameters named exportname. Signed-off-by: Eric Blake <eblake@redhat.com> --- docs/nbdkit-captive.pod | 12 +++++++++++- docs/nbdkit-protocol.pod | 2 +- docs/nbdkit.pod | 18 ++++++++++++++++++ docs/synopsis.txt | 3 ++- server/internal.h | 1 + server/captive.c | 20 +++++++++++++++++--- server/main.c | 3 ++- tests/test-long-name.sh | 10 +++++...

Hello, Forgive the cross-posting, but googling showed results from these two lists. I'm looking to set up a WiFi gateway with two nics, and iptables. The catch is i have to use a captive portal as well to ensure all traffic goes to a single destination. I've read about several packages, but haven't seen any docs that say how to integrate everything. If anyone has this setup i'd appreciate knowing what software your using, and experiences with it, positive or negati...

...y 1m --run 'nbdsh -u $uri -c "print(h.get_size())"' 1048576 I wonder if there is some sort of race where an existing vsock on a different port is interfering (since the test opens up a background server on one port before the one-liner attempt on a different port). docs/nbdkit-captive.pod | 3 ++- server/internal.h | 1 + server/captive.c | 46 +++++++++++++++++++++-------------------- server/main.c | 3 +-- tests/test-vsock.sh | 21 +++++++++++++------ 5 files changed, 43 insertions(+), 31 deletions(-) diff --git a/docs/nbdkit-captive.pod b/docs/...