Displaying 5 results from an estimated 5 matches for "cannotaliasdiffargu".
2013 May 27
2
[LLVMdev] Mixing noalias and regular arguments
Kuperstein, Michael M wrote:
> Thanks Nick!
>
> Can you just check sanity before I commit?
> (Or suggest a better name for the function...)
Sure!
+static bool canNotAliasDiffArgument(const Value *V)
+{
+ return (isa<AllocaInst>(V) || isNoAliasCall(V) || isNoAliasArgument(V));
+}
Extra parens?
The name "canNotAliasDiffArgument" works, but it's named for what we
need the function to do in its sole caller. Thinking about what it does
without a specific...
2013 May 27
0
[LLVMdev] Mixing noalias and regular arguments
..., 2013 13:54
To: Kuperstein, Michael M
Cc: LLVMdev at cs.uiuc.edu
Subject: Re: [LLVMdev] Mixing noalias and regular arguments
Kuperstein, Michael M wrote:
> Thanks Nick!
>
> Can you just check sanity before I commit?
> (Or suggest a better name for the function...)
Sure!
+static bool canNotAliasDiffArgument(const Value *V) {
+ return (isa<AllocaInst>(V) || isNoAliasCall(V) ||
+isNoAliasArgument(V)); }
Extra parens?
The name "canNotAliasDiffArgument" works, but it's named for what we need the function to do in its sole caller. Thinking about what it does without a specific c...
2013 May 27
1
[LLVMdev] Mixing noalias and regular arguments
...ev at cs.uiuc.edu
> Subject: Re: [LLVMdev] Mixing noalias and regular arguments
>
> Kuperstein, Michael M wrote:
>> Thanks Nick!
>>
>> Can you just check sanity before I commit?
>> (Or suggest a better name for the function...)
>
> Sure!
>
> +static bool canNotAliasDiffArgument(const Value *V) {
> + return (isa<AllocaInst>(V) || isNoAliasCall(V) ||
> +isNoAliasArgument(V)); }
>
> Extra parens?
>
> The name "canNotAliasDiffArgument" works, but it's named for what we need the function to do in its sole caller. Thinking about what i...
2013 May 27
0
[LLVMdev] Mixing noalias and regular arguments
Thanks Nick!
Can you just check sanity before I commit?
(Or suggest a better name for the function...)
-----Original Message-----
From: Nick Lewycky [mailto:nicholas at mxc.ca]
Sent: Sunday, May 26, 2013 09:54
To: Kuperstein, Michael M
Cc: LLVMdev at cs.uiuc.edu
Subject: Re: [LLVMdev] Mixing noalias and regular arguments
Kuperstein, Michael M wrote:
> Ping?
Pong! Sorry for the slow review,
2013 May 26
2
[LLVMdev] Mixing noalias and regular arguments
Kuperstein, Michael M wrote:
> Ping?
Pong! Sorry for the slow review, I had this patch starred but hadn't got
around to it. Yes, the rationale and implementation are correct.
> (Is there a code owner for AA, btw?)
(It falls back on the more general code owner who is Chris Lattner in
this case, "Everything not covered by someone else".)
+/// isNoAliasArgument - Return true