search for: cancel_delayed_work

...ch is merged, as the code in ramster that provoked it is directly leveraged from ocfs2 o2net. > From: Tejun Heo [mailto:tj at kernel.org] > Sent: Thursday, October 18, 2012 5:39 PM > To: Dan Magenheimer > Cc: linux-kernel at vger.kernel.org; Konrad Wilk > Subject: [PATCH] workqueue: cancel_delayed_work() should return %NULL if work item is idle > > From e65120fcfc1cb9697655d29ecd7982451c05d3c2 Mon Sep 17 00:00:00 2001 > From: Dan Magenheimer <dan.magenheimer at oracle.com> > Date: Thu, 18 Oct 2012 16:31:37 -0700 > > 57b30ae77b ("workqueue: reimplement cancel_delayed...

This fix modifies o2net layer behavior which seems to trigger some DLM race issues during umount/evictions that needs to be fixed as well. I am working on the dlm issues but meanwhile please review this patch. Thanks, --Srini

Patch 5 has been respun with the recommended change... remove the ex argument in ocfs2_orphan_scan_lock() and ocfs2_orphan_scan_unlock(). Sunil

...* conn_up, conn_err, or hb_up */ -void o2quo_hb_down(u8 node) +void o2quo_hb_down(struct o2nm_node *_node, int node, void *data) { struct o2quo_state *qs = &o2quo_state; @@ -226,6 +237,8 @@ void o2quo_hb_down(u8 node) o2quo_clear_hold(qs, node); spin_unlock(&qs->qs_lock); + + cancel_delayed_work(&qs->qs_node_work[node]); } /* this tells us that we've decided that the node is still heartbeating @@ -233,9 +246,10 @@ void o2quo_hb_down(u8 node) * and indicates that we must now make a quorum decision in the future, * though we might be doing so after waiting for holds to dra...

...3 +++ 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 51c93929a146..d90961a1c433 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c @@ -6308,11 +6308,13 @@ void ocfs2_truncate_log_shutdown(struct ocfs2_super *osb) if (tl_inode) { cancel_delayed_work(&osb->osb_truncate_log_wq); - flush_workqueue(osb->ocfs2_wq); + if (!is_journal_aborted(osb->journal->j_journal)) { + flush_workqueue(osb->ocfs2_wq); - status = ocfs2_flush_truncate_log(osb); - if (status < 0) - mlog_errno(status); + status = ocfs2_flush_truncate_l...

Implemented the suggestions. Also, moved the ocfs2_orphan_scan_init() to the end of ocfs2_fill_super() instead of calling it earlier in ocfs2_initialize_super(). Sunil

...9; is deprecated (declared at include/linux/slab.h:17) /data/images/keymaker/home/accountadmin/ocfs2-1.2.6/fs/ocfs2/alloc.c: In function `ocfs2_schedule_truncate_log_flush': /data/images/keymaker/home/accountadmin/ocfs2-1.2.6/fs/ocfs2/alloc.c:1228: warning: passing arg 1 of `cancel_delayed_work' from incompatible pointer type /data/images/keymaker/home/accountadmin/ocfs2-1.2.6/fs/ocfs2/alloc.c:1231: warning: passing arg 2 of `queue_delayed_work' from incompatible pointer type /data/images/keymaker/home/accountadmin/ocfs2-1.2.6/fs/ocfs2/alloc.c: In function...

This patch adds jbd_lock_bh_state() and jbd_unlock_bh_state() around accessses to jh->b_committed_data. Fixes oss bugzilla#1131 http://oss.oracle.com/bugzilla/show_bug.cgi?id=1131 Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com> --- fs/ocfs2/suballoc.c | 28 ++++++++++++++++++++++++---- 1 files changed, 24 insertions(+), 4 deletions(-) diff --git a/fs/ocfs2/suballoc.c

fstest generic cases 266 272 281 trigger hanging issue when umount. I use 266 to describe the root cause. ``` 49 _dmerror_unmount 50 _dmerror_mount 51 52 echo "Compare files" 53 md5sum $testdir/file1 | _filter_scratch 54 md5sum $testdir/file2 | _filter_scratch 55 56 echo "CoW and unmount" 57 sync 58 _dmerror_load_error_table 59 urk=$($XFS_IO_PROG -f -c "pwrite

Next two patches are backport of orphan scan timer patches to ocfs2-1.4

..._num_from_nn(nn)); - /* this is a bit of a hack. we only try reconnecting - * when heartbeating starts until we get a connection. - * if that connection then dies we don't try reconnecting. - * the only way to start connecting again is to down - * heartbeat and bring it back up. */ cancel_delayed_work(&nn->nn_connect_expired); printk(KERN_INFO "o2net: %s " SC_NODEF_FMT "\n", o2nm_this_node() > sc->sc_node->nd_num ? @@ -457,6 +450,8 @@ static void o2net_set_nn_state(struct o2 delay = 0; mlog(ML_CONN, "queueing conn attempt in %lu jiffie...

..._num_from_nn(nn)); - /* this is a bit of a hack. we only try reconnecting - * when heartbeating starts until we get a connection. - * if that connection then dies we don't try reconnecting. - * the only way to start connecting again is to down - * heartbeat and bring it back up. */ cancel_delayed_work(&nn->nn_connect_expired); printk(KERN_INFO "o2net: %s " SC_NODEF_FMT "\n", o2nm_this_node() > sc->sc_node->nd_num ? @@ -457,6 +450,18 @@ static void o2net_set_nn_state(struct o2 delay = 0; mlog(ML_CONN, "queueing conn attempt in %lu jiffi...

Resending after implementing review comments.

Resending after implementing review comments.

Resending after adding another patch to display delayed orphan scan statistics.

...o_jiffies(ocfs2_orphan_scan_timeout()) >> 2); + mutex_unlock(&ds->ds_lock); +} + +void ocfs2_delayed_orphan_scan_stop(struct ocfs2_super *osb) +{ + struct ocfs2_delayed_orphan_scan *ds; + ds = osb->osb_delayed_orphan_scan; + if (!ds) + return; + + mutex_lock(&ds->ds_lock); + cancel_delayed_work(&ds->ds_delayed_orphan_scan_work); + mutex_unlock(&ds->ds_lock); +} + +void ocfs2_delayed_orphan_scan_exit(struct ocfs2_super *osb) +{ + struct ocfs2_delayed_orphan_scan *ds; + ds = osb->osb_delayed_orphan_scan; + if (!ds) + return; + + kfree(ds); +} + +int ocfs2_delayed_orphan_sc...

All, Please review the patches backported to 1.4 from mainline. Sunil

This is a pair of Xen para-virtual frontend device drivers: drivers/video/xen-fbfront.c provides a framebuffer, and drivers/input/xen-kbdfront provides keyboard and mouse. The backends run in dom0 user space. I started with the Xen version at http://xenbits.xensource.com/linux-2.6.18-xen.hg?rev/ca05cf1a9bdc Differences to that Xen version, for those who care: * Rewritten on top of fb deferred

This is a pair of Xen para-virtual frontend device drivers: drivers/video/xen-fbfront.c provides a framebuffer, and drivers/input/xen-kbdfront provides keyboard and mouse. The backends run in dom0 user space. I started with the Xen version at http://xenbits.xensource.com/linux-2.6.18-xen.hg?rev/ca05cf1a9bdc Differences to that Xen version, for those who care: * Rewritten on top of fb deferred

This is a pair of Xen para-virtual frontend device drivers: drivers/video/xen-fbfront.c provides a framebuffer, and drivers/input/xen-kbdfront provides keyboard and mouse. The backends run in dom0 user space. I started with the Xen version at http://xenbits.xensource.com/linux-2.6.18-xen.hg?rev/ca05cf1a9bdc Differences to that Xen version, for those who care: * Rewritten on top of fb deferred