search for: canbeomittedfromsymboltable

...i’d really like to know if anyone is fundamentally opposed to this. I should note, a couple of issues have come up in the prototype. - llvm::getDISubprogram was walking the function body to find the subprogram. This is trivial to fix as functions now have !dbg on them. - The AsmPrinter is calling canBeOmittedFromSymbolTable on GlobalValue’s which then walks all their uses. I think this should be done earlier in codegen as an analysis whose results are available to the AsmPrinter. - BB’s whose addresses are taken, i.e. jump tables, can’t be deleted. Those functions will just keep their IR around so no changes there....

...couple of issues have come up in the prototype. > - llvm::getDISubprogram was walking the function body to find the subprogram. This is trivial to fix as functions now have !dbg on them. > > This is definitely worth it, please go ahead and do this. > > - The AsmPrinter is calling canBeOmittedFromSymbolTable on GlobalValue’s which then walks all their uses. I think this should be done earlier in codegen as an analysis whose results are available to the AsmPrinter. > > I think this makes sense, but I worry about late added GlobalValues during code gen? How would we cope with that? Example: Let...

...now if anyone is fundamentally opposed to this. > > I should note, a couple of issues have come up in the prototype. > - llvm::getDISubprogram was walking the function body to find the subprogram. This is trivial to fix as functions now have !dbg on them. > - The AsmPrinter is calling canBeOmittedFromSymbolTable on GlobalValue’s which then walks all their uses. I think this should be done earlier in codegen as an analysis whose results are available to the AsmPrinter. > - BB’s whose addresses are taken, i.e. jump tables, can’t be deleted. Those functions will just keep their IR around so no changes th...

...> > > subprogram. This is trivial to fix as functions now have !dbg > > > > on > > > > them. > > > > > > > > > This is definitely worth it, please go ahead and do this. > > > > > > > - The AsmPrinter is calling canBeOmittedFromSymbolTable on > > > > GlobalValue’s which then walks all their uses. I think this > > > > should > > > > be done earlier in codegen as an analysis whose results are > > > > available to the AsmPrinter. > > > > > > > > > I think thi...

...fundamentally opposed to this. >> >> I should note, a couple of issues have come up in the prototype. >> - llvm::getDISubprogram was walking the function body to find the subprogram. This is trivial to fix as functions now have !dbg on them. >> - The AsmPrinter is calling canBeOmittedFromSymbolTable on GlobalValue’s which then walks all their uses. I think this should be done earlier in codegen as an analysis whose results are available to the AsmPrinter. >> - BB’s whose addresses are taken, i.e. jump tables, can’t be deleted. Those functions will just keep their IR around so no change...