search for: can_resize

...s > to add resize and block status commands to NBD. In your implementation, > if a filter does not define .can_flush or .flush, then its .can_flush > implementation merely returns whatever the underlying backend's version > would report. But as we add new callbacks, such as a new .can_resize, > we need to make sure we have sane defaults. For example, the offset > filter should probably not allow resizes (even if the underlying plugin > does). If the offset filter compiled in a version of nbdkit that lacks > the .can_resize hook is run by nbdkit that has added the hook, we...

On 01/17/2018 02:53 PM, Richard W.M. Jones wrote: > Previously the file plugin supported ‘rdelay’ and ‘wdelay’ parameters > for injecting delays (for testing) into read and write requests. This > moves the functionality to a new delay filter so that it can be used > with any plugin. > --- > +/* Write data. */ > +static int > +delay_pwrite (struct nbdkit_next *next, void

..., there are proposals to add resize and block status commands to NBD. In your implementation, if a filter does not define .can_flush or .flush, then its .can_flush implementation merely returns whatever the underlying backend's version would report. But as we add new callbacks, such as a new .can_resize, we need to make sure we have sane defaults. For example, the offset filter should probably not allow resizes (even if the underlying plugin does). If the offset filter compiled in a version of nbdkit that lacks the .can_resize hook is run by nbdkit that has added the hook, we therefore want to d...

...&5 > +} | qemu-io -f raw nbd:unix:$sock >> truncate4.out || fail=1 > +exec 4>&- > + > +cat truncate4.out > +grep 'Pattern verification failed' truncate4.out && fail=1 > +exit $fail I guess this test will break in future if we implement and return ‘can_resize = true’ in the file plugin? Or will the (also updated) truncate filter be able to cope? Anyway since we can adjust or remove the test if necessary later, ACK RIch. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: htt...

While working on adding assertions to pthread_mutex_lock calls, I noticed that the truncate filter's use of mutex didn't really protect us, and isn't really necessary. Cleaning that up also spotted a couple of other potential cleanups. Eric Blake (4): filters: Drop useless .open callbacks truncate: Fix corruption when plugin changes per-connection size truncate: Test for safe