Displaying 2 results from an estimated 2 matches for "can_leave_stale".
2018 Aug 02
2
Re: [PATCH 1/3] file: Avoid unsupported fallocate() calls
On 08/02/2018 02:05 PM, Nir Soffer wrote:
> When using file systems not supporting ZERO_RANGE (e.g. NFS 4.2) or
> block device on kernel < 4.9, we used to call fallocate() for every
> zero, fail with EOPNOTSUPP, and fallback to manual zeroing. When
> trimming, we used to try unsupported fallocate() on every call.
>
> Change file handle to remember if punching holes or
2018 Aug 02
0
Re: [PATCH 1/3] file: Avoid unsupported fallocate() calls
...r = -1;
> > +
> > + if (h->can_punch_hole) {
> > + r = do_fallocate (h->fd, FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE,
> > + offset, count);
>
> Should we also use FALLOC_FL_NO_HIDE_STALE here, if it is available?
>
We can add h->can_leave_stale, and use it if available. But I don't think
it will give much with typical request size.
Do you think it worth the effort?
Nir