search for: callsitesplitting

Hello! I've discovered that `CallSiteSplitting` optimization doesn't support musttail calls. The easiest fix as it stands is disabling it for such call sites: https://reviews.llvm.org/D43729 . However, I'm not happy with such contribution. My more sophisticated attempt has failed due to my poor understanding of llvm internals. Here is...

...laces all of the instructions into the split block, so that the original block becomes empty. Is it expected behavior, or am I doing something wrong? Thanks, Fedor. On Sat, Feb 24, 2018 at 2:16 AM, Fedor Indutny <fedor at indutny.com> wrote: > Hello! > > I've discovered that `CallSiteSplitting` optimization doesn't support > musttail calls. The easiest fix as it stands is disabling it for such call > sites: https://reviews.llvm.org/D43729 . However, I'm not happy with such > contribution. > > My more sophisticated attempt has failed due to my poor understanding of...

Hi, On 27/02/2018 16:32, Daniel Berlin via llvm-dev wrote: > I think you realized this now, but to be clear: > More likely, you've found some bugs. > Unfortunately, not all of these utilities have good unit tests (though > they should!). > > This would not be the first set of bugs people have found wrt to very > start/end of blocks, or bb == predbb issues. >

...o that the original > block becomes empty. > > Is it expected behavior, or am I doing something wrong? > > Thanks, > Fedor. > > On Sat, Feb 24, 2018 at 2:16 AM, Fedor Indutny <fedor at indutny.com> wrote: > >> Hello! >> >> I've discovered that `CallSiteSplitting` optimization doesn't support >> musttail calls. The easiest fix as it stands is disabling it for such call >> sites: https://reviews.llvm.org/D43729 . However, I'm not happy with >> such contribution. >> >> My more sophisticated attempt has failed due to my po...